From 1f857ddf526fcb84ce8ae0ed5dbc80b16484e7c7 Mon Sep 17 00:00:00 2001 From: Davide Grilli Date: Mon, 22 Jun 2026 00:02:32 +0200 Subject: [PATCH] refactor(ui): remove SPV badge from tx detail and history MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit SPV is the only verification method the wallet uses, so showing it as a badge adds no information — if a transaction appears confirmed, it has already passed Merkle verification. - Remove the SPV chip from the transaction detail overlay - Remove the Verificata column from the history list (desktop and mobile) - Drop VerifiedText property from TransactionDetailsViewModel - Drop the Verificata field from HistoryRow - Remove the orphaned tx.verified loc key --- src/App/Localization/Loc.cs | 3 +-- .../ViewModels/MainWindowViewModel.Receive.cs | 3 +-- src/App/ViewModels/MainWindowViewModel.cs | 2 +- .../ViewModels/TransactionDetailsViewModel.cs | 3 --- src/App/Views/MainView.axaml | 27 +++---------------- 5 files changed, 7 insertions(+), 31 deletions(-) diff --git a/src/App/Localization/Loc.cs b/src/App/Localization/Loc.cs index 1381f5b..785d148 100644 --- a/src/App/Localization/Loc.cs +++ b/src/App/Localization/Loc.cs @@ -225,8 +225,7 @@ public sealed class Loc ["tx.size.total"] = ["Dimensione totale", "Total size", "Tamaño total", "Taille totale", "Tamanho total", "Gesamtgröße"], ["tx.size.virtual"] = ["Dimensione virtuale", "Virtual size", "Tamaño virtual", "Taille virtuelle", "Tamanho virtual", "Virtuelle Größe"], ["tx.rbf"] = ["Sostituibile (RBF)", "Replaceable (RBF)", "Reemplazable (RBF)", "Remplaçable (RBF)", "Substituível (RBF)", "Ersetzbar (RBF)"], - ["tx.verified"] = ["Verifica SPV", "SPV verification", "Verificación SPV", "Vérification SPV", "Verificação SPV", "SPV-Prüfung"], - ["tx.inputs"] = ["Input", "Inputs", "Entradas", "Entrées", "Entradas", "Eingänge"], +["tx.inputs"] = ["Input", "Inputs", "Entradas", "Entrées", "Entradas", "Eingänge"], ["tx.outputs"] = ["Output", "Outputs", "Salidas", "Sorties", "Saídas", "Ausgänge"], ["tx.yes"] = ["Sì", "Yes", "Sí", "Oui", "Sim", "Ja"], ["tx.no"] = ["No", "No", "No", "Non", "Não", "Nein"], diff --git a/src/App/ViewModels/MainWindowViewModel.Receive.cs b/src/App/ViewModels/MainWindowViewModel.Receive.cs index c4f5c2e..1e38b4d 100644 --- a/src/App/ViewModels/MainWindowViewModel.Receive.cs +++ b/src/App/ViewModels/MainWindowViewModel.Receive.cs @@ -272,8 +272,7 @@ public partial class MainWindowViewModel History.Add(new HistoryRow( tx.Height > 0 ? tx.Height.ToString() : "mempool", (tx.DeltaSats >= 0 ? "+" : "") + Fmt(tx.DeltaSats, withLabel: false), - tx.Txid, - tx.Verified ? "✓ SPV" : "—")); + tx.Txid)); Addresses.Clear(); foreach (var a in cache.Addresses) diff --git a/src/App/ViewModels/MainWindowViewModel.cs b/src/App/ViewModels/MainWindowViewModel.cs index 7113d8d..94fff7a 100644 --- a/src/App/ViewModels/MainWindowViewModel.cs +++ b/src/App/ViewModels/MainWindowViewModel.cs @@ -17,7 +17,7 @@ using PalladiumWallet.Core.Wallet; namespace PalladiumWallet.App.ViewModels; /// Transaction history row for the view. -public sealed record HistoryRow(string Conferma, string Importo, string Txid, string Verificata); +public sealed record HistoryRow(string Conferma, string Importo, string Txid); /// Address view row with pre-computed keys and derivation path. public sealed record AddressRow( diff --git a/src/App/ViewModels/TransactionDetailsViewModel.cs b/src/App/ViewModels/TransactionDetailsViewModel.cs index 71ec542..d1860d8 100644 --- a/src/App/ViewModels/TransactionDetailsViewModel.cs +++ b/src/App/ViewModels/TransactionDetailsViewModel.cs @@ -62,8 +62,6 @@ public sealed class TransactionDetailsViewModel VersionText = d.Version.ToString(); LockTimeText = d.LockTime.ToString(); RbfText = loc[d.RbfSignaled ? "tx.yes" : "tx.no"]; - VerifiedText = d.Verified ? "✓ SPV" : "—"; - Inputs = new ObservableCollection(d.Inputs.Select((i, n) => new TxIoRow( i.IsCoinbase ? loc["tx.coinbase"] : $"{Shorten(i.PrevTxid)}:{i.PrevIndex}", i.IsCoinbase ? loc["tx.coinbase.newcoins"] : i.Address ?? "—", @@ -93,7 +91,6 @@ public sealed class TransactionDetailsViewModel public string VersionText { get; } public string LockTimeText { get; } public string RbfText { get; } - public string VerifiedText { get; } public ObservableCollection Inputs { get; } public ObservableCollection Outputs { get; } diff --git a/src/App/Views/MainView.axaml b/src/App/Views/MainView.axaml index efb058d..e209700 100644 --- a/src/App/Views/MainView.axaml +++ b/src/App/Views/MainView.axaml @@ -369,25 +369,20 @@ - - + - - - - - + @@ -1067,20 +1062,6 @@ FontSize="12" FontWeight="SemiBold" VerticalAlignment="Center"/> - - - - - - - - - -