feat(wallet): IWalletAccount abstraction and WIF/xpub/xprv keystore import types

Introduce IWalletAccount interface to abstract HD, imported-xprv, WIF, and watch-only account types. HdAccount implements the interface; the new ImportedKeyAccount handles lists of WIF keys with fixed addresses (no gap scanning, change returns to first address). WalletLoader gains three factory methods: - NewFromXpub: watch-only from SLIP-132 xpub/ypub/zpub - NewFromXprv: spendable from SLIP-132 xprv/yprv/zprv - NewFromWif: spendable from one or more WIF private keys WalletDocument gains optional AccountXprv and WifKeys fields; AccountPath and AccountXpub become nullable (absent for WIF wallets). IsWatchOnly updated to cover all non-signing wallet kinds. TransactionFactory and CLI OpenWallet() updated to IWalletAccount. 12 new unit tests in ImportedKeyAccountTests cover factory round-trips, address derivation, and watch-only detection.
2026-06-15 14:20:10 +02:00
parent 002c854497
commit 47b6064964
9 changed files with 459 additions and 18 deletions
@@ -0,0 +1,203 @@
+using NBitcoin;
+using PalladiumWallet.Core.Chain;
+using PalladiumWallet.Core.Crypto;
+using PalladiumWallet.Core.Wallet;
+
+namespace PalladiumWallet.Tests.Wallet;
+
+/// <summary>
+/// Test per ImportedKeyAccount e i nuovi percorsi factory in WalletLoader
+/// (blueprint §4.4 — importati WIF, xpub, xprv).
+/// </summary>
+public class ImportedKeyAccountTests
+{
+    private static ChainProfile Profile => ChainProfiles.Mainnet;
+    private static Network Network => PalladiumNetworks.For(Profile.Kind);
+
+    // Chiave WIF valida per PLM mainnet (prefix 0x80 = Compressed WIF "K"/"L")
+    private static Key GenerateKey() => new Key();
+
+    private static string ToWif(Key key) => key.GetWif(Network).ToString();
+
+    // ---- ImportedKeyAccount ----
+
+    [Fact]
+    public void Account_importato_non_e_hd()
+    {
+        var key = GenerateKey();
+        var addr = key.PubKey.GetAddress(ScriptPubKeyType.Segwit, Network);
+        var account = new ImportedKeyAccount(
+            [(addr, key)], ScriptKind.NativeSegwit, Profile);
+
+        Assert.False(account.IsWatchOnly);
+        Assert.Equal(ScriptKind.NativeSegwit, account.Kind);
+        Assert.NotNull(account.FixedAddresses);
+    }
+
+    [Fact]
+    public void GetAddress_restituisce_indirizzo_corretto()
+    {
+        var key = GenerateKey();
+        var addr = key.PubKey.GetAddress(ScriptPubKeyType.Segwit, Network);
+        var account = new ImportedKeyAccount([(addr, key)], ScriptKind.NativeSegwit, Profile);
+
+        Assert.Equal(addr.ToString(), account.GetAddress(false, 0).ToString());
+        Assert.Equal(addr.ToString(), account.GetReceiveAddress(0).ToString());
+        // Change → primo indirizzo
+        Assert.Equal(addr.ToString(), account.GetChangeAddress(0).ToString());
+    }
+
+    [Fact]
+    public void GetPrivateKey_restituisce_chiave_corretta()
+    {
+        var key = GenerateKey();
+        var addr = key.PubKey.GetAddress(ScriptPubKeyType.Segwit, Network);
+        var account = new ImportedKeyAccount([(addr, key)], ScriptKind.NativeSegwit, Profile);
+
+        var retrieved = account.GetPrivateKey(false, 0);
+        Assert.NotNull(retrieved);
+        Assert.Equal(key.ToBytes(), retrieved!.ToBytes());
+    }
+
+    [Fact]
+    public void GetPrivateKey_fuori_range_restituisce_null()
+    {
+        var key = GenerateKey();
+        var addr = key.PubKey.GetAddress(ScriptPubKeyType.Segwit, Network);
+        var account = new ImportedKeyAccount([(addr, key)], ScriptKind.NativeSegwit, Profile);
+
+        Assert.Null(account.GetPrivateKey(false, 99));
+        Assert.Null(account.GetPrivateKey(true, 0));
+    }
+
+    [Fact]
+    public void Account_watch_only_se_nessuna_chiave_privata()
+    {
+        var key = GenerateKey();
+        var addr = key.PubKey.GetAddress(ScriptPubKeyType.Segwit, Network);
+        var account = new ImportedKeyAccount(
+            [(addr, (Key?)null)], ScriptKind.NativeSegwit, Profile);
+
+        Assert.True(account.IsWatchOnly);
+        Assert.Null(account.GetPrivateKey(false, 0));
+    }
+
+    [Fact]
+    public void FixedAddresses_copre_tutti_gli_indirizzi()
+    {
+        var keys = Enumerable.Range(0, 3).Select(_ => GenerateKey()).ToList();
+        var entries = keys
+            .Select(k => (k.PubKey.GetAddress(ScriptPubKeyType.Segwit, Network), (Key?)k))
+            .ToList();
+        var account = new ImportedKeyAccount(entries, ScriptKind.NativeSegwit, Profile);
+
+        var fixed_ = account.FixedAddresses!;
+        Assert.Equal(3, fixed_.Count);
+        for (var i = 0; i < 3; i++)
+        {
+            Assert.Equal(entries[i].Item1.ToString(), fixed_[i].Address.ToString());
+            Assert.False(fixed_[i].IsChange);
+            Assert.Equal(i, fixed_[i].Index);
+        }
+    }
+
+    // ---- WalletLoader.NewFromWif ----
+
+    [Fact]
+    public void NewFromWif_crea_account_con_indirizzi_corretti()
+    {
+        var key = GenerateKey();
+        var wif = ToWif(key);
+        var (doc, account) = WalletLoader.NewFromWif([wif], ScriptKind.NativeSegwit, Profile);
+
+        Assert.Null(doc.Mnemonic);
+        Assert.NotNull(doc.WifKeys);
+        Assert.Single(doc.WifKeys!);
+        Assert.False(doc.IsWatchOnly);
+        Assert.Equal(ScriptKind.NativeSegwit.ToString(), doc.ScriptKind);
+
+        var expected = key.PubKey.GetAddress(ScriptPubKeyType.Segwit, Network).ToString();
+        Assert.Equal(expected, account.GetReceiveAddress(0).ToString());
+    }
+
+    [Fact]
+    public void NewFromWif_roundtrip_persiste_e_ricarica()
+    {
+        var key = GenerateKey();
+        var wif = ToWif(key);
+        var (doc, original) = WalletLoader.NewFromWif([wif], ScriptKind.NativeSegwit, Profile);
+
+        var reloaded = WalletLoader.ToAccount(doc);
+        Assert.IsType<ImportedKeyAccount>(reloaded);
+        Assert.Equal(
+            original.GetReceiveAddress(0).ToString(),
+            reloaded.GetReceiveAddress(0).ToString());
+        Assert.False(reloaded.IsWatchOnly);
+    }
+
+    [Fact]
+    public void NewFromWif_wif_invalido_lancia_eccezione()
+    {
+        Assert.Throws<InvalidDataException>(
+            () => WalletLoader.NewFromWif(["not-a-wif"], ScriptKind.NativeSegwit, Profile));
+    }
+
+    // ---- WalletLoader.NewFromXpub ----
+
+    [Fact]
+    public void NewFromXpub_produce_account_watch_only()
+    {
+        // Crea un HD account, esporta la zpub, reimporta come xpub watch-only.
+        var (_, hdFull) = WalletLoader.NewFromMnemonic(
+            "abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon about",
+            null, ScriptKind.NativeSegwit, Profile);
+
+        var zpub = hdFull.ToSlip132();
+        var (doc, woAccount) = WalletLoader.NewFromXpub(zpub, Profile);
+
+        Assert.True(woAccount.IsWatchOnly);
+        Assert.Null(doc.Mnemonic);
+        Assert.Equal(
+            hdFull.GetReceiveAddress(0).ToString(),
+            woAccount.GetReceiveAddress(0).ToString());
+    }
+
+    // ---- WalletLoader.NewFromXprv ----
+
+    [Fact]
+    public void NewFromXprv_produce_account_spendibile()
+    {
+        var (_, hdFull) = WalletLoader.NewFromMnemonic(
+            "abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon about",
+            null, ScriptKind.NativeSegwit, Profile);
+
+        var zprv = hdFull.ToSlip132Private();
+        var (doc, xprvAccount) = WalletLoader.NewFromXprv(zprv, Profile);
+
+        Assert.False(xprvAccount.IsWatchOnly);
+        Assert.NotNull(doc.AccountXprv);
+        Assert.Null(doc.Mnemonic);
+        Assert.Equal(
+            hdFull.GetReceiveAddress(0).ToString(),
+            xprvAccount.GetReceiveAddress(0).ToString());
+        Assert.NotNull(xprvAccount.GetPrivateKey(false, 0));
+    }
+
+    [Fact]
+    public void NewFromXprv_roundtrip_persiste_e_ricarica()
+    {
+        var (_, hdFull) = WalletLoader.NewFromMnemonic(
+            "abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon about",
+            null, ScriptKind.NativeSegwit, Profile);
+
+        var zprv = hdFull.ToSlip132Private();
+        var (doc, _) = WalletLoader.NewFromXprv(zprv, Profile);
+
+        var reloaded = WalletLoader.ToAccount(doc);
+        Assert.IsType<HdAccount>(reloaded);
+        Assert.False(reloaded.IsWatchOnly);
+        Assert.Equal(
+            hdFull.GetReceiveAddress(0).ToString(),
+            reloaded.GetReceiveAddress(0).ToString());
+    }
+}