davide/ecommerce-platform
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

fix(product): fix cart deduplication for products without variants

Browse Source 
addToCart() compared item.variantId === selectedVariant where
selectedVariant is null but saved items store variantId: undefined.
null !== undefined caused findIndex to never match, always inserting
a duplicate instead of incrementing quantity. Normalised with || undefined.
This commit is contained in:
Davide Grilli
2026-05-19 16:04:22 +02:00
parent 2526cf9543
commit 8bfd7afdcb
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
app/src/app/products/[slug]/page.tsx
+7 -2
View File
@@ -54,7 +54,7 @@ export default function ProductDetailPage() {
const cart = JSON.parse(localStorage.getItem('cart') || '[]') const cart = JSON.parse(localStorage.getItem('cart') || '[]')
const existingIndex = cart.findIndex( const existingIndex = cart.findIndex(
(item: { productId: string; variantId?: string }) => (item: { productId: string; variantId?: string }) =>
item.productId === product.id && item.variantId === selectedVariant item.productId === product.id && item.variantId === (selectedVariant || undefined)
) )
if (existingIndex >= 0) { if (existingIndex >= 0) {
@@ -249,7 +249,12 @@ export default function ProductDetailPage() {
size="lg" size="lg"
variant="secondary" variant="secondary"
onClick={() => { onClick={() => {
addToCart() const cart = JSON.parse(localStorage.getItem('cart') || '[]')
const alreadyInCart = cart.some(
(item: { productId: string; variantId?: string }) =>
item.productId === product.id && item.variantId === (selectedVariant || undefined)
)
if (!alreadyInCart) addToCart()
router.push('/cart') router.push('/cart')
}} }}
> >