davide/palladiumcore
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
Files
df54973334956f4f5f78cbaca80f1e75337264a9
palladiumcore/src
History
Davide Grilli ac6ae69329 fix: implement BIP341 key tweaking for P2TR transaction signing 
This commit fixes P2TR (Pay-to-Taproot) transaction signing by properly
implementing BIP341 key path spending.

Key changes:
- Add SignSchnorrTaproot() method to CKey for BIP341 tweaked signing
- Implement ComputeTapTweak() and CreatePayToTaprootPubKey() in XOnlyPubKey
- Add GetTaprootInternalKey() to SigningProvider interface for internal key lookup
- Store taproot internal key mappings in LegacyScriptPubKeyMan
- Fix FindTaprootPubKey() to use internal key mapping with fallback
- Use empty scriptCode for Taproot key-path spending (per BIP341 spec)
- Update HaveTaprootKey() to verify tweaked keys correctly

Technical details:
- Internal keys are tweaked using secp256k1_keypair_xonly_tweak_add
- Parity handling is automatic via secp256k1 library
- Empty scriptCode ensures correct sighash for key-path spending
- Internal key to output key mapping stored for efficient lookup

Testing:
- P2TR address creation, funding, and spending work end-to-end
- Multi-hop P2TR transactions tested successfully
- All functional tests pass (feature_taproot.py, wallet_*, rpc_*)

Fixes: non-mandatory-script-verify-flag error on P2TR spending
2026-02-08 00:55:02 +01:00
..
bench
1.1.0
2024-03-15 18:16:03 +01:00
compat
1.1.0
2024-03-15 18:16:03 +01:00
config
1.1.0
2024-03-15 18:16:03 +01:00
consensus
consensus: add taproot deployment (BIP9 mainnet, always-active regtest)
2026-02-06 15:44:58 +01:00
crc32c
1.1.0
2024-03-15 18:16:03 +01:00
crypto
1.1.0
2024-03-15 18:16:03 +01:00
index
1.1.0
2024-03-15 18:16:03 +01:00
interfaces
1.1.0
2024-03-15 18:16:03 +01:00
leveldb
1.1.0
2024-03-15 18:16:03 +01:00
logging
1.1.0
2024-03-15 18:16:03 +01:00
node
1.1.0
2024-03-15 18:16:03 +01:00
policy
validation,policy,test: activate taproot flags and harden wallet fs checks
2026-02-07 10:55:38 +01:00
primitives
fix
2025-10-22 20:59:33 +02:00
qt
qt: switch receive address selection to dropdown (legacy/p2sh-segwit/bech32/bech32m)
2026-02-07 23:01:20 +01:00
rpc
wallet,rpc,descriptor: add bech32m and taproot address/spend support
2026-02-07 12:13:51 +01:00
script
fix: implement BIP341 key tweaking for P2TR transaction signing
2026-02-08 00:55:02 +01:00
secp256k1
build(secp256k1): upgrade to bitcoin-core v24.2 with taproot modules
2026-02-06 10:19:01 +01:00
support
Fix compilation with modern GCC (Ubuntu 24.04+)
2026-01-26 17:30:11 +01:00
test
encoding,test: backport BIP350 bech32m and align test vectors to Palladium
2026-02-06 15:23:23 +01:00
univalue
v1.1.0
2024-03-15 18:21:54 +01:00
util
Fix compilation with modern GCC (Ubuntu 24.04+)
2026-01-26 17:30:11 +01:00
wallet
fix: implement BIP341 key tweaking for P2TR transaction signing
2026-02-08 00:55:02 +01:00
zmq
1.1.0
2024-03-15 18:16:03 +01:00
.clang-format
1.1.0
2024-03-15 18:16:03 +01:00
addrdb.cpp
1.1.0
2024-03-15 18:16:03 +01:00
addrdb.h
1.1.0
2024-03-15 18:16:03 +01:00
addrman.cpp
1.1.0
2024-03-15 18:16:03 +01:00
addrman.h
1.1.0
2024-03-15 18:16:03 +01:00
amount.h
1.1.0
2024-03-15 18:16:03 +01:00
arith_uint256.cpp
1.1.0
2024-03-15 18:16:03 +01:00
arith_uint256.h
1.1.0
2024-03-15 18:16:03 +01:00
attributes.h
1.1.0
2024-03-15 18:16:03 +01:00
banman.cpp
1.1.0
2024-03-15 18:16:03 +01:00
banman.h
1.1.0
2024-03-15 18:16:03 +01:00
base58.cpp
1.1.0
2024-03-15 18:16:03 +01:00
base58.h
1.1.0
2024-03-15 18:16:03 +01:00
bech32.cpp
encoding,test: backport BIP350 bech32m and align test vectors to Palladium
2026-02-06 15:23:23 +01:00
bech32.h
encoding,test: backport BIP350 bech32m and align test vectors to Palladium
2026-02-06 15:23:23 +01:00
blockencodings.cpp
1.1.0
2024-03-15 18:16:03 +01:00
blockencodings.h
1.1.0
2024-03-15 18:16:03 +01:00
blockfilter.cpp
1.1.0
2024-03-15 18:16:03 +01:00
blockfilter.h
1.1.0
2024-03-15 18:16:03 +01:00
bloom.cpp
1.1.0
2024-03-15 18:16:03 +01:00
bloom.h
1.1.0
2024-03-15 18:16:03 +01:00
chain.cpp
1.1.0
2024-03-15 18:16:03 +01:00
chain.h
1.1.0
2024-03-15 18:16:03 +01:00
chainparams.cpp
consensus: add taproot deployment (BIP9 mainnet, always-active regtest)
2026-02-06 15:44:58 +01:00
chainparams.h
1.1.0
2024-03-15 18:16:03 +01:00
chainparamsbase.cpp
testnet update: rename testnet3 to testnet
2025-10-30 23:25:15 +01:00
chainparamsbase.h
1.1.0
2024-03-15 18:16:03 +01:00
chainparamsseeds.h
fix(testnet): add testnet seed nodes for peer discovery
2025-11-18 08:47:44 +01:00
checkqueue.h
1.1.0
2024-03-15 18:16:03 +01:00
clientversion.cpp
Release v1.5.0: Hard Fork Logic (Chat & DAA) activated at block 340,000
2025-11-22 18:59:39 +01:00
clientversion.h
1.1.0
2024-03-15 18:16:03 +01:00
coins.cpp
1.1.0
2024-03-15 18:16:03 +01:00
coins.h
Fix compilation with modern GCC (Ubuntu 24.04+)
2026-01-26 17:30:11 +01:00
compat.h
1.1.0
2024-03-15 18:16:03 +01:00
compressor.cpp
1.1.0
2024-03-15 18:16:03 +01:00
compressor.h
1.1.0
2024-03-15 18:16:03 +01:00
core_io.h
1.1.0
2024-03-15 18:16:03 +01:00
core_memusage.h
1.1.0
2024-03-15 18:16:03 +01:00
core_read.cpp
1.1.0
2024-03-15 18:16:03 +01:00
core_write.cpp
1.1.0
2024-03-15 18:16:03 +01:00
cuckoocache.h
1.1.0
2024-03-15 18:16:03 +01:00
dbwrapper.cpp
1.1.0
2024-03-15 18:16:03 +01:00
dbwrapper.h
Fix compilation with modern GCC (Ubuntu 24.04+)
2026-01-26 17:30:11 +01:00
dummywallet.cpp
1.1.0
2024-03-15 18:16:03 +01:00
flatfile.cpp
1.1.0
2024-03-15 18:16:03 +01:00
flatfile.h
1.1.0
2024-03-15 18:16:03 +01:00
fs.cpp
1.1.0
2024-03-15 18:16:03 +01:00
fs.h
1.1.0
2024-03-15 18:16:03 +01:00
hash.cpp
1.1.0
2024-03-15 18:16:03 +01:00
hash.h
1.1.0
2024-03-15 18:16:03 +01:00
httprpc.cpp
1.1.0
2024-03-15 18:16:03 +01:00
httprpc.h
1.1.0
2024-03-15 18:16:03 +01:00
httpserver.cpp
1.1.0
2024-03-15 18:16:03 +01:00
httpserver.h
1.1.0
2024-03-15 18:16:03 +01:00
indirectmap.h
1.1.0
2024-03-15 18:16:03 +01:00
init.cpp
Improve default palladium.conf generation
2026-01-13 22:31:02 +01:00
init.h
1.1.0
2024-03-15 18:16:03 +01:00
key_io.cpp
encoding,test: backport BIP350 bech32m and align test vectors to Palladium
2026-02-06 15:23:23 +01:00
key_io.h
1.1.0
2024-03-15 18:16:03 +01:00
key.cpp
fix: implement BIP341 key tweaking for P2TR transaction signing
2026-02-08 00:55:02 +01:00
key.h
fix: implement BIP341 key tweaking for P2TR transaction signing
2026-02-08 00:55:02 +01:00
limitedmap.h
1.1.0
2024-03-15 18:16:03 +01:00
logging.cpp
1.1.0
2024-03-15 18:16:03 +01:00
logging.h
1.1.0
2024-03-15 18:16:03 +01:00
Makefile.am
1.1.0
2024-03-15 18:16:03 +01:00
Makefile.bench.include
1.1.0
2024-03-15 18:16:03 +01:00
Makefile.crc32c.include
1.1.0
2024-03-15 18:16:03 +01:00
Makefile.leveldb.include
1.1.0
2024-03-15 18:16:03 +01:00
Makefile.qt_locale.include
1.1.0
2024-03-15 18:16:03 +01:00
Makefile.qt.include
1.1.0
2024-03-15 18:16:03 +01:00
Makefile.qttest.include
1.1.0
2024-03-15 18:16:03 +01:00
Makefile.test_fuzz.include
1.1.0
2024-03-15 18:16:03 +01:00
Makefile.test_util.include
1.1.0
2024-03-15 18:16:03 +01:00
Makefile.test.include
1.1.0
2024-03-15 18:16:03 +01:00
memusage.h
1.1.0
2024-03-15 18:16:03 +01:00
merkleblock.cpp
1.1.0
2024-03-15 18:16:03 +01:00
merkleblock.h
1.1.0
2024-03-15 18:16:03 +01:00
miner.cpp
fix
2025-10-22 20:59:33 +02:00
miner.h
1.1.0
2024-03-15 18:16:03 +01:00
net_permissions.cpp
1.1.0
2024-03-15 18:16:03 +01:00
net_permissions.h
1.1.0
2024-03-15 18:16:03 +01:00
net_processing.cpp
Fix compilation with modern GCC (Ubuntu 24.04+)
2026-01-26 17:30:11 +01:00
net_processing.h
1.1.0
2024-03-15 18:16:03 +01:00
net_types.h
1.1.0
2024-03-15 18:16:03 +01:00
net.cpp
seeds
2024-04-07 13:33:32 -04:00
net.h
seeds
2024-04-07 13:33:32 -04:00
netaddress.cpp
1.1.0
2024-03-15 18:16:03 +01:00
netaddress.h
1.1.0
2024-03-15 18:16:03 +01:00
netbase.cpp
1.1.0
2024-03-15 18:16:03 +01:00
netbase.h
1.1.0
2024-03-15 18:16:03 +01:00
netmessagemaker.h
1.1.0
2024-03-15 18:16:03 +01:00
noui.cpp
1.1.0
2024-03-15 18:16:03 +01:00
noui.h
1.1.0
2024-03-15 18:16:03 +01:00
optional.h
1.1.0
2024-03-15 18:16:03 +01:00
outputtype.cpp
fix: implement BIP341 key tweaking for P2TR transaction signing
2026-02-08 00:55:02 +01:00
outputtype.h
wallet,rpc,descriptor: add bech32m and taproot address/spend support
2026-02-07 12:13:51 +01:00
palladium-cli-res.rc
1.1.0
2024-03-15 18:16:03 +01:00
palladium-cli.cpp
1.1.0
2024-03-15 18:16:03 +01:00
palladium-tx-res.rc
1.1.0
2024-03-15 18:16:03 +01:00
palladium-tx.cpp
1.1.0
2024-03-15 18:16:03 +01:00
palladium-wallet-res.rc
1.1.0
2024-03-15 18:16:03 +01:00
palladium-wallet.cpp
1.1.0
2024-03-15 18:16:03 +01:00
palladiumd-res.rc
1.1.0
2024-03-15 18:16:03 +01:00
palladiumd.cpp
1.1.0
2024-03-15 18:16:03 +01:00
pow.cpp
add params to chainparams.cpp
2025-11-24 00:03:44 +01:00
pow.h
fix
2025-10-22 20:59:33 +02:00
prevector.h
1.1.0
2024-03-15 18:16:03 +01:00
protocol.cpp
1.1.0
2024-03-15 18:16:03 +01:00
protocol.h
1.1.0
2024-03-15 18:16:03 +01:00
psbt.cpp
1.1.0
2024-03-15 18:16:03 +01:00
psbt.h
1.1.0
2024-03-15 18:16:03 +01:00
pubkey.cpp
fix: implement BIP341 key tweaking for P2TR transaction signing
2026-02-08 00:55:02 +01:00
pubkey.h
fix: implement BIP341 key tweaking for P2TR transaction signing
2026-02-08 00:55:02 +01:00
random.cpp
1.1.0
2024-03-15 18:16:03 +01:00
random.h
1.1.0
2024-03-15 18:16:03 +01:00
randomenv.cpp
1.1.0
2024-03-15 18:16:03 +01:00
randomenv.h
1.1.0
2024-03-15 18:16:03 +01:00
rest.cpp
1.1.0
2024-03-15 18:16:03 +01:00
reverse_iterator.h
1.1.0
2024-03-15 18:16:03 +01:00
scheduler.cpp
1.1.0
2024-03-15 18:16:03 +01:00
scheduler.h
1.1.0
2024-03-15 18:16:03 +01:00
serialize.h
1.1.0
2024-03-15 18:16:03 +01:00
shutdown.cpp
1.1.0
2024-03-15 18:16:03 +01:00
shutdown.h
1.1.0
2024-03-15 18:16:03 +01:00
span.h
1.1.0
2024-03-15 18:16:03 +01:00
streams.h
Fix compilation with modern GCC (Ubuntu 24.04+)
2026-01-26 17:30:11 +01:00
sync.cpp
1.1.0
2024-03-15 18:16:03 +01:00
sync.h
1.1.0
2024-03-15 18:16:03 +01:00
threadinterrupt.cpp
1.1.0
2024-03-15 18:16:03 +01:00
threadinterrupt.h
1.1.0
2024-03-15 18:16:03 +01:00
threadsafety.h
1.1.0
2024-03-15 18:16:03 +01:00
timedata.cpp
1.1.0
2024-03-15 18:16:03 +01:00
timedata.h
1.1.0
2024-03-15 18:16:03 +01:00
tinyformat.h
1.1.0
2024-03-15 18:16:03 +01:00
torcontrol.cpp
1.1.0
2024-03-15 18:16:03 +01:00
torcontrol.h
1.1.0
2024-03-15 18:16:03 +01:00
txdb.cpp
1.1.0
2024-03-15 18:16:03 +01:00
txdb.h
1.1.0
2024-03-15 18:16:03 +01:00
txmempool.cpp
1.1.0
2024-03-15 18:16:03 +01:00
txmempool.h
1.1.0
2024-03-15 18:16:03 +01:00
ui_interface.cpp
1.1.0
2024-03-15 18:16:03 +01:00
ui_interface.h
1.1.0
2024-03-15 18:16:03 +01:00
uint256.cpp
1.1.0
2024-03-15 18:16:03 +01:00
uint256.h
1.1.0
2024-03-15 18:16:03 +01:00
undo.h
1.1.0
2024-03-15 18:16:03 +01:00
validation.cpp
fix: implement BIP341 key tweaking for P2TR transaction signing
2026-02-08 00:55:02 +01:00
validation.h
1.1.0
2024-03-15 18:16:03 +01:00
validationinterface.cpp
1.1.0
2024-03-15 18:16:03 +01:00
validationinterface.h
1.1.0
2024-03-15 18:16:03 +01:00
version.h
1.1.0
2024-03-15 18:16:03 +01:00
versionbits.cpp
1.1.0
2024-03-15 18:16:03 +01:00
versionbits.h
1.1.0
2024-03-15 18:16:03 +01:00
versionbitsinfo.cpp
consensus: add taproot deployment (BIP9 mainnet, always-active regtest)
2026-02-06 15:44:58 +01:00
versionbitsinfo.h
1.1.0
2024-03-15 18:16:03 +01:00
walletinitinterface.h
1.1.0
2024-03-15 18:16:03 +01:00
warnings.cpp
1.1.0
2024-03-15 18:16:03 +01:00
warnings.h
1.1.0
2024-03-15 18:16:03 +01:00