cli/config_cli.h

#ifndef LIGHTNING_CLI_CONFIG_CLI_H
#define LIGHTNING_CLI_CONFIG_CLI_H

#include "config.h"
#include <unistd.h>

#ifndef CLN_TEST
/* Redefinition procedure is a very cool feature, but
   if we try to redefine a procedure that is already
   redefined somewhere (like read in alpine) we can have
   tricky compilation error */
#define cli_read read
#endif

#endif /* LIGHTNING_CLI_CONFIG_CLI_H */
cli: change the redefine logic to read from the stdin Procedure redefinition is a very cool feature but when other libraries redefine the same function can be very tricky to avoid compilation error. This PR proposed a change of logic and use a customizzation function definition to read from the stdin, so we can avoid future error at compile time. However, we could be check also the os or compiler that cause the error and redefine the missing function. Changelog-None: Fixed compilation error due redefinition procedure. Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com> 2022-01-12 21:36:56 +01:00			`#ifndef LIGHTNING_CLI_CONFIG_CLI_H`
			`#define LIGHTNING_CLI_CONFIG_CLI_H`

			`#include "config.h"`
global: remove unnecessary includes from C files. Basically, `devtools/reduce-includes.sh /.c`. Build time from make clean (RUST=0) (includes building external libs): Before: real 0m38.944000-40.416000(40.1131+/-0.4)s user 3m6.790000-17.159000(15.0571+/-2.8)s sys 0m35.304000-37.336000(36.8942+/-0.57)s After: real 0m37.872000-39.974000(39.5466+/-0.59)s user 3m1.211000-14.968000(12.4556+/-3.9)s sys 0m35.008000-36.830000(36.4143+/-0.5)s Build time after touch config.vars (RUST=0): Before: real 0m19.831000-21.862000(21.5528+/-0.58)s user 2m15.361000-30.731000(28.4798+/-4.4)s sys 0m21.056000-22.339000(22.0346+/-0.35)s After: real 0m18.384000-21.307000(20.8605+/-0.92)s user 2m5.585000-26.843000(23.6017+/-6.7)s sys 0m19.650000-22.003000(21.4943+/-0.69)s Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> 2025-10-22 19:44:28 +10:30			`#include <unistd.h>`
cli: change the redefine logic to read from the stdin Procedure redefinition is a very cool feature but when other libraries redefine the same function can be very tricky to avoid compilation error. This PR proposed a change of logic and use a customizzation function definition to read from the stdin, so we can avoid future error at compile time. However, we could be check also the os or compiler that cause the error and redefine the missing function. Changelog-None: Fixed compilation error due redefinition procedure. Signed-off-by: Vincenzo Palazzo <vincenzopalazzodev@gmail.com> 2022-01-12 21:36:56 +01:00
			`#ifndef CLN_TEST`
			`/* Redefinition procedure is a very cool feature, but`
			`if we try to redefine a procedure that is already`
			`redefined somewhere (like read in alpine) we can have`
			`tricky compilation error */`
			`#define cli_read read`
			`#endif`

			`#endif /* LIGHTNING_CLI_CONFIG_CLI_H */`