diff --git a/plugins/bkpr/incomestmt.c b/plugins/bkpr/incomestmt.c index fd3a7e452..faf135529 100644 --- a/plugins/bkpr/incomestmt.c +++ b/plugins/bkpr/incomestmt.c @@ -290,11 +290,7 @@ static struct onchain_fee **find_consolidated_fees(const tal_t *ctx, fee->debit = AMOUNT_MSAT(0); fee->acct_name = tal_steal(fee, sums[i]->acct_name); fee->txid = *sums[i]->txid; - - fee->timestamp = - onchain_fee_last_timestamp(bkpr, sums[i]->acct_name, - sums[i]->txid); - + fee->timestamp = sums[i]->last_timestamp; tal_arr_expand(&fee_sums, fee); } diff --git a/plugins/bkpr/onchain_fee.c b/plugins/bkpr/onchain_fee.c index 4af85e259..0bec506b1 100644 --- a/plugins/bkpr/onchain_fee.c +++ b/plugins/bkpr/onchain_fee.c @@ -366,10 +366,13 @@ static struct fee_sum **fee_sums_by_txid_and_account(const tal_t *ctx, sum->txid = tal_dup(sum, struct bitcoin_txid, &ofs[i]->txid); credit = debit = AMOUNT_MSAT(0); + sum->last_timestamp = 0; } ok = amount_msat_accumulate(&credit, ofs[i]->credit); assert(ok); ok = amount_msat_accumulate(&debit, ofs[i]->debit); + if (ofs[i]->timestamp > sum->last_timestamp) + sum->last_timestamp = ofs[i]->timestamp; } /* Final, if any */ @@ -679,24 +682,6 @@ struct fee_sum **find_account_onchain_fees(const tal_t *ctx, return fee_sums_by_txid_and_account(ctx, ofs); } -/* FIXME: Put this value into fee_sums! */ -u64 onchain_fee_last_timestamp(const struct bkpr *bkpr, - const char *acct_name, - const struct bitcoin_txid *txid) -{ - struct onchain_fee **ofs; - u64 timestamp = 0; - - ofs = account_get_chain_fees(tmpctx, bkpr, acct_name); - for (size_t i = 0; i < tal_count(ofs); i++) { - if (!bitcoin_txid_eq(&ofs[i]->txid, txid)) - continue; - if (ofs[i]->timestamp > timestamp) - timestamp = ofs[i]->timestamp; - } - return timestamp; -} - /* If we're freeing the entire hash table, remove destructors from * individual entries! */ static void ofees_hash_destroy(struct ofees_hash *ofees_hash) diff --git a/plugins/bkpr/onchain_fee.h b/plugins/bkpr/onchain_fee.h index 8b954b092..5e3be5e5d 100644 --- a/plugins/bkpr/onchain_fee.h +++ b/plugins/bkpr/onchain_fee.h @@ -67,11 +67,6 @@ struct fee_sum **find_account_onchain_fees(const tal_t *ctx, struct fee_sum **calculate_onchain_fee_sums(const tal_t *ctx, const struct bkpr *bkpr); -/* Find the last timestamp for the onchain fees for this txid + account */ -u64 onchain_fee_last_timestamp(const struct bkpr *bkpr, - const char *acct_name, - const struct bitcoin_txid *txid); - /* Update our onchain fees now? */ char *maybe_update_onchain_fees(const tal_t *ctx, struct command *cmd, diff --git a/plugins/bkpr/recorder.h b/plugins/bkpr/recorder.h index 3c807a7e1..c13c0f214 100644 --- a/plugins/bkpr/recorder.h +++ b/plugins/bkpr/recorder.h @@ -18,6 +18,7 @@ struct fee_sum { const char *acct_name; struct bitcoin_txid *txid; struct amount_msat fees_paid; + u64 last_timestamp; }; struct txo_pair {