davide/palladum-lightning
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

hsmd: roll the definition of simple_htlc into the csv.

Browse Source 
This is such a simple struct that we can actually define it in csv.
This prevents us from accidentally breaking the ABI in future.

I tested this hadn't accidentally changed the wire format by disabling
version checks and using an old hsmd with the altered daemons and
running the test suite.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell
2025-05-06 05:19:46 +09:30
parent daf1560eb4
commit 29c8693b26
5 changed files with 22 additions and 53 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
hsmd/hsmd_wire.csv
View File

@@ -229,6 +229,13 @@ msgdata,hsmd_sign_commitment_tx,commit_num,u64,
msgtype,hsmd_sign_commitment_tx_reply,105
msgdata,hsmd_sign_commitment_tx_reply,sig,bitcoin_signature,
#include <common/htlc_wire.h> // For enum side and towire_side
subtype,simple_htlc
subtypedata,simple_htlc,side,enum side,
subtypedata,simple_htlc,amount,amount_msat,
subtypedata,simple_htlc,payment_hash,sha256,
subtypedata,simple_htlc,cltv_expiry,u32,
# Validate the counterparty's commitment signatures.
msgtype,hsmd_validate_commitment_tx,35
msgdata,hsmd_validate_commitment_tx,tx,bitcoin_tx,
@@ -290,7 +297,6 @@ msgdata,hsmd_sign_local_htlc_tx,wscript,u8,wscript_len
msgdata,hsmd_sign_local_htlc_tx,option_anchor_outputs,bool,
# Openingd/channeld asks HSM to sign the other sides' commitment tx.
#include <common/htlc_wire.h>
msgtype,hsmd_sign_remote_commitment_tx,19
msgdata,hsmd_sign_remote_commitment_tx,tx,bitcoin_tx,
msgdata,hsmd_sign_remote_commitment_tx,remote_funding_key,pubkey,
Can't render this file because it contains an unexpected character in line 169 and column 43.