From 343d30ae5b4374fb90a03a202843679aa2b8c6cc Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Mon, 22 Sep 2025 11:50:02 +0930 Subject: [PATCH] bookkeeper: fix reloading of rebalances. Parse key correctly. Signed-off-by: Rusty Russell Changelog-Fixed: bookkeeper: failed reload of rebalances on restart. --- plugins/bkpr/rebalances.c | 2 +- tests/test_bookkeeper.py | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/plugins/bkpr/rebalances.c b/plugins/bkpr/rebalances.c index d61c330b0..38bbdcd84 100644 --- a/plugins/bkpr/rebalances.c +++ b/plugins/bkpr/rebalances.c @@ -135,7 +135,7 @@ struct rebalances *init_rebalances(const tal_t *ctx, goto weird; /* key = ["bookkeeper", "rebalances", "-"] */ - if (!split_tok(buf, keytok + 2, '-', &lessertok, &greatertok)) + if (!split_tok(buf, keytok + 3, '-', &lessertok, &greatertok)) goto weird; if (!json_to_u64(buf, &lessertok, &lesser) diff --git a/tests/test_bookkeeper.py b/tests/test_bookkeeper.py index 2ac03467c..c7ba58b21 100644 --- a/tests/test_bookkeeper.py +++ b/tests/test_bookkeeper.py @@ -760,7 +760,6 @@ def test_empty_node(node_factory, bitcoind): l1.rpc.bkpr_inspect('wallet') -@pytest.mark.xfail(strict=True) def test_rebalance_tracking(node_factory, bitcoind): """ We identify rebalances (invoices paid and received by our node),