davide/palladum-lightning
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

lightningd: mangle parameter names in bitcoind_getrawblockbyheight_ so mocks don't get shadow warning.

Browse Source 
When we make mocks (which the next patch will do), these names cause a warning:

```
wallet/test/run-db.c:32:64: error: declaration of ‘bitcoind’ shadows a parameter [-Werror=shadow=compatible-local]
   32 |                                    void (*cb)(struct bitcoind *bitcoind UNNEEDED,
wallet/test/run-db.c:30:53: note: shadowed declaration is here
   30 |                                    struct bitcoind *bitcoind UNNEEDED,
wallet/test/run-db.c:33:51: error: declaration of ‘height’ shadows a parameter [-Werror=shadow=compatible-local]
   33 |                                               u32 height UNNEEDED,
wallet/test/run-db.c:31:40: note: shadowed declaration is here
   31 |                                    u32 height UNNEEDED,
```

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell
2025-03-31 12:36:35 +10:30
parent 52dfe9b52d
commit 5ff84aece9
1 changed files with 2 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
lightningd/bitcoind.h
View File

@@ -127,8 +127,8 @@ void bitcoind_getchaininfo_(const tal_t *ctx,
void bitcoind_getrawblockbyheight_(const tal_t *ctx,
struct bitcoind *bitcoind,
u32 height,
void (*cb)(struct bitcoind *bitcoind,
u32 height,
void (*cb)(struct bitcoind *bitcoind_,
u32 height_,
struct bitcoin_blkid *blkid,
struct bitcoin_block *blk,
void *arg),