davide/palladum-lightning
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

doc: be explicit (with tests!) on when we don't know amount_msat for listsendpays.

Browse Source 
Sangbida and I traced back through ancient history: when the pay plugin was introduced
in 0.9.0 (2019!) it already used the amount_msat parameter (then called `msatoshi`),
so this case effectively "never happens".

But we added a test for it just in case.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell
2025-06-30 11:15:55 +09:30
committed by Sangbida Chaudhuri
parent bd743d741e
commit 89f411ca79
4 changed files with 20 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
contrib/msggen/msggen/schema.json
View File

@@ -21942,7 +21942,7 @@
"amount_msat": {
"type": "msat",
"description": [
"The amount of millisatoshi we intended to send to the destination."
"The amount of millisatoshi we intended to send to the destination. This can only be missing in the case of someone manually calling sendonion without the `amount_msat` parameter (which no plugin currently does)."
]
},
"amount_sent_msat": {
@@ -24449,7 +24449,7 @@
"amount_msat": {
"type": "msat",
"description": [
"The amount delivered to destination (if known)."
"The amount delivered to destination (if known). This is not known in the case where sendonion(7) was used to manually initiate a payment without the `amount_msat` parameter."
]
},
"destination": {