From bf3b2cc5e09a1f954c8f1156878a07fb82348f58 Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Mon, 18 Aug 2025 19:15:43 +0930 Subject: [PATCH] pytest: check current bookkeeper events in saved test_migration snapshot. This way we can be sure they're the same after migration. Signed-off-by: Rusty Russell --- tests/test_bookkeeper.py | 96 ++++++++++++++++++++++++++++++++++++++++ 1 file changed, 96 insertions(+) diff --git a/tests/test_bookkeeper.py b/tests/test_bookkeeper.py index 18243df19..b98047109 100644 --- a/tests/test_bookkeeper.py +++ b/tests/test_bookkeeper.py @@ -1058,3 +1058,99 @@ def test_migration(node_factory, bitcoind): # When generating, we want to stop so you can grab databases. assert generate is False + + l1_events = l1.rpc.bkpr_listaccountevents()['events'] + for e in l1_events: + del e['timestamp'] + + l2_events = l2.rpc.bkpr_listaccountevents()['events'] + for e in l2_events: + del e['timestamp'] + + # These were snapshotted before the bkpr migration, so should + # be the same! + assert l1_events == [{'account': 'wallet', + 'blockheight': 102, + 'credit_msat': 2000000000, + 'currency': 'bcrt', + 'debit_msat': 0, + 'outpoint': '63c59b312976320528552c258ae51563498dfd042b95bb0c842696614d59bb89:1', + 'tag': 'deposit', + 'type': 'chain'}, + {'account': 'wallet', + 'blockheight': 103, + 'credit_msat': 0, + 'currency': 'bcrt', + 'debit_msat': 2000000000, + 'outpoint': '63c59b312976320528552c258ae51563498dfd042b95bb0c842696614d59bb89:1', + 'tag': 'withdrawal', + 'txid': '675ab2a8c43afcf98b82a1120d1a4d36768c898792fe1282c5be4ac055377fbe', + 'type': 'chain'}, + {'account': 'wallet', + 'blockheight': 103, + 'credit_msat': 995073000, + 'currency': 'bcrt', + 'debit_msat': 0, + 'description': "Rusty's change", + 'outpoint': '675ab2a8c43afcf98b82a1120d1a4d36768c898792fe1282c5be4ac055377fbe:1', + 'tag': 'deposit', + 'type': 'chain'}, + {'account': 'be7f3755c04abec58212fe9287898c76364d1a0d12a1828bf9fc3ac4a8b25a67', + 'blockheight': 103, + 'credit_msat': 1000000000, + 'currency': 'bcrt', + 'debit_msat': 0, + 'description': "Rusty's channel", + 'outpoint': '675ab2a8c43afcf98b82a1120d1a4d36768c898792fe1282c5be4ac055377fbe:0', + 'tag': 'channel_open', + 'type': 'chain'}, + {'account': 'be7f3755c04abec58212fe9287898c76364d1a0d12a1828bf9fc3ac4a8b25a67', + 'credit_msat': 0, + 'currency': 'bcrt', + 'debit_msat': 12345678, + 'description': "Rusty's payment", + 'is_rebalance': False, + 'part_id': 0, + 'payment_id': '7ccef7e9fabbf4a841af44b1fc7319bc70ce98697b77ce6dacffa84bebcd4350', + 'tag': 'invoice', + 'type': 'channel'}, + {'account': 'wallet', + 'credit_msat': 1004927000, + 'currency': 'bcrt', + 'debit_msat': 0, + 'tag': 'onchain_fee', + 'txid': '675ab2a8c43afcf98b82a1120d1a4d36768c898792fe1282c5be4ac055377fbe', + 'type': 'onchain_fee'}, + {'account': 'wallet', + 'credit_msat': 0, + 'currency': 'bcrt', + 'debit_msat': 1004927000, + 'tag': 'onchain_fee', + 'txid': '675ab2a8c43afcf98b82a1120d1a4d36768c898792fe1282c5be4ac055377fbe', + 'type': 'onchain_fee'}, + {'account': 'be7f3755c04abec58212fe9287898c76364d1a0d12a1828bf9fc3ac4a8b25a67', + 'credit_msat': 4927000, + 'currency': 'bcrt', + 'debit_msat': 0, + 'tag': 'onchain_fee', + 'txid': '675ab2a8c43afcf98b82a1120d1a4d36768c898792fe1282c5be4ac055377fbe', + 'type': 'onchain_fee'}] + + assert l2_events == [{'account': 'be7f3755c04abec58212fe9287898c76364d1a0d12a1828bf9fc3ac4a8b25a67', + 'blockheight': 103, + 'credit_msat': 0, + 'currency': 'bcrt', + 'debit_msat': 0, + 'outpoint': '675ab2a8c43afcf98b82a1120d1a4d36768c898792fe1282c5be4ac055377fbe:0', + 'tag': 'channel_open', + 'type': 'chain'}, + {'account': 'be7f3755c04abec58212fe9287898c76364d1a0d12a1828bf9fc3ac4a8b25a67', + 'credit_msat': 12345678, + 'currency': 'bcrt', + 'debit_msat': 0, + 'description': "Rusty's payment", + 'is_rebalance': False, + 'part_id': 0, + 'payment_id': '7ccef7e9fabbf4a841af44b1fc7319bc70ce98697b77ce6dacffa84bebcd4350', + 'tag': 'invoice', + 'type': 'channel'}]