davide/palladum-lightning
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

plugin: remove features when plugin is disabled

Browse Source 
We need to remove the feature bits set via a plugins get_manifest
response when the init response disables the plugin.

Changelog-Fixed Remove feature bits set by a plugin when the plugin
disables itself during init.

Signed-off-by: Peter Neuroth <pet.v.ne@gmail.com>
This commit is contained in:
Peter Neuroth
2025-10-01 11:26:56 +02:00
committed by Rusty Russell
parent 8895ca2982
commit c7531b0f8f
2 changed files with 12 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
lightningd/plugin.c
View File

@@ -1819,6 +1819,11 @@ static const char *plugin_parse_getmanifest_response(const char *buffer,
return tal_fmt(plugin,
"Custom featurebits already present");
}
/* Store fset to allow to remove feature bits when init returns disabled */
plugin->fset = tal_dup_or_null(plugin, struct feature_set, fset);
} else {
plugin->fset = NULL;
}
custommsgtok = json_get_member(buffer, resulttok, "custommessages");
@@ -2148,6 +2153,10 @@ static void plugin_config_cb(const char *buffer,
JSON_SCAN_TAL(tmpctx, json_strdup, &disable)) == NULL) {
/* Don't get upset if this was a built-in! */
plugin->important = false;
if (plugin->fset)
/* We don't have those features anymore! */
feature_set_sub(plugin->plugins->ld->our_features,
plugin->fset);
plugin_kill(plugin, LOG_DBG,
"disabled itself at init: %s",
disable);