common: make chain_coin_mvt's outpoint member a non-pointer.

It's always set, and in fact we assume it is (journal entries are not
internal to lightningd, so we won't see them in
lightningd/notification.c: that comment is misleading).

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell
2025-08-14 10:57:55 +09:30
parent c0221b1b74
commit d066a5f301
3 changed files with 9 additions and 18 deletions

View File

@@ -501,15 +501,10 @@ static void chain_movement_notification_serialize(struct json_stream *stream,
json_add_string(stream, "txid",
fmt_bitcoin_txid(tmpctx,
chain_mvt->tx_txid));
/* some chain ledger entries aren't associated with a utxo
* e.g. journal updates (due to penalty/state loss) and
* chain_fee entries */
if (chain_mvt->outpoint) {
json_add_string(stream, "utxo_txid",
fmt_bitcoin_txid(tmpctx,
&chain_mvt->outpoint->txid));
json_add_u32(stream, "vout", chain_mvt->outpoint->n);
}
json_add_string(stream, "utxo_txid",
fmt_bitcoin_txid(tmpctx,
&chain_mvt->outpoint.txid));
json_add_u32(stream, "vout", chain_mvt->outpoint.n);
/* on-chain htlcs include a payment hash */
if (chain_mvt->payment_hash)