From e04153f1df7971466bccc26c3719a80d6c14d3e1 Mon Sep 17 00:00:00 2001 From: ShahanaFarooqui Date: Mon, 24 Nov 2025 17:31:28 -0800 Subject: [PATCH] tools: Sort Fedora tar by name And do not replace Fedora shasums from verification because Fedora binaries are deterministic now. --- tools/build-release.sh | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/tools/build-release.sh b/tools/build-release.sh index 35649bfc0..d59a4a7ef 100755 --- a/tools/build-release.sh +++ b/tools/build-release.sh @@ -19,7 +19,7 @@ if [ "$1" = "--inside-docker" ]; then uv run make -j"$MAKEPAR" VERSION="$VER" uv run make -j"$MAKEPAR" install DESTDIR=/"$VER-$PLTFM-$PLTFMVER-$ARCH" RUST_PROFILE=release cd /"$VER-$PLTFM-$PLTFMVER-$ARCH" - tar cvfz /release/clightning-"$VER-$PLTFM-$PLTFMVER-$ARCH".tar.gz --mtime='@1672531200' -- * + LC_ALL=C tar --sort=name -c -v -z -f /release/clightning-"$VER-$PLTFM-$PLTFMVER-$ARCH".tar.gz --mtime='@1672531200' -- * echo "Inside docker: build finished" exit 0 fi @@ -242,14 +242,10 @@ if [ "$VERIFY_RELEASE" = "true" ]; then fi sumfile="$(pwd)/${sumfile}" cd release/ || exit - # Check that the release captains sum matches. Ignore missing entries as we - # do not have a repro build for Fedora. Strictly this is not necessary here + # Check that the release captains sum matches. Strictly this is not necessary here # as we compare our checksums with the release captains checksums later, but # it gives a direct hint which specific checksums don't match if so. sha256sum --check --ignore-missing "${sumfile}" - # Creating SHA256SUMS, except Fedora (copy that from theirs) - grep 'Fedora-' "$sumfile" > SHA256SUMS - sha256sum clightning-"$VERSION"* | grep -v 'Fedora' >> SHA256SUMS # compare our and release captain's SHA256SUMS contents if cmp -s SHA256SUMS "$sumfile"; then echo "SHA256SUMS are Identical"