From f4ff1e59afd5e9e95252b181cbfe08c7613a6c77 Mon Sep 17 00:00:00 2001 From: Rusty Russell Date: Wed, 7 Jan 2026 10:02:11 +1030 Subject: [PATCH] pytest: disable remaining flaky and skip markers to see what else fails. Signed-off-by: Rusty Russell --- tests/test_closing.py | 2 +- tests/test_coinmoves.py | 1 - tests/test_invoices.py | 1 - tests/test_plugin.py | 1 - tests/test_reckless.py | 1 - 5 files changed, 1 insertion(+), 5 deletions(-) diff --git a/tests/test_closing.py b/tests/test_closing.py index 33abde9c8..47cc28d80 100644 --- a/tests/test_closing.py +++ b/tests/test_closing.py @@ -3437,7 +3437,7 @@ def test_closing_higherfee(node_factory, bitcoind, executor, anchors): wait_for(lambda: l2.rpc.listpeerchannels()['channels'][0]['state'] == 'CLOSINGD_COMPLETE') -@unittest.skipIf(True, "Test is extremely flaky") +@pytest.mark.flaky(reruns=3) def test_htlc_rexmit_while_closing(node_factory, executor): """Retranmitting an HTLC revocation while shutting down should work""" # FIXME: This should be in lnprototest! UNRELIABLE. diff --git a/tests/test_coinmoves.py b/tests/test_coinmoves.py index dc5abb044..291f857ba 100644 --- a/tests/test_coinmoves.py +++ b/tests/test_coinmoves.py @@ -681,7 +681,6 @@ def test_coinmoves_unilateral_htlc_before_included(node_factory, bitcoind): check_balances(l1, l2, fundchannel['channel_id'], 0) -@pytest.mark.flaky(reruns=5) @pytest.mark.openchannel('v1') @pytest.mark.openchannel('v2') @unittest.skipIf(TEST_NETWORK != 'regtest', "Amounts are for regtest.") diff --git a/tests/test_invoices.py b/tests/test_invoices.py index a3db715ad..37e6695be 100644 --- a/tests/test_invoices.py +++ b/tests/test_invoices.py @@ -927,7 +927,6 @@ def test_invoices_wait_db_migration(node_factory, bitcoind): @unittest.skipIf(os.getenv('TEST_DB_PROVIDER', 'sqlite3') != 'sqlite3', "This test is based on a sqlite3 snapshot") @unittest.skipIf(TEST_NETWORK != 'regtest', "The DB migration is network specific due to the chain var.") -@pytest.mark.flaky(reruns=5) def test_invoice_botched_migration(node_factory, chainparams): """Test for grubles' case, where they ran successfully with the wrong var: they have *both* last_invoice_created_index *and *last_invoices_created_index* (this can happen if invoice id 1 was deleted, so they didn't die on invoice creation): Error executing statement: wallet/db.c:1684: UPDATE vars SET name = 'last_invoices_created_index' WHERE name = 'last_invoice_created_index': UNIQUE constraint failed: vars.name diff --git a/tests/test_plugin.py b/tests/test_plugin.py index d45b07b3b..d63d1867a 100644 --- a/tests/test_plugin.py +++ b/tests/test_plugin.py @@ -4311,7 +4311,6 @@ def test_plugin_nostart(node_factory): assert [p['name'] for p in l1.rpc.plugin_list()['plugins'] if 'badinterp' in p['name']] == [] -@unittest.skip("A bit flaky, but when breaks, it is costing us 2h of CI time") def test_plugin_startdir_lol(node_factory): """Though we fail to start many of them, we don't crash!""" l1 = node_factory.get_node(broken_log='.*') diff --git a/tests/test_reckless.py b/tests/test_reckless.py index 275960d57..311ed1ae4 100644 --- a/tests/test_reckless.py +++ b/tests/test_reckless.py @@ -351,7 +351,6 @@ def test_tag_install(node_factory): header = line -@pytest.mark.flaky(reruns=5) @pytest.mark.slow_test def test_reckless_uv_install(node_factory): node = get_reckless_node(node_factory)