davide/palladum-lightning
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

lightningd: deprecate @-prefix hack for offer recurrence_base.

Browse Source 
Christian points out that this makes the type harder, and it's just awkward.

Changelog-EXPERIMENTAL: JSON-RPC: Deprecated `offer` parameter `recurrence_base` with `@` prefix: use `recurrence_start_any_period`.
Changelog-EXPERIMENTAL: JSON-RPC: Added `offer` parameter `recurrence_start_any_period`.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell
2024-02-04 10:22:40 +10:30
parent 1d0a0f6600
commit f56b9e9b73
4 changed files with 51 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

1
doc/developers-guide/deprecations.md
View File

@@ -48,6 +48,7 @@ hidden: false
| estimatefees.min_acceptable | Field | v23.05 | v24.05 | `min_acceptable` feerate (implementation-specific, use modern feerates) |
| estimatefees.max_acceptable | Field | v23.05 | v24.05 | `max_acceptable` feerate (implementation-specific, use modern feerates) |
| commando.missing_id | Parameter | v23.02 | v24.02 | Incoming JSON commands without an `id` field |
| offer.recurrence_base.at_prefix | Parameter | v24.02 | v24.05 | `recurrence_base` with `@` prefix (use `recurrence_start_any_period`) |
Inevitably there are features which need to change: either to be generalized, or removed when they can no longer be supported.