29e0a1ddfe
We can't really do decent bookkeeping any more, but don't crash! ``` bookkeeper: plugins/bkpr/recorder.c:178: find_txo_chain: Assertion `acct->open_event_db_id' failed. bookkeeper: FATAL SIGNAL 6 (version v25.12) 0xaaaab7d51a7f send_backtrace common/daemon.c:38 0xaaaab7d51b2b crashdump common/daemon.c:83 0xffff8c0b07cf ??? ???:0 0xffff8bdf7608 __pthread_kill_implementation ./nptl/pthread_kill.c:44 0xffff8bdacb3b __GI_raise ../sysdeps/posix/raise.c:26 0xffff8bd97dff __GI_abort ./stdlib/abort.c:79 0xffff8bda5cbf __assert_fail_base ./assert/assert.c:96 0xffff8bda5d2f __assert_fail ./assert/assert.c:105 0xaaaab7d41fd7 find_txo_chain plugins/bkpr/recorder.c:178 0xaaaab7d421fb account_onchain_closeheight plugins/bkpr/recorder.c:291 0xaaaab7d37687 do_account_close_checks plugins/bkpr/bookkeeper.c:884 0xaaaab7d38203 parse_and_log_chain_move plugins/bkpr/bookkeeper.c:1261 0xaaaab7d3871f listchainmoves_done plugins/bkpr/bookkeeper.c:171 0xaaaab7d4811f handle_rpc_reply plugins/libplugin.c:1073 0xaaaab7d4827b rpc_conn_read_response plugins/libplugin.c:1377 0xaaaab7d889a7 next_plan ccan/ccan/io/io.c:60 0xaaaab7d88f7b do_plan ccan/ccan/io/io.c:422 0xaaaab7d89053 io_ready ccan/ccan/io/io.c:439 ``` Fixes: https://github.com/ElementsProject/lightning/issues/8854 Changelog-Fixed: Plugins: `bkpr_listbalances` no longer crashes if we lost our db, then do emergencyrecover and close a channel. Reported-by: https://github.com/enaples
The bookkeeper keeps track of coins moving through your Lightning node.
See the doc/PLUGINS.md#coin_movement section on the message that CLN emits for us to process.
// FIXME: add more detailed documenation for how bookkeeper works.
3rd Party Coin Movements
Bookeeper ingests 3rd party plugin notifications about on-chain movements that it should watch.
This allows for us to account for non-internal on-chain wallets in the single place, making bookkeeper your single source of truth for bitcoin for an organization or node-operator.
As a plugin writer, if you want to emit onchain events that the bookkeeper should track, you should emit an event with the following format:
{
"utxo_deposit": {
"account": "nifty's secret stash",
"transfer_from: null,
"outpoint": xxxx:x,
"amount_msat": "10000sat",
"coin_type": "bc",
"timestamp": xxxx,
"blockheight": xxx,
}
}
{
"utxo_spend": {
"account": "nifty's secret stash",
"outpoint": xxxx:x,
"spending_txid": xxxx,
"amount_msat": "10000sat",
"coin_type": "bc",
"timestamp": xxxx,
"blockheight": xxx,
}
}
Withdrawing money (sending to a external account)
Sending money to an external account is a bit unintuitive in the UTXO model that we're using to track coin moves; technically a send to an external account is a "deposit" to 3rd party's UTXO.
To account for these, bookkeeper expects to receive a utxo_deposit event for the creation of an output to a 3rd party. It's assumed that you'll issue these at transaction creation time, and that they won't be final until we receive notice of spend of the inputs in the tx that created them.
To notify that money is being sent to a 3rd party output, here's the event we'd expect.
The two keys here are the following:
- The
accountisexternal. This is a special account inbookkeeperand used for tracking external deposits (aka sends) - The
transfer_fromfield is set to the name of the account that is sending out the money.
{
"utxo_deposit": {
"account": "external",
"transfer_from": "nifty's secret stash",
"outpoint": xxxx:x,
"amount_msat": "10000sat",
"coin_type": "bc",
"timestamp": xxxx,
"blockheight": xxx,
}
}
List of todos
List of things to check/work on, as a todo list.
- Transfers btw a 3rd party wallet and the internal CLN wallet? These should be registered as internal transfers and not show up in
listincome