Rusty Russell a84ad10820 common: fix bad cupdates count in gossmap.c ...

I noticed this in the logs:

```
lightningd-1 2026-01-28T00:27:37.504Z DEBUG   gossipd: gossip_store: Read 59428/118856/0/0 cannounce/cupdate/nannounce/delete from store in 45521871 bytes, now 45521849 bytes (populated=true)
lightningd-1 2026-01-28T00:27:37.504Z DEBUG   gossipd: Got 118856 bad cupdates, ignoring them (expected on mainnet)
```

That's weird, and turns out it counting good updates, not bad ones!

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

2026-02-19 17:04:35 +10:30

..

test

gossmap: add callback for gossipd to see dying messages.

2026-02-16 17:23:33 +10:30

addr.c

…

addr.h

…

amount.c

common: add amount_msat_deduct / amount_msat_deduct_sub.

2025-11-17 10:56:18 +10:30

amount.h

common: add amount_msat_deduct / amount_msat_deduct_sub.

2025-11-17 10:56:18 +10:30

autodata.c

…

autodata.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

base32.c

…

base32.h

…

base64.c

fuzz-tests: Enhance b64_encode() validation with roundtrip decoding

2025-07-08 12:54:56 +09:30

base64.h

fuzz-tests: Enhance b64_encode() validation with roundtrip decoding

2025-07-08 12:54:56 +09:30

bech32_util.c

…

bech32_util.h

…

bech32.c

…

bech32.h

…

bigsize.c

…

bigsize.h

…

billboard.c

…

billboard.h

…

bip32.c

…

bip32.h

…

blindedpath.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

blindedpath.h

global: replace randombytes_buf() with randbytes() wrapper.

2025-11-13 21:21:29 +10:30

blindedpay.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

blindedpay.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

blinding.c

…

blinding.h

…

blockheight_states.c

…

blockheight_states.h

…

bolt11_json.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

bolt11_json.h

…

bolt11.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

bolt11.h

lightningd: don't allow invoices with 640 byte descriptions.

2025-11-13 10:57:49 +10:30

bolt12_id.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

bolt12_id.h

…

bolt12_merkle.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

bolt12_merkle.h

…

bolt12.c

common: enforce currency-requires-amount check.

2026-02-03 13:05:23 +10:30

bolt12.h

BOLT12: Update recurrence to latest spec draft.

2025-10-01 15:31:30 +09:30

channel_config.c

…

channel_config.h

…

channel_id.c

…

channel_id.h

…

channel_type.c

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

channel_type.h

lightningd: always tell openingd/dualopend what channel type we want.

2025-08-13 14:20:28 +09:30

clock_time.c

common/clock_time: wrapper for time_now() so we can override it.

2025-11-13 21:21:29 +10:30

clock_time.h

common/clock_time: wrapper for time_now() so we can override it.

2025-11-13 21:21:29 +10:30

close_tx.c

common: don't abort() if wally_psbt_output_taproot_keypath_add() fails.

2025-11-19 07:23:39 +10:30

close_tx.h

…

closing_fee.h

…

codex32.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

codex32.h

…

coin_mvt.c

global: use clock_time in place of time_now().

2025-11-13 21:21:29 +10:30

coin_mvt.h

global: use clock_time in place of time_now().

2025-11-13 21:21:29 +10:30

configdir.c

Remove litecoin support.

2025-10-26 20:31:45 +10:30

configdir.h

…

configvar.c

fix: build on Alpine Linux

2026-01-28 17:23:00 +10:30

configvar.h

…

crypto_state.h

…

cryptomsg.c

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

cryptomsg.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

daemon_conn.c

common: fix dangling memory allocation in daemon_conn_new_()

2025-09-04 13:29:29 +09:30

daemon_conn.h

…

daemon.c

common/clock_time: wrapper for time_now() so we can override it.

2025-11-13 21:21:29 +10:30

daemon.h

…

decode_array.c

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

decode_array.h

…

deprecation.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

deprecation.h

…

derive_basepoints.c

…

derive_basepoints.h

…

descriptor_checksum.c

…

descriptor_checksum.h

…

dev_disconnect.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

dev_disconnect.h

…

dijkstra.c

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

dijkstra.h

…

ecdh_hsmd.c

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

ecdh_hsmd.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

ecdh.h

…

errcode.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

features.c

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

features.h

…

fee_states.c

…

fee_states.h

…

fp16.c

…

fp16.h

…

gossip_constants.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

gossip_store_wire.csv

common: move gossip_store_wire.csv into common/ from gossipd/

2026-02-16 17:23:33 +10:30

gossip_store.c

common: expose gossip_store "header and type" single-read struct.

2026-02-16 17:23:33 +10:30

gossip_store.h

common: expose gossip_store "header and type" single-read struct.

2026-02-16 17:23:33 +10:30

gossmap.c

common: fix bad cupdates count in gossmap.c

2026-02-19 17:04:35 +10:30

gossmap.h

gossmap: keep stats on live/deleted records.

2026-02-16 17:23:33 +10:30

gossmods_listpeerchannels.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

gossmods_listpeerchannels.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

hash_u5.c

…

hash_u5.h

…

hmac.c

…

hmac.h

…

hsm_capable.c

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

hsm_capable.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

hsm_secret.c

common: expose validate_mnemonic so the option can use it.

2026-01-13 22:36:01 +10:30

hsm_secret.h

common: expose validate_mnemonic so the option can use it.

2026-01-13 22:36:01 +10:30

hsm_version.h

hsmd: remove unused "sign_local_htlc_tx" function which onchaind used to use.

2026-01-20 19:32:42 +10:30

htlc_state.c

devtools: Add custom include-order-fixer to pre-commit.

2026-01-24 09:40:49 +10:00

htlc_state.h

…

htlc_trim.c

…

htlc_trim.h

…

htlc_tx.c

…

htlc_tx.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

htlc_wire.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

htlc_wire.h

htlc_wire: fix crash when adding an HTLC

2025-08-27 14:14:31 +09:30

htlc.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

initial_channel.c

common: remove take() leak if new_initial_channel() fails.

2025-10-23 06:44:04 +10:30

initial_channel.h

…

initial_commit_tx.c

common: add amount_msat_deduct / amount_msat_deduct_sub.

2025-11-17 10:56:18 +10:30

initial_commit_tx.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

interactivetx.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

interactivetx.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

iso4217.c

…

iso4217.h

…

json_blinded_path.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

json_blinded_path.h

…

json_channel_type.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

json_channel_type.h

…

json_command.c

…

json_command.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

json_filter.c

…

json_filter.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

json_param.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

json_param.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

json_parse_simple.c

common: optimize json parsing.

2025-11-20 16:30:50 +10:30

json_parse_simple.h

common/json_parse_simple: drop redundant and wrong json_str_to_u64()

2025-09-22 10:16:51 +09:30

json_parse.c

common: add json_dup_contents() to duplicate toks and buffer.

2025-10-24 11:28:57 +10:30

json_parse.h

common: add json_dup_contents() to duplicate toks and buffer.

2025-10-24 11:28:57 +10:30

json_stream.c

lightningd: deprecate "message": null in channel_state_changed notifications.

2025-11-18 14:28:22 +10:30

json_stream.h

lightningd: handle large numbers of command outputs gracefully.

2025-11-20 16:30:50 +10:30

jsonrpc_errors.h

lightningd: don't allow enableoffer on single-use offer.

2026-02-02 10:31:02 +10:30

jsonrpc_io.c

common: increase jsonrpc_io buffer size temporarily to aggrevate perf issues.

2025-11-20 16:30:50 +10:30

jsonrpc_io.h

libplugin: use jsonrpc_io logic for sync requests too.

2025-10-24 11:28:57 +10:30

key_derive.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

key_derive.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

keyset.c

…

keyset.h

…

lease_rates.c

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

lease_rates.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

Makefile

common: move gossip_store_wire.csv into common/ from gossipd/

2026-02-16 17:23:33 +10:30

memleak.c

memleak: make notleak() work even before memleak is initalized.

2025-10-24 11:30:17 +10:30

memleak.h

common: add new_htable() macro to allocate, initialize and setup memleak coverage for any typed hash table.

2025-10-24 11:30:17 +10:30

msg_queue.c

common: export helper membuf_tal_realloc.

2025-10-24 11:28:57 +10:30

msg_queue.h

…

node_id.c

common/node_id: runtime assertion override, not separate compile time for fuzzing.

2025-10-23 06:44:04 +10:30

node_id.h

common/node_id: runtime assertion override, not separate compile time for fuzzing.

2025-10-23 06:44:04 +10:30

onion_decode.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

onion_decode.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

onion_encode.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

onion_encode.h

common: remove unused type field.

2026-02-03 15:35:36 +10:30

onion_message_parse.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

onion_message_parse.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

onion_message.c

global: replace randombytes_buf() with randbytes() wrapper.

2025-11-13 21:21:29 +10:30

onion_message.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

onionreply.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

onionreply.h

…

overflows.h

…

peer_billboard.c

…

peer_billboard.h

…

peer_failed.c

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

peer_failed.h

Makefile: run fuzzing corpora as normal unit tests in non-fuzzing mode.

2025-10-23 06:44:04 +10:30

peer_io.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

peer_io.h

…

peer_status_wire.csv

…

penalty_base.c

…

penalty_base.h

…

per_peer_state.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

per_peer_state.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

permute_tx.c

…

permute_tx.h

…

ping.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

ping.h

…

plugin.c

…

plugin.h

…

psbt_internal.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

psbt_internal.h

…

psbt_keypath.c

common: don't abort() if wally_psbt_output_taproot_keypath_add() fails.

2025-11-19 07:23:39 +10:30

psbt_keypath.h

common: don't abort() if wally_psbt_output_taproot_keypath_add() fails.

2025-11-19 07:23:39 +10:30

psbt_open.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

psbt_open.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

pseudorand.c

pseudorand: make the results in deterministic mode per-caller.

2025-11-13 21:21:29 +10:30

pseudorand.h

pseudorand: make the results in deterministic mode per-caller.

2025-11-13 21:21:29 +10:30

randbytes.c

common: add randbytes() wrapper to override cryptographic entropy: $CLN_DEV_ENTROPY_SEED

2025-11-13 21:21:29 +10:30

randbytes.h

common: add randbytes() wrapper to override cryptographic entropy: $CLN_DEV_ENTROPY_SEED

2025-11-13 21:21:29 +10:30

random_select.c

…

random_select.h

…

read_peer_msg.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

read_peer_msg.h

…

route.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

route.h

…

scb_wire.csv

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

sciddir_or_pubkey.c

…

sciddir_or_pubkey.h

…

setup.c

common: remove tal_check() call on libwally allocations.

2025-11-03 14:49:33 +10:30

setup.h

…

shutdown_scriptpubkey.c

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

shutdown_scriptpubkey.h

…

sphinx.c

common: remove legacy onion translation.

2026-02-03 15:35:36 +10:30

sphinx.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

splice_script.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

splice_script.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

status_levels.c

…

status_levels.h

pyln-testing: catch special CI string so we can have non-BROKEN CI warnings.

2025-09-30 11:37:31 +09:30

status_wire.c

…

status_wire.csv

…

status_wire.h

…

status.c

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

status.h

…

subdaemon.c

…

subdaemon.h

…

timeout.c

…

timeout.h

…

trace.c

common: avoid allocations for small numbers of traces.

2025-11-20 16:30:50 +10:30

trace.h

…

tx_roles.c

…

tx_roles.h

…

utils.c

decode: don't treat every failure as a rune.

2026-02-03 13:05:23 +10:30

utils.h

decode: don't treat every failure as a rune.

2026-02-03 13:05:23 +10:30

utxo.c

utxo: remove UTXO_P2TR_BIP86 enum and consolidate to UTXO_P2TR

2025-10-26 12:37:58 +10:30

utxo.h

…

version.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

version.h

…

wallet.c

…

wallet.h

…

wire_error.c

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

wire_error.h

…

wireaddr.c

common: fix bad formatting for DNS-type wireaddr.

2025-11-14 11:50:16 +10:30

wireaddr.h

…