davide/palladum-lightning
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity
Files
23e80d9e81d972816d2e0e3e42fffde966ebb0d3
palladum-lightning/lightningd
History
Dusty Daemon 23e80d9e81 PSBT: Change bitcoin_tx routine to use TAKES 
`bitcoin_tx_with_psbt` would somewhat opaquely steal the passed `psbt` value.

This caused a bug where code made a `bitcoin_tx` using a psbt without realizing the value was stolen. Because the resulting `bitcoin_tx` was placed in tmpctx it was not immediately clear that using `psbt` afterwards was an error until the tmpctx was cleared — creating a valgrind backtrace far from the actual issue.

Switching to the routine to using TAKES and adding documentation in the header, makes it explicitly clear which operation the user is doing — helping prevent future regressions of this kind.

Changelog-None
2025-05-13 14:52:15 +09:30
..
test
lightningd: respond with channel_reestablish if contacted about long-closed channels.
2025-04-29 13:31:23 +09:30
.gitignore
…
anchorspend.c
anchorspend: fix weight estimation.
2025-05-06 12:27:53 +09:30
anchorspend.h
…
bitcoind.c
lightningd: allow bitcoind_getrawblockbyheight callback to free call struct.
2025-04-01 13:29:28 -05:00
bitcoind.h
lightningd: mangle parameter names in bitcoind_getrawblockbyheight_ so mocks don't get shadow warning.
2025-04-02 11:22:54 +10:30
chaintopology.c
wallet: remove unused total arg from wallet_extract_owned_outputs.
2025-04-02 11:22:54 +10:30
chaintopology.h
ccan/htable: update to explicit DUPS/NODUPS types.
2025-01-21 09:18:25 +10:30
channel_control.c
Splice: Update PSBT version handling
2025-05-13 14:52:15 +09:30
channel_control.h
channeld: remove never-used "reestablish_only" option.
2025-04-29 13:31:23 +09:30
channel_gossip.c
BOLTs: Add typo fixes and clarifications from "More clarifications around channel_announcement handling (#1220)"
2025-03-18 14:30:58 +10:30
channel_gossip.h
lightingd: corrections from Alex Myers's review.
2024-01-31 14:47:33 +10:30
channel_state.h
lightningd: rename state_change_entry to channel_state_change, and use pointers.
2024-09-21 06:20:18 +09:30
channel.c
PSBT: Change bitcoin_tx routine to use TAKES
2025-05-13 14:52:15 +09:30
channel.h
splice: Add locked field to inflight db
2025-05-13 14:52:15 +09:30
closed_channel.c
lightningd: keep closed channels in memory.
2025-04-29 13:31:23 +09:30
closed_channel.h
lightningd: save shachain for closed channels.
2025-04-29 13:31:23 +09:30
closing_control.c
lightningd: return addrtype when asking wallet_can_spend.
2025-05-06 12:27:53 +09:30
closing_control.h
lightningd: make close_txs parameter to resolve_close_command const.
2024-11-25 20:23:21 +10:30
coin_mvts.c
lightningd: store our id as a struct pubkey as well as struct node_id.
2024-07-23 09:54:47 +09:30
coin_mvts.h
…
configs.c
lightningd: remove old listconfigs output.
2025-03-12 09:26:08 +10:30
connect_control.c
pytest: fix flake in test_reconnect_signed
2025-05-11 11:25:40 +09:30
connect_control.h
connectd: reconnect for non-transient connections.
2024-11-25 15:39:13 +10:30
datastore.c
lightningd: fix overzealous memleak detection in json_add_datastore.
2024-12-20 15:36:07 +10:30
dual_open_control.c
lightningd: fail too-large txs *before* opening channel.
2025-05-06 12:27:53 +09:30
dual_open_control.h
common: BOLT update: option_anchors_zero_fee_htlc_tx is now simply "option_anchors".
2024-06-19 15:54:24 +09:30
feerate.c
lightnind: remove deprecated feerate names.
2024-03-25 15:02:35 +10:30
feerate.h
…
forwards.c
lightningd: listforwards returns 0 for missing received_time. ([#7157])
2024-10-26 09:51:20 +02:00
forwards.h
lightningd: clean up notification infrastructure.
2024-01-26 10:30:22 +10:30
gossip_control.c
connectd: remove DNS seed lookups.
2025-05-08 12:54:09 +09:30
gossip_control.h
lightningd: ignore gossip messages from channeld, switch to our own.
2024-01-31 14:47:33 +10:30
gossip_generation.c
lightningd: store our id as a struct pubkey as well as struct node_id.
2024-07-23 09:54:47 +09:30
gossip_generation.h
bitcoin/short_channel_id: pass by copy everywhere.
2024-03-20 13:51:48 +10:30
hsm_control.c
pytest: create warning if we grind signature shorter than 71 bytes, don't fail.
2025-05-06 12:27:53 +09:30
hsm_control.h
…
htlc_end.c
global: rename blinding to path_key everywhere.
2024-10-16 07:14:32 +10:30
htlc_end.h
ccan/htable: update to explicit DUPS/NODUPS types.
2025-01-21 09:18:25 +10:30
htlc_set.c
lightningd: generalize htlc_set.
2024-10-27 13:57:50 +11:00
htlc_set.h
ccan/htable: update to explicit DUPS/NODUPS types.
2025-01-21 09:18:25 +10:30
invoice.c
plugins: all plugins must now support non-numeric JSON RPC id fields.
2025-03-12 09:26:08 +10:30
invoice.h
…
io_loop_with_timers.c
…
io_loop_with_timers.h
…
jsonrpc.c
plugins: all plugins must now support non-numeric JSON RPC id fields.
2025-03-12 09:26:08 +10:30
jsonrpc.h
plugins: all plugins must now support non-numeric JSON RPC id fields.
2025-03-12 09:26:08 +10:30
lightningd.c
pytest: create warning if we grind signature shorter than 71 bytes, don't fail.
2025-05-06 12:27:53 +09:30
lightningd.h
pytest: create warning if we grind signature shorter than 71 bytes, don't fail.
2025-05-06 12:27:53 +09:30
log_status.c
…
log_status.h
…
log.c
lightningd: use static buffer for common log path.
2025-05-08 14:01:38 +09:30
log.h
common: don't send trace messages by default, don't ratelimit at all.
2024-12-16 09:48:51 +10:30
Makefile
common/bolt12_id: new common routine for creating path secrets.
2024-08-01 12:31:48 +09:30
memdump.c
lightningd: keep closed channels in memory.
2025-04-29 13:31:23 +09:30
memdump.h
…
notification.c
lightningd: optimize notifications.
2025-05-08 14:01:38 +09:30
notification.h
new notifications: plugin_stopped and plugin_started
2025-02-12 12:54:10 +10:30
offer.c
BOLT12: remove -offers from bolt12 quotes, update them.
2025-02-11 20:19:01 -06:00
onchain_control.c
wallet: generalize wallet_utxo_boost.
2025-05-06 12:27:53 +09:30
onchain_control.h
…
onion_message.c
lightningd: fix use of deprecation macro.
2025-03-12 09:26:08 +10:30
onion_message.h
…
opening_common.c
BOLT: update to include 2016 for max_htlc_cltv.
2024-05-09 16:14:23 -05:00
opening_common.h
…
opening_control.c
lightningd: return addrtype when asking wallet_can_spend.
2025-05-06 12:27:53 +09:30
opening_control.h
common: BOLT update: option_anchors_zero_fee_htlc_tx is now simply "option_anchors".
2024-06-19 15:54:24 +09:30
options.c
pytest: create warning if we grind signature shorter than 71 bytes, don't fail.
2025-05-06 12:27:53 +09:30
options.h
lightningd: remove old listconfigs output.
2025-03-12 09:26:08 +10:30
pay.c
lightningd: injectpaymentonion can use scids of unannounced channels.
2024-12-17 15:59:30 +10:30
pay.h
lightningd: refactor payment failed.
2024-10-27 13:57:50 +11:00
peer_control.c
PSBT: Change bitcoin_tx routine to use TAKES
2025-05-13 14:52:15 +09:30
peer_control.h
pytest: fix flake in test_reconnect_signed
2025-05-11 11:25:40 +09:30
peer_fd.c
…
peer_fd.h
lightningd: create helper routine to make socketpair for a channel.
2025-02-26 10:22:03 -06:00
peer_htlcs.c
lightningd: support index/start/end pagination for listhtlcs.
2025-04-29 09:38:20 +09:30
peer_htlcs.h
lightningd: wait interface for htlcs indexes.
2025-04-29 09:38:20 +09:30
ping.c
rpc: Removing description from json_command struct
2024-07-31 14:42:58 +09:30
plugin_control.c
lightningd: allow builtin plugins to be stopped.
2024-11-18 11:03:26 +10:30
plugin_control.h
…
plugin_hook.c
plugins: all plugins must now support non-numeric JSON RPC id fields.
2025-03-12 09:26:08 +10:30
plugin_hook.h
…
plugin.c
lightningd: keep a hash table for plugin notifications.
2025-05-08 14:01:38 +09:30
plugin.h
lightningd: keep a hash table for plugin notifications.
2025-05-08 14:01:38 +09:30
routehint.c
common/amount: rename amount_sat_zero/amount_msat_zerp -> amount_sat_is_zero/amount_msat_is_zero.
2024-09-19 12:16:53 +09:30
routehint.h
…
runes.c
lightningd: implement unblacklist.
2025-02-05 16:43:09 -06:00
runes.h
…
signmessage.c
plugins: all plugins must now support non-numeric JSON RPC id fields.
2025-03-12 09:26:08 +10:30
subd.c
common: don't send trace messages by default, don't ratelimit at all.
2024-12-16 09:48:51 +10:30
subd.h
lightningd: allow subd_req() to take replycb_data arg.
2024-11-13 14:44:03 +10:30
wait.c
lightningd: wait interface for htlcs indexes.
2025-04-29 09:38:20 +09:30
wait.h
lightningd: wait interface for htlcs indexes.
2025-04-29 09:38:20 +09:30
watch.c
ccan/htable: update to explicit DUPS/NODUPS types.
2025-01-21 09:18:25 +10:30
watch.h
ccan/htable: update to explicit DUPS/NODUPS types.
2025-01-21 09:18:25 +10:30