ZmnSCPxj jxPCSnmZ
5356267f15
*: Use new closefrom module from ccan.
...
This also inadvertently fixes a latent bug: before this patch, in the
`subd` function in `lightningd/subd.c`, we would close `execfail[1]`
*before* doing an `exec`.
We use an EOF on `execfail[1]` as a signal that `exec` succeeded (the
fd is marked CLOEXEC), and otherwise use it to pump `errno` to the
parent.
The intent is that this fd should be kept open until `exec`, at which
point CLOEXEC triggers and close that fd and sends the EOF, *or* if
`exec` fails we can send the `errno` to the parent process vua that
pipe-end.
However, in the previous version, we end up closing that fd *before*
reaching `exec`, either in the loop which `dup2`s passed-in fds (by
overwriting `execfail[1]` with a `dup2`) or in the "close everything"
loop, which does not guard against `execfail[1]`, only
`dev_disconnect_fd`.
2021-10-22 13:17:37 +02:00
..
2021-10-15 12:09:36 +02:00
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2021-09-21 18:04:43 +02:00
2021-09-21 18:04:43 +02:00
2021-09-17 09:43:22 +09:30
2020-10-21 19:34:39 +02:00
2020-12-09 16:40:13 +10:30
2021-09-17 09:43:22 +09:30
2021-06-11 13:54:20 +09:30
2021-06-11 13:54:20 +09:30
2021-02-04 12:02:36 +10:30
2020-09-23 16:30:36 +09:30
2021-01-10 13:44:04 +01:00
2021-01-10 13:44:04 +01:00
2021-09-22 09:10:34 +09:30
2021-09-22 09:10:34 +09:30
2021-07-20 13:28:38 -04:00
2021-07-20 13:28:38 -04:00
2021-09-17 09:43:22 +09:30
2021-01-09 14:34:35 +10:30
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2021-10-08 13:47:30 +02:00
2021-10-08 13:47:30 +02:00
2021-10-08 13:47:30 +02:00
2021-10-08 13:47:30 +02:00
2021-09-17 09:43:22 +09:30
2021-10-15 12:09:36 +02:00
2021-10-15 12:09:36 +02:00
2021-10-08 16:07:21 +02:00
2021-10-08 16:07:21 +02:00
2021-10-15 12:09:36 +02:00
2021-10-15 12:09:36 +02:00
2021-10-15 12:09:36 +02:00
2021-10-15 12:09:36 +02:00
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2021-09-20 14:44:27 +02:00
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2021-10-10 13:22:29 +02:00
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2020-11-10 10:34:13 -06:00
2021-10-22 13:17:37 +02:00
2021-06-25 13:23:28 +09:30
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2021-10-08 16:07:21 +02:00
2021-10-08 16:07:21 +02:00
2021-06-04 16:13:08 +09:30
2021-06-04 16:13:08 +09:30
2021-02-04 12:02:36 +10:30
2021-02-04 12:02:36 +10:30
2021-07-20 13:28:38 -04:00
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2020-10-21 08:58:34 +10:30
2021-10-08 13:47:30 +02:00
2021-10-08 13:47:30 +02:00
2020-12-11 15:51:24 +01:00
2020-12-11 15:51:24 +01:00
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2021-10-15 12:09:36 +02:00
2021-10-15 12:09:36 +02:00
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2021-10-15 12:09:36 +02:00
2021-10-15 12:09:36 +02:00
2021-10-15 12:09:36 +02:00
2021-10-15 12:09:36 +02:00
2021-09-17 09:43:22 +09:30
2020-12-15 12:05:02 +01:00
2020-12-15 12:05:02 +01:00
2021-09-17 09:43:22 +09:30
2021-10-22 11:56:30 +02:00
2021-10-08 13:47:30 +02:00
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2021-07-20 13:28:38 -04:00
2021-10-06 16:09:20 +02:00
2021-09-17 09:43:22 +09:30
2021-08-25 10:06:31 +02:00
2021-09-17 09:43:22 +09:30
2021-09-09 12:04:48 +09:30
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2021-07-20 13:28:38 -04:00
2021-09-21 18:04:43 +02:00
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2021-02-04 12:02:36 +10:30
2021-09-17 09:43:22 +09:30
2021-10-08 13:47:30 +02:00
2021-10-08 13:47:30 +02:00
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2021-07-20 13:28:38 -04:00
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2021-06-30 14:12:24 +09:30
2021-09-17 09:43:22 +09:30
2021-02-04 12:02:52 +10:30
2021-02-04 12:02:52 +10:30
2021-02-04 12:02:36 +10:30
2021-09-17 09:43:22 +09:30
2021-02-04 12:02:36 +10:30
2021-09-17 09:43:22 +09:30
2021-10-10 15:32:57 +02:00
2021-10-10 15:32:57 +02:00
2021-09-17 09:43:22 +09:30
2020-10-21 08:58:34 +10:30
2021-09-17 09:43:22 +09:30
2021-03-25 20:05:11 +10:30
2021-10-15 12:09:36 +02:00
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2021-10-10 15:32:57 +02:00
2021-10-10 15:32:57 +02:00
2021-09-17 09:43:22 +09:30
2021-05-22 17:53:04 +09:30
2021-09-17 09:43:22 +09:30
2021-05-26 20:01:03 +09:30
2021-05-26 20:01:03 +09:30
2021-09-22 06:44:26 +09:30
2021-09-22 06:44:26 +09:30
2021-09-17 09:43:22 +09:30
2020-10-23 13:53:16 +10:30
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2021-10-21 20:05:54 +02:00
2021-10-21 20:05:54 +02:00
2020-10-20 12:50:31 +10:30
2021-09-21 18:04:43 +02:00
2021-10-15 12:09:36 +02:00
2021-09-17 09:43:22 +09:30
2021-10-15 12:09:36 +02:00
2021-10-15 12:09:36 +02:00
2021-10-15 12:09:36 +02:00
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2021-09-17 09:43:22 +09:30
2021-10-22 11:56:30 +02:00
2021-10-22 11:56:30 +02:00