Prior to it being compulsory, these daemons would need a default value. Now it's always required, it's clearer if it's always told. There's no "default_channel_type" now everyone has to specify channel_type either, so rename it to "desired_channel_type" and put it in lightningd specifically. Note that the channel_type can have options added: either option_scid_alias or option_zeroconf. This results in a slight behavior change: we will get type zeroconf even if we didn't ask for it, if they gave it to us. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Changed: JSON-RPC: fundchannel / fundchannel_start returned `channel_type` will include option_zeroconf if it was implied by a 0 minimum_depth, even if we didn't explicitly ask for a zero conf channel.
182 lines
5.0 KiB
C
182 lines
5.0 KiB
C
#include "config.h"
|
|
#include <ccan/array_size/array_size.h>
|
|
#include <common/channel_type.h>
|
|
|
|
static struct channel_type *new_channel_type(const tal_t *ctx)
|
|
{
|
|
struct channel_type *type = tal(ctx, struct channel_type);
|
|
|
|
type->features = tal_arr(type, u8, 0);
|
|
return type;
|
|
}
|
|
|
|
/* These can still exist in the database */
|
|
struct channel_type *channel_type_none_obsolete(const tal_t *ctx)
|
|
{
|
|
return new_channel_type(ctx);
|
|
}
|
|
|
|
|
|
/* BOLT #2:
|
|
* Channel types are an explicit enumeration: for convenience of future
|
|
* definitions they reuse even feature bits, but they are not an
|
|
* arbitrary combination (they represent the persistent features which
|
|
* affect the channel operation).
|
|
*
|
|
* The currently defined basic types are:
|
|
* - `option_static_remotekey` (bit 12)
|
|
* - `option_anchors` and `option_static_remotekey` (bits 22 and 12)
|
|
*
|
|
* Each basic type has the following variations allowed:
|
|
*/
|
|
struct channel_type *channel_type_static_remotekey(const tal_t *ctx)
|
|
{
|
|
struct channel_type *type = new_channel_type(ctx);
|
|
|
|
set_feature_bit(&type->features,
|
|
COMPULSORY_FEATURE(OPT_STATIC_REMOTEKEY));
|
|
return type;
|
|
}
|
|
|
|
struct channel_type *channel_type_anchor_outputs_obsolete(const tal_t *ctx)
|
|
{
|
|
struct channel_type *type = new_channel_type(ctx);
|
|
|
|
set_feature_bit(&type->features,
|
|
COMPULSORY_FEATURE(OPT_ANCHOR_OUTPUTS_DEPRECATED));
|
|
set_feature_bit(&type->features,
|
|
COMPULSORY_FEATURE(OPT_STATIC_REMOTEKEY));
|
|
return type;
|
|
}
|
|
|
|
void channel_type_set_zeroconf(struct channel_type *type)
|
|
{
|
|
set_feature_bit(&type->features,
|
|
COMPULSORY_FEATURE(OPT_ZEROCONF));
|
|
}
|
|
|
|
void channel_type_set_scid_alias(struct channel_type *type)
|
|
{
|
|
set_feature_bit(&type->features,
|
|
COMPULSORY_FEATURE(OPT_SCID_ALIAS));
|
|
}
|
|
|
|
struct channel_type *channel_type_anchors_zero_fee_htlc(const tal_t *ctx)
|
|
{
|
|
struct channel_type *type = new_channel_type(ctx);
|
|
|
|
set_feature_bit(&type->features,
|
|
COMPULSORY_FEATURE(OPT_ANCHORS_ZERO_FEE_HTLC_TX));
|
|
set_feature_bit(&type->features,
|
|
COMPULSORY_FEATURE(OPT_STATIC_REMOTEKEY));
|
|
return type;
|
|
}
|
|
|
|
bool channel_type_has(const struct channel_type *type, int feature)
|
|
{
|
|
return feature_offered(type->features, feature);
|
|
}
|
|
|
|
bool channel_type_has_anchors(const struct channel_type *type)
|
|
{
|
|
return feature_offered(type->features, OPT_ANCHOR_OUTPUTS_DEPRECATED)
|
|
|| feature_offered(type->features, OPT_ANCHORS_ZERO_FEE_HTLC_TX);
|
|
}
|
|
|
|
bool channel_type_eq(const struct channel_type *a,
|
|
const struct channel_type *b)
|
|
{
|
|
return featurebits_eq(a->features, b->features);
|
|
}
|
|
|
|
struct channel_type *channel_type_dup(const tal_t *ctx,
|
|
const struct channel_type *t)
|
|
{
|
|
struct channel_type *ret = tal(ctx, struct channel_type);
|
|
ret->features = tal_dup_talarr(ret, u8, t->features);
|
|
return ret;
|
|
}
|
|
|
|
struct channel_type *channel_type_from(const tal_t *ctx,
|
|
const u8 *features TAKES)
|
|
{
|
|
struct channel_type *ret = tal(ctx, struct channel_type);
|
|
ret->features = tal_dup_talarr(ret, u8, features);
|
|
return ret;
|
|
}
|
|
|
|
struct channel_type *channel_type_accept(const tal_t *ctx,
|
|
const u8 *t,
|
|
const struct feature_set *our_features)
|
|
{
|
|
struct channel_type *ctype, proposed;
|
|
/* Need to copy since we're going to blank variant bits for equality. */
|
|
proposed.features = tal_dup_talarr(tmpctx, u8, t);
|
|
|
|
static const size_t feats[] = {
|
|
OPT_ANCHORS_ZERO_FEE_HTLC_TX,
|
|
OPT_STATIC_REMOTEKEY,
|
|
OPT_SCID_ALIAS,
|
|
OPT_ZEROCONF,
|
|
};
|
|
|
|
/* BOLT #2:
|
|
* Each basic type has the following variations allowed:
|
|
* - `option_scid_alias` (bit 46)
|
|
* - `option_zeroconf` (bit 50)
|
|
*/
|
|
static const size_t variants[] = {
|
|
OPT_SCID_ALIAS,
|
|
OPT_ZEROCONF,
|
|
};
|
|
|
|
for (size_t i = 0; i < ARRAY_SIZE(feats); i++) {
|
|
size_t f = feats[i];
|
|
|
|
if (feature_offered(t, f)) {
|
|
/* If we don't offer a feature, we don't allow it. */
|
|
if (!feature_offered(our_features->bits[INIT_FEATURE], f))
|
|
return NULL;
|
|
} else {
|
|
/* We assume that if we *require* a feature, we require
|
|
* channels have that. */
|
|
if (feature_is_set(our_features->bits[INIT_FEATURE],
|
|
COMPULSORY_FEATURE(f)))
|
|
return NULL;
|
|
}
|
|
}
|
|
|
|
/* Blank variants so we can just check for equality. */
|
|
for (size_t i = 0; i< ARRAY_SIZE(variants); i++)
|
|
featurebits_unset(&proposed.features, variants[i]);
|
|
|
|
/* Otherwise, just needs to be a known channel type. */
|
|
if (channel_type_eq(&proposed,
|
|
channel_type_static_remotekey(tmpctx)) ||
|
|
channel_type_eq(&proposed,
|
|
channel_type_anchors_zero_fee_htlc(tmpctx))) {
|
|
/* At this point we know it matches, and maybe has
|
|
* a couple of extra options. So let's just reply
|
|
* with their proposal. */
|
|
ctype = tal(ctx, struct channel_type);
|
|
ctype->features = tal_dup_talarr(ctx, u8, t);
|
|
return ctype;
|
|
}
|
|
|
|
return NULL;
|
|
}
|
|
|
|
/* Return an array of feature strings indicating channel type. */
|
|
const char **channel_type_name(const tal_t *ctx, const struct channel_type *t)
|
|
{
|
|
const char **names = tal_arr(ctx, const char *, 0);
|
|
|
|
for (size_t i = 0; i < tal_bytelen(t->features) * CHAR_BIT; i++) {
|
|
if (!feature_is_set(t->features, i))
|
|
continue;
|
|
tal_arr_expand(&names,
|
|
feature_name(names, i) + strlen("option_"));
|
|
}
|
|
return names;
|
|
}
|