davide/palladum-lightning
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity
Files
7e5cf41b4e5cd11064f3a8bcb63ec2edb2ea1dae
palladum-lightning/common
History
Lagrang3 7e5cf41b4e htlc_wire: fix crash when adding an HTLC 
In line channeld/channeld_wiregen.c:832 `*added+i` is not a tal object hence
the instruction in common/htlc_wire.c:200 `tal_arr(ctx, struct tlv_field, 0);` crashes CLN.
This is fixed by stating that added_htlc is a a varsize_type.

Logs:

2025-08-16T02:25:28.640Z **BROKEN** lightningd: FATAL SIGNAL 6 (version v25.05-200-g79b959b)V
...
2025-08-16T02:25:28.640Z **BROKEN** lightningd: backtrace: ccan/ccan/tal/tal.c:95 (call_error) 0x54f6bc
2025-08-16T02:25:28.640Z **BROKEN** lightningd: backtrace: ccan/ccan/tal/tal.c:169 (check_bounds) 0x54f75a
2025-08-16T02:25:28.640Z **BROKEN** lightningd: backtrace: ccan/ccan/tal/tal.c:178 (to_tal_hdr) 0x54f782
2025-08-16T02:25:28.640Z **BROKEN** lightningd: backtrace: ccan/ccan/tal/tal.c:193 (to_tal_hdr_or_null) 0x54f7c7
2025-08-16T02:25:28.640Z **BROKEN** lightningd: backtrace: ccan/ccan/tal/tal.c:471 (tal_alloc_) 0x54ffe4
2025-08-16T02:25:28.640Z **BROKEN** lightningd: backtrace: ccan/ccan/tal/tal.c:517 (tal_alloc_arr_) 0x5500c4
2025-08-16T02:25:28.640Z **BROKEN** lightningd: backtrace: common/htlc_wire.c:200 (fromwire_len_and_tlvstream) 0x48d63d
2025-08-16T02:25:28.640Z **BROKEN** lightningd: backtrace: common/htlc_wire.c:234 (fromwire_added_htlc) 0x48dd23
2025-08-16T02:25:28.640Z **BROKEN** lightningd: backtrace: channeld/channeld_wiregen.c:832 (fromwire_channeld_got_commitsig) 0x4c61fa
2025-08-16T02:25:28.640Z **BROKEN** lightningd: backtrace: lightningd/peer_htlcs.c:2377 (peer_got_commitsig) 0x4549cb
2025-08-16T02:25:28.640Z **BROKEN** lightningd: backtrace: lightningd/channel_control.c:1552 (channel_msg) 0x4140fe
2025-08-16T02:25:28.640Z **BROKEN** lightningd: backtrace: lightningd/subd.c:560 (sd_msg_read) 0x461513
2025-08-16T02:25:28.640Z **BROKEN** lightningd: backtrace: ccan/ccan/io/io.c:60 (next_plan) 0x544885
2025-08-16T02:25:28.640Z **BROKEN** lightningd: backtrace: ccan/ccan/io/io.c:422 (do_plan) 0x544cea
2025-08-16T02:25:28.640Z **BROKEN** lightningd: backtrace: ccan/ccan/io/io.c:439 (io_ready) 0x544d9d
2025-08-16T02:25:28.640Z **BROKEN** lightningd: backtrace: ccan/ccan/io/poll.c:455 (io_loop) 0x54665d
2025-08-16T02:25:28.640Z **BROKEN** lightningd: backtrace: lightningd/io_loop_with_timers.c:22 (io_loop_with_timers) 0x42d220
2025-08-16T02:25:28.640Z **BROKEN** lightningd: backtrace: lightningd/lightningd.c:1487 (main) 0x43280f

gdb inspection:
830             *added = num_added ? tal_arr(ctx, struct added_htlc, num_added) : NULL;
831             for (size_t i = 0; i < num_added; i++)
832                     fromwire_added_htlc(&cursor, &plen, *added + i);
(gdb) p i
$3 = 1

Changelog-None: crash introduced this release.
Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
[ Added test, removed Changelog --RR ]
2025-08-27 14:14:31 +09:30
..
test
wallet: generate fixup chainmoves and channelmoves when first starting.
2025-08-19 13:37:50 +09:30
addr.c
splice: Add plugin for magic “splice all” command
2024-11-12 06:42:52 +10:30
addr.h
splice: Add plugin for magic “splice all” command
2024-11-12 06:42:52 +10:30
amount.c
common/amount: add ceil division operation on msat
2025-07-19 10:09:17 +09:30
amount.h
common/amount: add ceil division operation on msat
2025-07-19 10:09:17 +09:30
autodata.c
…
autodata.h
…
base32.c
…
base32.h
…
base64.c
fuzz-tests: Enhance b64_encode() validation with roundtrip decoding
2025-07-08 12:54:56 +09:30
base64.h
fuzz-tests: Enhance b64_encode() validation with roundtrip decoding
2025-07-08 12:54:56 +09:30
bech32_util.c
common: Fix off-by-one in from_bech32_charset
2024-05-18 10:02:43 +02:00
bech32_util.h
…
bech32.c
common: rename bech32_encode parameter
2023-05-27 15:06:31 +09:30
bech32.h
common: rename bech32_encode parameter
2023-05-27 15:06:31 +09:30
bigsize.c
…
bigsize.h
…
billboard.c
…
billboard.h
…
bip32.c
…
bip32.h
…
blindedpath.c
BOLTs: more catchup ("BOLT 4: More clarifying changes.")
2024-10-16 07:14:32 +10:30
blindedpath.h
BOLTs: update which renames blinding terminology.
2024-10-16 07:14:32 +10:30
blindedpay.c
BOLTs: update which renames blinding terminology.
2024-10-16 07:14:32 +10:30
blindedpay.h
common: update to latest route-blinding spec.
2023-01-30 13:24:29 +10:30
blinding.c
BOLTs: update which renames blinding terminology.
2024-10-16 07:14:32 +10:30
blinding.h
BOLTs: update which renames blinding terminology.
2024-10-16 07:14:32 +10:30
blockheight_states.c
common: remove type_to_string files altogther.
2024-03-20 13:51:48 +10:30
blockheight_states.h
global: expose all fmt_X functions for direct use, make uniform.
2024-03-20 13:51:48 +10:30
bolt11_json.c
bitcoin/short_channel_id: pass by copy everywhere.
2024-03-20 13:51:48 +10:30
bolt11_json.h
…
bolt11.c
common: set errno=0 before calling strto{l,ul,ull}
2025-08-15 10:15:16 +09:30
bolt11.h
common/bolt11: remove #if DEVELOPER.
2023-09-21 20:08:24 +09:30
bolt12_id.c
common/bolt12_id: generate alias tweak.
2024-08-01 12:31:48 +09:30
bolt12_id.h
common/bolt12_id: generate alias tweak.
2024-08-01 12:31:48 +09:30
bolt12_merkle.c
BOLT12: remove -offers from bolt12 quotes, update them.
2025-02-11 20:19:01 -06:00
bolt12_merkle.h
lightningd: use tweak on node_id of different key, for createinvoicerequest.
2024-08-01 12:31:48 +09:30
bolt12.c
xpay: support paying a (simple) bolt12 offer directly.
2025-08-18 14:57:46 +09:30
bolt12.h
xpay: support paying a (simple) bolt12 offer directly.
2025-08-18 14:57:46 +09:30
channel_config.c
…
channel_config.h
BOLTs: catch up with minor clarifications.
2024-05-09 16:14:23 -05:00
channel_id.c
common/utils: macros to help get copy/compare across different types right.
2024-07-23 09:54:47 +09:30
channel_id.h
splice: Add plugin for magic “splice all” command
2024-11-12 06:42:52 +10:30
channel_type.c
lightningd: always tell openingd/dualopend what channel type we want.
2025-08-13 14:20:28 +09:30
channel_type.h
lightningd: always tell openingd/dualopend what channel type we want.
2025-08-13 14:20:28 +09:30
close_tx.c
BOLTs: import spec additions for option_simple_close.
2025-03-18 14:30:58 +10:30
close_tx.h
…
closing_fee.h
…
codex32.c
codex32: use "cl" instead of "ms" as our HRP.
2023-08-02 16:12:32 +09:30
codex32.h
codex32: use "cl" instead of "ms" as our HRP.
2023-08-02 16:12:32 +09:30
coin_mvt.c
lightningd: fix name of chainmoves journal entry.
2025-08-21 13:21:17 +09:30
coin_mvt.h
wallet: generate fixup chainmoves and channelmoves when first starting.
2025-08-19 13:37:50 +09:30
configdir.c
common: return location of a ".setconfig" file when we load config.
2025-02-24 19:38:37 +10:30
configdir.h
common: return location of a ".setconfig" file when we load config.
2025-02-24 19:38:37 +10:30
configvar.c
lightningd: configvar style fixes
2024-08-10 15:20:59 +09:30
configvar.h
setconfig: make source for setconfig "setconfig transient".
2025-02-24 19:38:37 +10:30
crypto_state.h
…
cryptomsg.c
doc: update to BOLT 7f53a3e46ed59f19463447d5fa63b3e484c708a5 "BOLT 8: make it clear that there are *two* chaining keys."
2023-09-20 13:56:46 +09:30
cryptomsg.h
common: make hdr parameter const
2023-06-23 13:12:42 +09:30
daemon_conn.c
…
daemon_conn.h
…
daemon.c
common: don't enable steal loop checking unless we're doing memleak checking.
2025-05-08 14:01:38 +09:30
daemon.h
pyln-testing: use DEBUG_LIGHTNINGD to start gdb on lightningd during test.
2024-03-20 11:18:36 +10:30
decode_array.c
gossipd: drop zlib support.
2024-07-10 12:21:19 +09:30
decode_array.h
…
deprecation.c
common: if something isn't deprecated yet, it's always ok.
2025-02-14 22:17:21 +10:30
deprecation.h
Makefile: add CLN_NEXT_VERSION, functions encoding deprecation schedule.
2024-01-26 10:30:22 +10:30
derive_basepoints.c
common/utils: macros to help get copy/compare across different types right.
2024-07-23 09:54:47 +09:30
derive_basepoints.h
common: remove #if DEVELOPER.
2023-09-21 20:08:24 +09:30
descriptor_checksum.c
…
descriptor_checksum.h
…
dev_disconnect.c
dev_disconnect: add '<' to close after an incoming msg.
2025-01-27 11:07:04 +10:30
dev_disconnect.h
dev_disconnect: add '<' to close after an incoming msg.
2025-01-27 11:07:04 +10:30
dijkstra.c
doc: minor typos and standarizations to inline documentaion.
2025-04-29 09:40:15 -07:00
dijkstra.h
common: fix dijkstra scoring.
2024-03-07 14:09:14 +01:00
ecdh_hsmd.c
…
ecdh_hsmd.h
…
ecdh.h
…
errcode.h
…
features.c
BOLTs: Update to version with peer storage merged.
2025-03-18 14:30:58 +10:30
features.h
BOLTs: Update to version with peer storage merged.
2025-03-18 14:30:58 +10:30
fee_states.c
channeld: Adjust the feerate security margin profile
2024-05-13 14:06:45 -05:00
fee_states.h
channeld: Adjust the feerate security margin profile
2024-05-13 14:06:45 -05:00
fp16.c
…
fp16.h
…
gossip_constants.h
BOLTs: Add typo fixes and clarifications from "More clarifications around channel_announcement handling (#1220)"
2025-03-18 14:30:58 +10:30
gossip_store.c
common/gossip_store: move subdaemon-only routines to connectd.
2023-01-30 15:15:41 -06:00
gossip_store.h
common: add gossmap_chan_is_dying() helper to check flags.
2024-02-12 11:43:33 +01:00
gossmap.c
splice: Add start_batch and an internal wire type
2025-08-14 16:40:04 +09:30
gossmap.h
gossipd: check that gossmap code sees updates from gossip_store writes.
2025-02-11 15:11:47 -06:00
gossmods_listpeerchannels.c
fetch max total htlc value from listpeerchannel
2025-02-21 17:03:36 -06:00
gossmods_listpeerchannels.h
fetch max total htlc value from listpeerchannel
2025-02-21 17:03:36 -06:00
hash_u5.c
…
hash_u5.h
…
hmac.c
common/utils: macros to help get copy/compare across different types right.
2024-07-23 09:54:47 +09:30
hmac.h
…
hsm_capable.c
channeld: add hsm_capabilities and add hsm_is_capable to common
2024-01-29 12:02:37 +10:30
hsm_capable.h
channeld: add hsm_capabilities and add hsm_is_capable to common
2024-01-29 12:02:37 +10:30
hsm_encryption.c
common/hsm_encryption: use const char * for errors.
2024-11-13 08:49:55 +10:30
hsm_encryption.h
common/hsm_encryption: use const char * for errors.
2024-11-13 08:49:55 +10:30
hsm_version.h
HSMD: add new wire BIP137 sign message API
2025-05-13 13:19:03 +09:30
htlc_state.c
…
htlc_state.h
…
htlc_trim.c
global: thread zero fee option everywhere.
2023-06-29 11:28:47 -04:00
htlc_trim.h
global: thread zero fee option everywhere.
2023-06-29 11:28:47 -04:00
htlc_tx.c
global: thread zero fee option everywhere.
2023-06-29 11:28:47 -04:00
htlc_tx.h
Doc: update to BOLT which assumes option_var_onion_optin.
2024-06-19 15:54:24 +09:30
htlc_wire.c
htlc_wire: fix crash when adding an HTLC
2025-08-27 14:14:31 +09:30
htlc_wire.h
htlc_wire: fix crash when adding an HTLC
2025-08-27 14:14:31 +09:30
htlc.h
…
initial_channel.c
channeld: BOLT update, no longer allow creation of old (experimental-only!) non-zero-fee anchor channels.
2024-06-19 15:54:24 +09:30
initial_channel.h
global: expose all fmt_X functions for direct use, make uniform.
2024-03-20 13:51:48 +10:30
initial_commit_tx.c
common: remove type_to_string files altogther.
2024-03-20 13:51:48 +10:30
initial_commit_tx.h
global: thread zero fee option everywhere.
2023-06-29 11:28:47 -04:00
interactivetx.c
splice: Add start_batch and an internal wire type
2025-08-14 16:40:04 +09:30
interactivetx.h
interactivetx: Add support for shared prevtx
2024-11-21 14:15:36 +10:30
iso4217.c
…
iso4217.h
BOLT12: remove -offers from bolt12 quotes, update them.
2025-02-11 20:19:01 -06:00
json_blinded_path.c
BOLT update: catch up ("BOLT 4: rename onionmsg_hop to blinded_path_hop")
2024-10-16 07:14:32 +10:30
json_blinded_path.h
common: move json_to_blinded_path into its own file.
2024-05-12 19:11:43 -05:00
json_channel_type.c
common: move json_add_channel_type from lightningd/
2024-01-29 13:40:34 +10:30
json_channel_type.h
common: move json_add_channel_type from lightningd/
2024-01-29 13:40:34 +10:30
json_command.c
lightningd: check command should return as much detail as possible.
2024-06-25 08:47:50 +09:30
json_command.h
common: move now-enlarged command_fail_badparam into its own source file.
2024-06-25 08:47:50 +09:30
json_filter.c
common/json_filter: routine to turn "filter" JSON into a filter.
2022-11-09 20:25:58 +10:30
json_filter.h
common/json_filter: routine to turn "filter" JSON into a filter.
2022-11-09 20:25:58 +10:30
json_param.c
lightningd: new internal-use commands to allow utxo spend / deposit injection.
2025-08-19 13:37:50 +09:30
json_param.h
lightningd: new internal-use commands to allow utxo spend / deposit injection.
2025-08-19 13:37:50 +09:30
json_parse_simple.c
common: set errno=0 before calling strto{l,ul,ull}
2025-08-15 10:15:16 +09:30
json_parse_simple.h
common/json_parse_simple: make convenience functions inline
2025-08-14 17:53:39 +09:30
json_parse.c
avoid UB when calling ctype functions
2025-08-18 14:03:20 +09:30
json_parse.h
common: round out the short_channel_id_dir JSON routines.
2024-10-04 11:27:53 +09:30
json_stream.c
common: add json_add_timerel helper.
2025-08-14 16:52:44 +09:30
json_stream.h
common: add json_add_timerel helper.
2025-08-14 16:52:44 +09:30
jsonrpc_errors.h
splice: Clean up error messages for RPC
2024-11-21 14:15:36 +10:30
key_derive.c
common: update bolt to neaten pubkey descriptions.
2025-02-11 20:19:01 -06:00
key_derive.h
lightningd: move bip32_pubkey here from common/, add hsm check.
2023-03-22 13:50:32 +10:30
keyset.c
common: update bolt to neaten pubkey descriptions.
2025-02-11 20:19:01 -06:00
keyset.h
…
lease_rates.c
…
lease_rates.h
…
Makefile
splice: Script for complex splices
2024-11-12 06:42:52 +10:30
memleak.c
common/memleak: show tal_steal operations on memleak.
2023-10-03 10:05:55 +02:00
memleak.h
common/memleak: implement callback arg for dump_memleak.
2023-10-03 10:05:55 +02:00
msg_queue.c
connectd: increase queue length to 250,000.
2024-11-01 16:54:49 +10:30
msg_queue.h
…
node_id.c
common: remove type_to_string files altogther.
2024-03-20 13:51:48 +10:30
node_id.h
global: expose all fmt_X functions for direct use, make uniform.
2024-03-20 13:51:48 +10:30
onion_decode.c
common: provide readable explanation when onion payload is invalid.
2024-11-20 12:29:27 +01:00
onion_decode.h
common: provide readable explanation when onion payload is invalid.
2024-11-20 12:29:27 +01:00
onion_encode.c
BOLTs: update which renames blinding terminology.
2024-10-16 07:14:32 +10:30
onion_encode.h
global: rename blinding to path_key everywhere.
2024-10-16 07:14:32 +10:30
onion_message_parse.c
BOLT12: remove -offers from bolt12 quotes, update them.
2025-02-11 20:19:01 -06:00
onion_message_parse.h
global: rename blinding to path_key everywhere.
2024-10-16 07:14:32 +10:30
onion_message.c
BOLT update: catch up ("BOLT 4: rename onionmsg_hop to blinded_path_hop")
2024-10-16 07:14:32 +10:30
onion_message.h
global: rename blinding to path_key everywhere.
2024-10-16 07:14:32 +10:30
onionreply.c
…
onionreply.h
…
overflows.h
…
peer_billboard.c
…
peer_billboard.h
…
peer_failed.c
common: add peer_failed_warn_nodisconnect routine for non-disconnecting warnings
2023-10-23 15:48:50 +10:30
peer_failed.h
common: add peer_failed_warn_nodisconnect routine for non-disconnecting warnings
2023-10-23 15:48:50 +10:30
peer_io.c
…
peer_io.h
…
peer_status_wire.csv
common: add peer_failed_warn_nodisconnect routine for non-disconnecting warnings
2023-10-23 15:48:50 +10:30
penalty_base.c
…
penalty_base.h
…
per_peer_state.c
…
per_peer_state.h
…
permute_tx.c
Update libwally to 0.8.8, support PSBTv2
2023-03-23 16:10:55 +10:30
permute_tx.h
…
ping.c
common: remove #if DEVELOPER.
2023-09-21 20:08:24 +09:30
ping.h
…
plugin.c
core: notify plugins when a log line is emitted.
2024-05-17 13:03:12 -05:00
plugin.h
core: notify plugins when a log line is emitted.
2024-05-17 13:03:12 -05:00
psbt_internal.c
psbt: don’t accumlate 0 lenth widtness data
2025-08-14 04:12:17 +09:30
psbt_internal.h
channeld: Code to implement splicing
2023-07-31 21:00:22 +09:30
psbt_keypath.c
Support p2tr deposit addresses
2023-07-11 11:41:15 +09:30
psbt_keypath.h
Support p2tr deposit addresses
2023-07-11 11:41:15 +09:30
psbt_open.c
splice: Fix cross-channel splices
2025-08-14 04:12:17 +09:30
psbt_open.h
psbt: Add ability to set channel_ids in psbt globals
2024-11-12 06:42:52 +10:30
pseudorand.c
common: fix memcpy error in Fischer-Yates shuffle.
2025-02-11 16:54:08 -06:00
pseudorand.h
common: add tal_arr_randomize() to shuffle an array.
2023-08-12 09:24:06 +09:30
random_select.c
…
random_select.h
…
read_peer_msg.c
common: move is_peer_error/is_peer_warning from read_peer_msg.c to wire_error.c
2023-10-23 15:48:50 +10:30
read_peer_msg.h
common: move is_peer_error/is_peer_warning from read_peer_msg.c to wire_error.c
2023-10-23 15:48:50 +10:30
route.c
pay: Switch to msat for total_capacity
2024-10-07 14:05:47 +02:00
route.h
pay: Switch to msat for total_capacity
2024-10-07 14:05:47 +02:00
scb_wire.csv
scb_wire: Define new subtype 'modern_scb_chan' with 'scb_tlvs'
2025-02-22 11:51:54 -06:00
sciddir_or_pubkey.c
common: add sciddir_or_pubkey type.
2024-05-12 19:11:43 -05:00
sciddir_or_pubkey.h
common: add sciddir_or_pubkey type.
2024-05-12 19:11:43 -05:00
setup.c
PSBT: tal_wally updates and docs
2025-05-13 14:52:15 +09:30
setup.h
…
shutdown_scriptpubkey.c
common: implement op_return test.
2025-03-18 14:30:58 +10:30
shutdown_scriptpubkey.h
common: implement op_return test.
2025-03-18 14:30:58 +10:30
sphinx.c
common: sphinx_path_new to take explicit len.
2024-11-18 11:03:26 +10:30
sphinx.h
common: sphinx_path_new to take explicit len.
2024-11-18 11:03:26 +10:30
splice_script.c
avoid UB when calling ctype functions
2025-08-18 14:03:20 +09:30
splice_script.h
splice: Script for complex splices
2024-11-12 06:42:52 +10:30
status_levels.c
logging: add TRACE between DEBUG and IO
2024-05-08 21:05:49 -05:00
status_levels.h
logging: add TRACE between DEBUG and IO
2024-05-08 21:05:49 -05:00
status_wire.c
…
status_wire.csv
…
status_wire.h
…
status.c
common: don't send trace messages by default, don't ratelimit at all.
2024-12-16 09:48:51 +10:30
status.h
common: don't send trace messages by default, don't ratelimit at all.
2024-12-16 09:48:51 +10:30
subdaemon.c
common: don't send trace messages by default, don't ratelimit at all.
2024-12-16 09:48:51 +10:30
subdaemon.h
common/daemon.c: remove #ifdef DEVELOPER in favor of runtime flag.
2023-09-21 20:08:24 +09:30
timeout.c
…
timeout.h
…
trace.c
trace: prevent memleak report.
2025-04-24 17:34:12 +09:30
trace.h
trace: don't use randombytes_buf(), use pseudorand.
2025-04-23 13:45:18 +09:30
tx_roles.c
tx_roles: allow to be serialized btw processes
2023-02-07 21:03:36 -06:00
tx_roles.h
tx_roles: allow to be serialized btw processes
2023-02-07 21:03:36 -06:00
utils.c
PSBT: tal_wally updates and docs
2025-05-13 14:52:15 +09:30
utils.h
PSBT: tal_wally updates and docs
2025-05-13 14:52:15 +09:30
utxo.c
bitcoin: make input witness weight calculation explicit.
2025-05-06 12:27:53 +09:30
utxo.h
bitcoin: make input witness weight calculation explicit.
2025-05-06 12:27:53 +09:30
version.c
lightningd: use OPT_EXITS for options which exit.
2023-06-03 10:50:29 +09:30
version.h
lightningd: use OPT_EXITS for options which exit.
2023-06-03 10:50:29 +09:30
wallet.c
…
wallet.h
wallet: remove unused TX_ANNOTATION type in transaction_annotations table.
2023-01-30 15:15:41 -06:00
wire_error.c
channeld: Fix tx_abort encoding
2024-11-21 14:15:36 +10:30
wire_error.h
channeld: Fix tx_abort encoding
2024-11-21 14:15:36 +10:30
wireaddr.c
common: routine to make wireaddr_internal from wireaddr.
2024-11-25 15:39:13 +10:30
wireaddr.h
common: routine to make wireaddr_internal from wireaddr.
2024-11-25 15:39:13 +10:30