Rusty Russell b05dbeff4e lightningd: don't allow invoices with 640 byte descriptions. ...

They are invalid!  This is because our BOLT11_FIELD_BYTE_LIMIT is not the limit,
it's one greater than the limit.

Reported-by: https://github.com/noblepayne
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Fixed: JSON-RPC: `invoice` no longer accepts 640-byte descriptions (it would produce malformed invoices).

2025-11-13 10:57:49 +10:30

..

test

ccan: update to get improved grab_file API, and adapt code.

2025-10-26 12:37:58 +10:30

addr.c

splice: Add plugin for magic “splice all” command

2024-11-12 06:42:52 +10:30

addr.h

splice: Add plugin for magic “splice all” command

2024-11-12 06:42:52 +10:30

amount.c

common/amount: prevent scaling with invalid factors in amount scale functions

2025-09-15 11:29:49 +09:30

amount.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

autodata.c

…

autodata.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

base32.c

…

base32.h

…

base64.c

fuzz-tests: Enhance b64_encode() validation with roundtrip decoding

2025-07-08 12:54:56 +09:30

base64.h

fuzz-tests: Enhance b64_encode() validation with roundtrip decoding

2025-07-08 12:54:56 +09:30

bech32_util.c

common: Fix off-by-one in from_bech32_charset

2024-05-18 10:02:43 +02:00

bech32_util.h

…

bech32.c

…

bech32.h

…

bigsize.c

…

bigsize.h

…

billboard.c

…

billboard.h

…

bip32.c

…

bip32.h

…

blindedpath.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

blindedpath.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

blindedpay.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

blindedpay.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

blinding.c

BOLTs: update which renames blinding terminology.

2024-10-16 07:14:32 +10:30

blinding.h

BOLTs: update which renames blinding terminology.

2024-10-16 07:14:32 +10:30

blockheight_states.c

common: remove type_to_string files altogther.

2024-03-20 13:51:48 +10:30

blockheight_states.h

global: expose all fmt_X functions for direct use, make uniform.

2024-03-20 13:51:48 +10:30

bolt11_json.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

bolt11_json.h

…

bolt11.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

bolt11.h

lightningd: don't allow invoices with 640 byte descriptions.

2025-11-13 10:57:49 +10:30

bolt12_id.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

bolt12_id.h

common/bolt12_id: generate alias tweak.

2024-08-01 12:31:48 +09:30

bolt12_merkle.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

bolt12_merkle.h

lightningd: use tweak on node_id of different key, for createinvoicerequest.

2024-08-01 12:31:48 +09:30

bolt12.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

bolt12.h

BOLT12: Update recurrence to latest spec draft.

2025-10-01 15:31:30 +09:30

channel_config.c

…

channel_config.h

BOLTs: catch up with minor clarifications.

2024-05-09 16:14:23 -05:00

channel_id.c

common/utils: macros to help get copy/compare across different types right.

2024-07-23 09:54:47 +09:30

channel_id.h

splice: Add plugin for magic “splice all” command

2024-11-12 06:42:52 +10:30

channel_type.c

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

channel_type.h

lightningd: always tell openingd/dualopend what channel type we want.

2025-08-13 14:20:28 +09:30

close_tx.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

close_tx.h

…

closing_fee.h

…

codex32.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

codex32.h

…

coin_mvt.c

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

coin_mvt.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

configdir.c

Remove litecoin support.

2025-10-26 20:31:45 +10:30

configdir.h

common: return location of a ".setconfig" file when we load config.

2025-02-24 19:38:37 +10:30

configvar.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

configvar.h

setconfig: make source for setconfig "setconfig transient".

2025-02-24 19:38:37 +10:30

crypto_state.h

…

cryptomsg.c

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

cryptomsg.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

daemon_conn.c

common: fix dangling memory allocation in daemon_conn_new_()

2025-09-04 13:29:29 +09:30

daemon_conn.h

…

daemon.c

lightningd: scan outputs for BIP86 addresses

2025-10-26 12:37:58 +10:30

daemon.h

pyln-testing: use DEBUG_LIGHTNINGD to start gdb on lightningd during test.

2024-03-20 11:18:36 +10:30

decode_array.c

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

decode_array.h

…

deprecation.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

deprecation.h

…

derive_basepoints.c

common/utils: macros to help get copy/compare across different types right.

2024-07-23 09:54:47 +09:30

derive_basepoints.h

…

descriptor_checksum.c

…

descriptor_checksum.h

…

dev_disconnect.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

dev_disconnect.h

dev_disconnect: add '<' to close after an incoming msg.

2025-01-27 11:07:04 +10:30

dijkstra.c

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

dijkstra.h

common: fix dijkstra scoring.

2024-03-07 14:09:14 +01:00

ecdh_hsmd.c

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

ecdh_hsmd.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

ecdh.h

…

errcode.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

features.c

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

features.h

BOLTs: Update to version with peer storage merged.

2025-03-18 14:30:58 +10:30

fee_states.c

channeld: Adjust the feerate security margin profile

2024-05-13 14:06:45 -05:00

fee_states.h

channeld: Adjust the feerate security margin profile

2024-05-13 14:06:45 -05:00

fp16.c

…

fp16.h

…

gossip_constants.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

gossip_store.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

gossip_store.h

gossip: add COMPLETED bit to mark records which are complete.

2025-10-01 13:29:33 +09:30

gossmap.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

gossmap.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

gossmods_listpeerchannels.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

gossmods_listpeerchannels.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

hash_u5.c

…

hash_u5.h

…

hmac.c

common/utils: macros to help get copy/compare across different types right.

2024-07-23 09:54:47 +09:30

hmac.h

…

hsm_capable.c

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

hsm_capable.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

hsm_secret.c

common: trivial changes from review.

2025-10-26 12:37:58 +10:30

hsm_secret.h

common: trivial changes from review.

2025-10-26 12:37:58 +10:30

hsm_version.h

hsmd_wire: remove hsmd_derive_bip86_key and add it to hsmd_init_reply_v4

2025-10-26 12:37:58 +10:30

htlc_state.c

…

htlc_state.h

…

htlc_trim.c

…

htlc_trim.h

…

htlc_tx.c

…

htlc_tx.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

htlc_wire.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

htlc_wire.h

htlc_wire: fix crash when adding an HTLC

2025-08-27 14:14:31 +09:30

htlc.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

initial_channel.c

common: remove take() leak if new_initial_channel() fails.

2025-10-23 06:44:04 +10:30

initial_channel.h

global: expose all fmt_X functions for direct use, make uniform.

2024-03-20 13:51:48 +10:30

initial_commit_tx.c

common: remove type_to_string files altogther.

2024-03-20 13:51:48 +10:30

initial_commit_tx.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

interactivetx.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

interactivetx.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

iso4217.c

…

iso4217.h

BOLT12: remove -offers from bolt12 quotes, update them.

2025-02-11 20:19:01 -06:00

json_blinded_path.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

json_blinded_path.h

common: move json_to_blinded_path into its own file.

2024-05-12 19:11:43 -05:00

json_channel_type.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

json_channel_type.h

…

json_command.c

lightningd: check command should return as much detail as possible.

2024-06-25 08:47:50 +09:30

json_command.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

json_filter.c

…

json_filter.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

json_param.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

json_param.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

json_parse_simple.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

json_parse_simple.h

common/json_parse_simple: drop redundant and wrong json_str_to_u64()

2025-09-22 10:16:51 +09:30

json_parse.c

common: add json_dup_contents() to duplicate toks and buffer.

2025-10-24 11:28:57 +10:30

json_parse.h

common: add json_dup_contents() to duplicate toks and buffer.

2025-10-24 11:28:57 +10:30

json_stream.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

json_stream.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

jsonrpc_errors.h

lightningd: delnetworkevent support

2025-11-12 13:58:43 +10:30

jsonrpc_io.c

libplugin: use jsonrpc_io logic for sync requests too.

2025-10-24 11:28:57 +10:30

jsonrpc_io.h

libplugin: use jsonrpc_io logic for sync requests too.

2025-10-24 11:28:57 +10:30

key_derive.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

key_derive.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

keyset.c

common: update bolt to neaten pubkey descriptions.

2025-02-11 20:19:01 -06:00

keyset.h

…

lease_rates.c

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

lease_rates.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

Makefile

lightningd: implement listnetworkevents.

2025-11-12 13:58:43 +10:30

memleak.c

memleak: make notleak() work even before memleak is initalized.

2025-10-24 11:30:17 +10:30

memleak.h

common: add new_htable() macro to allocate, initialize and setup memleak coverage for any typed hash table.

2025-10-24 11:30:17 +10:30

msg_queue.c

common: export helper membuf_tal_realloc.

2025-10-24 11:28:57 +10:30

msg_queue.h

…

node_id.c

common/node_id: runtime assertion override, not separate compile time for fuzzing.

2025-10-23 06:44:04 +10:30

node_id.h

common/node_id: runtime assertion override, not separate compile time for fuzzing.

2025-10-23 06:44:04 +10:30

onion_decode.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

onion_decode.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

onion_encode.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

onion_encode.h

global: rename blinding to path_key everywhere.

2024-10-16 07:14:32 +10:30

onion_message_parse.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

onion_message_parse.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

onion_message.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

onion_message.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

onionreply.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

onionreply.h

…

overflows.h

…

peer_billboard.c

…

peer_billboard.h

…

peer_failed.c

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

peer_failed.h

Makefile: run fuzzing corpora as normal unit tests in non-fuzzing mode.

2025-10-23 06:44:04 +10:30

peer_io.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

peer_io.h

…

peer_status_wire.csv

…

penalty_base.c

…

penalty_base.h

…

per_peer_state.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

per_peer_state.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

permute_tx.c

…

permute_tx.h

…

ping.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

ping.h

…

plugin.c

core: notify plugins when a log line is emitted.

2024-05-17 13:03:12 -05:00

plugin.h

core: notify plugins when a log line is emitted.

2024-05-17 13:03:12 -05:00

psbt_internal.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

psbt_internal.h

…

psbt_keypath.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

psbt_keypath.h

…

psbt_open.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

psbt_open.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

pseudorand.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

pseudorand.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

random_select.c

…

random_select.h

…

read_peer_msg.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

read_peer_msg.h

…

route.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

route.h

pay: Switch to msat for total_capacity

2024-10-07 14:05:47 +02:00

scb_wire.csv

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

sciddir_or_pubkey.c

common: add sciddir_or_pubkey type.

2024-05-12 19:11:43 -05:00

sciddir_or_pubkey.h

common: add sciddir_or_pubkey type.

2024-05-12 19:11:43 -05:00

setup.c

common: remove tal_check() call on libwally allocations.

2025-11-03 14:49:33 +10:30

setup.h

…

shutdown_scriptpubkey.c

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

shutdown_scriptpubkey.h

common: implement op_return test.

2025-03-18 14:30:58 +10:30

sphinx.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

sphinx.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

splice_script.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

splice_script.h

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

status_levels.c

logging: add TRACE between DEBUG and IO

2024-05-08 21:05:49 -05:00

status_levels.h

pyln-testing: catch special CI string so we can have non-BROKEN CI warnings.

2025-09-30 11:37:31 +09:30

status_wire.c

…

status_wire.csv

…

status_wire.h

…

status.c

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

status.h

common: don't send trace messages by default, don't ratelimit at all.

2024-12-16 09:48:51 +10:30

subdaemon.c

common: don't send trace messages by default, don't ratelimit at all.

2024-12-16 09:48:51 +10:30

subdaemon.h

…

timeout.c

…

timeout.h

…

trace.c

memleak: make notleak() work even before memleak is initalized.

2025-10-24 11:30:17 +10:30

trace.h

trace: don't use randombytes_buf(), use pseudorand.

2025-04-23 13:45:18 +09:30

tx_roles.c

…

tx_roles.h

…

utils.c

utils: add a generic mlock function with a destructor

2025-10-26 12:37:58 +10:30

utils.h

utils: add a generic mlock function with a destructor

2025-10-26 12:37:58 +10:30

utxo.c

utxo: remove UTXO_P2TR_BIP86 enum and consolidate to UTXO_P2TR

2025-10-26 12:37:58 +10:30

utxo.h

bitcoin: make input witness weight calculation explicit.

2025-05-06 12:27:53 +09:30

version.c

global: remove unnecessary includes from C files.

2025-10-23 06:44:04 +10:30

version.h

…

wallet.c

…

wallet.h

…

wire_error.c

global: remove unnecessary includes from headers.

2025-10-23 06:44:04 +10:30

wire_error.h

channeld: Fix tx_abort encoding

2024-11-21 14:15:36 +10:30

wireaddr.c

common/wireaddr: Fix an out-of-bounds bug in the address parser

2025-09-22 10:23:13 +09:30

wireaddr.h

common: routine to make wireaddr_internal from wireaddr.

2024-11-25 15:39:13 +10:30