davide/palladum-lightning
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity
Files
ffb324f283b4f43d017c083243c051127708f972
palladum-lightning/common
History
Rusty Russell ffb324f283 common: fix dijkstra scoring. 
The "path_score" callback was supposed to evaluate the *entire path*,
but that was counter-intuitive and opened the door to a cost function
bug which caused this path cost to be less than the closer path.

In particular, the capacity bias code didn't understand this at all.

1. Rename the function to `channel_score` and remove the "distance"
   parameter (always "1" since you're supposed to be evaluating a
   single hop).
2. Rename "cost" to the more specific "fee": "score" is our
   actual cost function result (we avoid the word "cost" as it
   may get confused with satoshi amounts).
3. For capacity biassing, we do want to know the amount, but
   explicitly hand that as a separate parameter "total".
4. Fix a minor bug where total handed to scoring function previously
   included channel fee (this is wrong: fee is paid before sending into
   channel).
5. Remove the now-unused total_delay member from the dijkstra
   struct.

Here are the results of our test now (routing 4194303 msat, which
didn't crash the old code, so we could compare).  In both cases
we could find routes to 615 nodes:

Linear success probability (when found): min-max(mean +/- stddev)
	Before: 0.484764-0.999750(0.9781+/-0.049)
	After:  0.487040-0.999543(0.952548+/-0.075)

Hops:
	Before: 1-5(2.13821+/-0.66)
	After:  1-5(2.98374+/-0.77)

Fees:
	Before: 0-50041(2173.75+/-5.3e+03)
	After:  0-50848(922.457+/-2.7e+03)

Delay (blocks):
	Before: 0-294(83.1642+/-68)
	After:  0-196(65.8081+/-60)

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Fixes: https://github.com/ElementsProject/lightning/issues/7092
Changelog-Fixed: Plugins: `pay` would occasionally crash on routing.
Changelog-Fixed: Plugins: `pay` route algorithm fixed and refined to balance fees and capacity far better.
2024-03-07 14:09:14 +01:00
..
test
common: fix dijkstra scoring.
2024-03-07 14:09:14 +01:00
addr.c
encode_scriptpubkey_to_addr: support p2tr
2023-07-11 11:41:15 +09:30
addr.h
encode_scriptpubkey_to_addr: support p2tr
2023-07-11 11:41:15 +09:30
amount.c
common: add amount_feerate helper.
2023-11-01 14:11:28 +10:30
amount.h
common: add amount_feerate helper.
2023-11-01 14:11:28 +10:30
autodata.c
common: clean up autodata in common_shutdown().
2021-11-17 10:51:48 +10:30
autodata.h
common: clean up autodata in common_shutdown().
2021-11-17 10:51:48 +10:30
base32.c
check: make sure all files outside contrib/ include "config.h" first.
2021-12-06 10:05:39 +10:30
base32.h
…
base64.c
common: use ccan/base64 instead of libsodium.
2021-11-14 18:49:46 +01:00
base64.h
wireaddr: clean up tor parsing.
2021-11-14 18:49:46 +01:00
bech32_util.c
check: make sure all files outside contrib/ include "config.h" first.
2021-12-06 10:05:39 +10:30
bech32_util.h
cleanup: remove unneeded includes in header files.
2021-09-17 09:43:22 +09:30
bech32.c
common: rename bech32_encode parameter
2023-05-27 15:06:31 +09:30
bech32.h
common: rename bech32_encode parameter
2023-05-27 15:06:31 +09:30
bigsize.c
check-includes: allow redundant "config.h"
2021-02-04 12:02:36 +10:30
bigsize.h
Remove varint typedef for bigsize
2020-09-23 16:30:36 +09:30
billboard.c
build: allow DEVELOPER builds with -Og and gcc 9.4.0
2022-09-19 10:18:55 +09:30
billboard.h
channeld/dualopend/lightningd: use channel_ready everywhere.
2022-09-12 09:34:52 +09:30
bip32.c
check: make sure all files outside contrib/ include "config.h" first.
2021-12-06 10:05:39 +10:30
bip32.h
…
blindedpath.c
Makefile: update to latest BOLT text.
2023-04-07 21:22:56 +09:30
blindedpath.h
common/blindedpath: expose API at a lower level.
2022-11-09 15:08:03 +01:00
blindedpay.c
Makefile: update to latest BOLT text.
2023-04-07 21:22:56 +09:30
blindedpay.h
common: update to latest route-blinding spec.
2023-01-30 13:24:29 +10:30
blinding.c
Changed external/libwally-core to test_build_fix
2022-04-12 15:17:52 +09:30
blinding.h
…
blockheight_states.c
global: use tal_dup_or_null().
2021-12-30 14:36:55 +10:30
blockheight_states.h
liquidity-ads: persist channel blockheight states to disk
2021-07-20 13:28:38 -04:00
bolt11_json.c
fallback: json add fallback cleanup
2023-10-26 19:11:17 +10:30
bolt11_json.h
common/bolt11_json: extract bolt11->json code.
2021-01-09 14:34:35 +10:30
bolt11.c
invoice: force inclusion of min_final_cltv_expiry for compatibility
2023-12-22 13:10:10 +01:00
bolt11.h
common/bolt11: remove #if DEVELOPER.
2023-09-21 20:08:24 +09:30
bolt12_merkle.c
bolt12: update comments to match latest spec.
2022-11-09 15:08:03 +01:00
bolt12_merkle.h
hsmd: don't use point32 for bolt12, but use pubkeys (though still always 02)
2022-10-26 11:29:06 +10:30
bolt12.c
common/bolt12: roll all necessary checks into offer_decode.
2023-09-21 13:31:03 +09:30
bolt12.h
common/bolt12: roll all necessary checks into offer_decode.
2023-09-21 13:31:03 +09:30
channel_config.c
check: make sure all files outside contrib/ include "config.h" first.
2021-12-06 10:05:39 +10:30
channel_config.h
lightningd: new option for htlc dust limit
2021-10-23 12:59:13 +02:00
channel_id.c
common: generalize extract_channel_id().
2021-12-30 09:50:40 +10:30
channel_id.h
common: generalize extract_channel_id().
2021-12-30 09:50:40 +10:30
channel_type.c
common: channel_type_accept doesn't use their_features; remove parameter.
2024-01-29 13:40:34 +10:30
channel_type.h
common: channel_type_accept doesn't use their_features; remove parameter.
2024-01-29 13:40:34 +10:30
close_tx.c
Support p2tr deposit addresses
2023-07-11 11:41:15 +09:30
close_tx.h
hsmd: Add wallet index metadata to existing messages
2022-03-10 10:22:29 +10:30
closing_fee.h
…
codex32.c
codex32: use "cl" instead of "ms" as our HRP.
2023-08-02 16:12:32 +09:30
codex32.h
codex32: use "cl" instead of "ms" as our HRP.
2023-08-02 16:12:32 +09:30
coin_mvt.c
common/utils: add tal_strdup_or_null helper.
2023-07-26 06:55:48 +09:30
coin_mvt.h
bkpr: for zerconfs, we still wanna know you're opening a channel
2022-07-28 12:08:18 +09:30
configdir.c
lightningd: add --developer runtime option.
2023-09-21 20:08:24 +09:30
configdir.h
lightningd: add --developer runtime option.
2023-09-21 20:08:24 +09:30
configvar.c
common: remove #if DEVELOPER.
2023-09-21 20:08:24 +09:30
configvar.h
common: allow configvars to be marked dynamic.
2023-06-20 20:08:25 +09:30
crypto_state.h
per_peer_state: remove struct crypto_state
2022-01-20 15:24:06 +10:30
cryptomsg.c
doc: update to BOLT 7f53a3e46ed59f19463447d5fa63b3e484c708a5 "BOLT 8: make it clear that there are *two* chaining keys."
2023-09-20 13:56:46 +09:30
cryptomsg.h
common: make hdr parameter const
2023-06-23 13:12:42 +09:30
daemon_conn.c
common/daemon_conn: add function to read an fd.
2022-07-18 20:50:04 -05:00
daemon_conn.h
common/daemon_conn: add function to read an fd.
2022-07-18 20:50:04 -05:00
daemon.c
build: fix compilation issue on OpenBSD
2023-10-15 14:01:45 +02:00
daemon.h
common/daemon.c: remove #ifdef DEVELOPER in favor of runtime flag.
2023-09-21 20:08:24 +09:30
decode_array.c
Makefile: update to BOLTs without zlib.
2022-05-19 09:47:32 +09:30
decode_array.h
Makefile: update to BOLTs without zlib.
2022-05-19 09:47:32 +09:30
deprecation.c
Makefile: add CLN_NEXT_VERSION, functions encoding deprecation schedule.
2024-01-26 10:30:22 +10:30
deprecation.h
Makefile: add CLN_NEXT_VERSION, functions encoding deprecation schedule.
2024-01-26 10:30:22 +10:30
derive_basepoints.c
common: remove #if DEVELOPER.
2023-09-21 20:08:24 +09:30
derive_basepoints.h
common: remove #if DEVELOPER.
2023-09-21 20:08:24 +09:30
descriptor_checksum.c
check: make sure all files outside contrib/ include "config.h" first.
2021-12-06 10:05:39 +10:30
descriptor_checksum.h
…
dev_disconnect.c
dualfund: add test to make sure that tx-sigs sent before commitment
2023-11-02 19:32:05 +10:30
dev_disconnect.h
dualfund: add test to make sure that tx-sigs sent before commitment
2023-11-02 19:32:05 +10:30
dijkstra.c
common: fix dijkstra scoring.
2024-03-07 14:09:14 +01:00
dijkstra.h
common: fix dijkstra scoring.
2024-03-07 14:09:14 +01:00
ecdh_hsmd.c
check: make sure all files outside contrib/ include "config.h" first.
2021-12-06 10:05:39 +10:30
ecdh_hsmd.h
…
ecdh.h
…
errcode.h
jsonrpc: make error codes an enum.
2022-09-19 10:18:55 +09:30
features.c
common: restore OPT_SPLICE definition for the day it's ratified.
2023-08-10 15:52:53 +09:30
features.h
common: restore OPT_SPLICE definition for the day it's ratified.
2023-08-10 15:52:53 +09:30
fee_states.c
global: use tal_dup_or_null().
2021-12-30 14:36:55 +10:30
fee_states.h
…
fp16.c
…
fp16.h
…
gossip_constants.h
gossipd: remove #if DEVELOPER in favor of runtime flag.
2023-09-21 20:08:24 +09:30
gossip_store.c
common/gossip_store: move subdaemon-only routines to connectd.
2023-01-30 15:15:41 -06:00
gossip_store.h
common: add gossmap_chan_is_dying() helper to check flags.
2024-02-12 11:43:33 +01:00
gossmap.c
common: fix uninitialized member in gossmap.
2024-03-07 14:09:14 +01:00
gossmap.h
common: add gossmap_chan_is_dying() helper to check flags.
2024-02-12 11:43:33 +01:00
gossmods_listpeerchannels.c
common: generic routine to turn listpeerchannels into gossmap local updates.
2023-12-14 09:16:56 +10:30
gossmods_listpeerchannels.h
common: generic routine to turn listpeerchannels into gossmap local updates.
2023-12-14 09:16:56 +10:30
hash_u5.c
check: make sure all files outside contrib/ include "config.h" first.
2021-12-06 10:05:39 +10:30
hash_u5.h
…
hmac.c
check: make sure all files outside contrib/ include "config.h" first.
2021-12-06 10:05:39 +10:30
hmac.h
…
hsm_capable.c
channeld: add hsm_capabilities and add hsm_is_capable to common
2024-01-29 12:02:37 +10:30
hsm_capable.h
channeld: add hsm_capabilities and add hsm_is_capable to common
2024-01-29 12:02:37 +10:30
hsm_encryption.c
lightningd: expand exit codes for various failures.
2022-07-20 19:28:33 +09:30
hsm_encryption.h
cli: make the command line more user friendly.
2022-03-24 09:53:38 +10:30
hsm_version.h
hsmd: remove deprecated init v2
2024-02-27 14:04:44 +01:00
htlc_state.c
check: make sure all files outside contrib/ include "config.h" first.
2021-12-06 10:05:39 +10:30
htlc_state.h
…
htlc_trim.c
global: thread zero fee option everywhere.
2023-06-29 11:28:47 -04:00
htlc_trim.h
global: thread zero fee option everywhere.
2023-06-29 11:28:47 -04:00
htlc_tx.c
global: thread zero fee option everywhere.
2023-06-29 11:28:47 -04:00
htlc_tx.h
global: thread zero fee option everywhere.
2023-06-29 11:28:47 -04:00
htlc_wire.c
channeld: don't calculate blinding shared secret, let lightningd do it.
2022-10-26 11:29:06 +10:30
htlc_wire.h
channeld: don't calculate blinding shared secret, let lightningd do it.
2022-10-26 11:29:06 +10:30
htlc.h
cleanup: remove unneeded includes in header files.
2021-09-17 09:43:22 +09:30
initial_channel.c
init channel: only fill in wscript if requested
2023-11-02 19:32:05 +10:30
initial_channel.h
channeld: Code to implement splicing
2023-07-31 21:00:22 +09:30
initial_commit_tx.c
global: thread zero fee option everywhere.
2023-06-29 11:28:47 -04:00
initial_commit_tx.h
global: thread zero fee option everywhere.
2023-06-29 11:28:47 -04:00
interactivetx.c
interactive_tx: Add tx_abort support
2024-02-11 10:46:23 +01:00
interactivetx.h
interactive_tx: Add tx_abort support
2024-02-11 10:46:23 +01:00
invoice_path_id.c
createinvoice: make a minimal blinded "path" in bolt12 invoice if none presented.
2022-11-09 15:08:03 +01:00
invoice_path_id.h
createinvoice: make a minimal blinded "path" in bolt12 invoice if none presented.
2022-11-09 15:08:03 +01:00
iso4217.c
check: make sure all files outside contrib/ include "config.h" first.
2021-12-06 10:05:39 +10:30
iso4217.h
bolt12: update comments to match latest spec.
2022-11-09 15:08:03 +01:00
json_channel_type.c
common: move json_add_channel_type from lightningd/
2024-01-29 13:40:34 +10:30
json_channel_type.h
common: move json_add_channel_type from lightningd/
2024-01-29 13:40:34 +10:30
json_command.h
common: add command_deprecated_param_ok() and command_deprecated_out_ok()
2024-01-26 10:30:22 +10:30
json_filter.c
common/json_filter: routine to turn "filter" JSON into a filter.
2022-11-09 20:25:58 +10:30
json_filter.h
common/json_filter: routine to turn "filter" JSON into a filter.
2022-11-09 20:25:58 +10:30
json_param.c
common: don't insist on unique param() arguments.
2024-02-07 09:21:00 +10:30
json_param.h
common: allow JSON-RPC parameters to specify deprecation versions.
2024-01-26 10:30:22 +10:30
json_parse_simple.c
signed types: add handlers for signed types
2023-07-13 19:34:47 +09:30
json_parse_simple.h
signed types: add handlers for signed types
2023-07-13 19:34:47 +09:30
json_parse.c
signed types: add handlers for signed types
2023-07-13 19:34:47 +09:30
json_parse.h
common: fix wrong comment on json_scan() return.
2023-07-25 14:47:12 +09:30
json_stream.c
lightningd: don't print out notification msat fields as strings.
2023-11-21 08:23:39 +01:00
json_stream.h
common: move json_add_channel_type from lightningd/
2024-01-29 13:40:34 +10:30
jsonrpc_errors.h
lightningd: Add tx_abort routine to lightningd
2024-02-11 10:46:23 +01:00
key_derive.c
lightningd: move bip32_pubkey here from common/, add hsm check.
2023-03-22 13:50:32 +10:30
key_derive.h
lightningd: move bip32_pubkey here from common/, add hsm check.
2023-03-22 13:50:32 +10:30
keyset.c
check: make sure all files outside contrib/ include "config.h" first.
2021-12-06 10:05:39 +10:30
keyset.h
cleanup: remove unneeded includes in header files.
2021-09-17 09:43:22 +09:30
lease_rates.c
lease_rates: prepare for msats fields as raw numbers.
2022-06-21 06:52:35 +09:30
lease_rates.h
lease_rates: prepare for msats fields as raw numbers.
2022-06-21 06:52:35 +09:30
Makefile
common: remote private_channel_announcement.[ch].
2024-01-31 14:47:33 +10:30
memleak.c
common/memleak: show tal_steal operations on memleak.
2023-10-03 10:05:55 +02:00
memleak.h
common/memleak: implement callback arg for dump_memleak.
2023-10-03 10:05:55 +02:00
msg_queue.c
msg_queue: don't allow magic MSG_PASS_FD message for peers.
2022-01-20 15:24:06 +10:30
msg_queue.h
msg_queue: don't allow magic MSG_PASS_FD message for peers.
2022-01-20 15:24:06 +10:30
node_id.c
lightningd: check channel_announcement signatures we get from peer.
2024-01-31 14:47:33 +10:30
node_id.h
lightningd: check channel_announcement signatures we get from peer.
2024-01-31 14:47:33 +10:30
onion_decode.c
common: rename tlv_payload's "blinding_point" to "current_blinding_point" as per spec.
2023-09-20 13:56:46 +09:30
onion_decode.h
common/onion: split into decode and encode routines.
2022-11-09 15:08:03 +01:00
onion_encode.c
doc: update to BOLT cded2df1fd0095c947af02a52e28b16c66bdfc5c "Fix undeclared reference in onion-routing"
2023-09-20 13:56:46 +09:30
onion_encode.h
Makefile: update bolts to 60cfb5972ad4bec4c49ee0f9e729fb3352fcdc6a.
2023-04-07 21:22:56 +09:30
onion_message_parse.c
common: update to latest onion-message spec.
2023-01-30 13:24:29 +10:30
onion_message_parse.h
common/onion_message_parse: generic routine for parsing onion messages.
2022-10-26 11:29:06 +10:30
onionreply.c
check: make sure all files outside contrib/ include "config.h" first.
2021-12-06 10:05:39 +10:30
onionreply.h
…
overflows.h
overflows: helpers for integer assignment overflows.
2021-07-20 13:28:38 -04:00
peer_billboard.c
check: make sure all files outside contrib/ include "config.h" first.
2021-12-06 10:05:39 +10:30
peer_billboard.h
…
peer_failed.c
common: add peer_failed_warn_nodisconnect routine for non-disconnecting warnings
2023-10-23 15:48:50 +10:30
peer_failed.h
common: add peer_failed_warn_nodisconnect routine for non-disconnecting warnings
2023-10-23 15:48:50 +10:30
peer_io.c
peer subds: ignore failed writes.
2022-01-20 15:24:06 +10:30
peer_io.h
connectd: do nagle by packet type.
2022-01-20 15:24:06 +10:30
peer_status_wire.csv
common: add peer_failed_warn_nodisconnect routine for non-disconnecting warnings
2023-10-23 15:48:50 +10:30
penalty_base.c
…
penalty_base.h
cleanup: remove unneeded includes in header files.
2021-09-17 09:43:22 +09:30
per_peer_state.c
subdaemons: remove gossipd fd from per-peer daemons.
2022-02-08 11:15:52 +10:30
per_peer_state.h
subdaemons: remove gossipd fd from per-peer daemons.
2022-02-08 11:15:52 +10:30
permute_tx.c
Update libwally to 0.8.8, support PSBTv2
2023-03-23 16:10:55 +10:30
permute_tx.h
common: remove unused functions or make static.
2021-12-06 10:05:39 +10:30
ping.c
common: remove #if DEVELOPER.
2023-09-21 20:08:24 +09:30
ping.h
channeld: restore ping command, but only for channeld.
2021-10-10 15:32:57 +02:00
psbt_internal.c
psbt-fix: set to NULL, which will cleanup dangling pointer
2023-12-15 10:20:19 +10:30
psbt_internal.h
channeld: Code to implement splicing
2023-07-31 21:00:22 +09:30
psbt_keypath.c
Support p2tr deposit addresses
2023-07-11 11:41:15 +09:30
psbt_keypath.h
Support p2tr deposit addresses
2023-07-11 11:41:15 +09:30
psbt_open.c
common: add tal_arr_eq helper.
2024-02-16 15:02:38 +01:00
psbt_open.h
Update libwally to 0.8.8, support PSBTv2
2023-03-23 16:10:55 +10:30
pseudorand.c
common: add tal_arr_randomize() to shuffle an array.
2023-08-12 09:24:06 +09:30
pseudorand.h
common: add tal_arr_randomize() to shuffle an array.
2023-08-12 09:24:06 +09:30
random_select.c
check: make sure all files outside contrib/ include "config.h" first.
2021-12-06 10:05:39 +10:30
random_select.h
…
read_peer_msg.c
common: move is_peer_error/is_peer_warning from read_peer_msg.c to wire_error.c
2023-10-23 15:48:50 +10:30
read_peer_msg.h
common: move is_peer_error/is_peer_warning from read_peer_msg.c to wire_error.c
2023-10-23 15:48:50 +10:30
route.c
common: fix dijkstra scoring.
2024-03-07 14:09:14 +01:00
route.h
common: fix dijkstra scoring.
2024-03-07 14:09:14 +01:00
scb_wire.csv
staticbackup: don't use wireaddr_internal.
2023-06-01 09:28:39 +09:30
setup.c
wally: rename functions that clash with wally v1.0.0
2024-01-16 15:47:03 +01:00
setup.h
…
shutdown_scriptpubkey.c
lightningd: only allow closing to native segwit
2022-12-13 08:28:12 +10:30
shutdown_scriptpubkey.h
lightningd: only allow closing to native segwit
2022-12-13 08:28:12 +10:30
sphinx.c
common: remove #if DEVELOPER.
2023-09-21 20:08:24 +09:30
sphinx.h
common: remove #if DEVELOPER.
2023-09-21 20:08:24 +09:30
status_levels.c
check: make sure all files outside contrib/ include "config.h" first.
2021-12-06 10:05:39 +10:30
status_levels.h
…
status_wire.c
check: make sure all files outside contrib/ include "config.h" first.
2021-12-06 10:05:39 +10:30
status_wire.csv
cleanup: remove unneeded includes in header files.
2021-09-17 09:43:22 +09:30
status_wire.h
…
status.c
common/memleak: implement callback arg for dump_memleak.
2023-10-03 10:05:55 +02:00
status.h
common/memleak: implement callback arg for dump_memleak.
2023-10-03 10:05:55 +02:00
subdaemon.c
common/daemon.c: remove #ifdef DEVELOPER in favor of runtime flag.
2023-09-21 20:08:24 +09:30
subdaemon.h
common/daemon.c: remove #ifdef DEVELOPER in favor of runtime flag.
2023-09-21 20:08:24 +09:30
timeout.c
common: add routine for absolute timeouts (vs. relative).
2022-01-20 15:24:06 +10:30
timeout.h
common: add routine for absolute timeouts (vs. relative).
2022-01-20 15:24:06 +10:30
trace.c
misc: Improve generated traces from common/trace.c
2023-12-23 15:19:31 +01:00
trace.h
misc: Improve generated traces from common/trace.c
2023-12-23 15:19:31 +01:00
tx_roles.c
tx_roles: allow to be serialized btw processes
2023-02-07 21:03:36 -06:00
tx_roles.h
tx_roles: allow to be serialized btw processes
2023-02-07 21:03:36 -06:00
type_to_string.c
common: remove #if DEVELOPER.
2023-09-21 20:08:24 +09:30
type_to_string.h
Remove point32.
2022-10-26 11:29:06 +10:30
utils.c
common: add tal_arr_eq helper.
2024-02-16 15:02:38 +01:00
utils.h
common: add tal_arr_eq helper.
2024-02-16 15:02:38 +01:00
utxo.c
global: thread zero fee option everywhere.
2023-06-29 11:28:47 -04:00
utxo.h
global: thread zero fee option everywhere.
2023-06-29 11:28:47 -04:00
version.c
lightningd: use OPT_EXITS for options which exit.
2023-06-03 10:50:29 +09:30
version.h
lightningd: use OPT_EXITS for options which exit.
2023-06-03 10:50:29 +09:30
wallet.c
check: make sure all files outside contrib/ include "config.h" first.
2021-12-06 10:05:39 +10:30
wallet.h
wallet: remove unused TX_ANNOTATION type in transaction_annotations table.
2023-01-30 15:15:41 -06:00
wire_error.c
fixup! lightningd: Add tx_abort routine to lightningd
2024-02-11 10:46:23 +01:00
wire_error.h
common: move is_peer_error/is_peer_warning from read_peer_msg.c to wire_error.c
2023-10-23 15:48:50 +10:30
wireaddr.c
lightningd: allow --bind=ws:
2023-06-01 09:28:39 +09:30
wireaddr.h
doc: update to BOLT 29c14c6e12cbdf33f6b724094c81658a614d2e02 "fix typos"
2023-09-20 13:56:46 +09:30