Commit Graph

4452 Commits

Author SHA1 Message Date
SomberNight
d67e24438e lnsweep: rm code dupe: 2nd stage htlc tx out vs ctx to_local addr reuse 2021-11-01 18:05:33 +01:00
SomberNight
99836d5e5f kivy: confirm_tx_dialog: toggling "final" should update the tx
We create a tx when the dialog is created, and re-create it every time
the user moves the fee slider. However, we were not re-creating it if
the user toggles the "Final" checkbox, meaning its value was only taken
into account if the user moved the fee slider after setting the checkbox.

fixes https://github.com/spesmilo/electrum/issues/7547
2021-10-29 14:27:13 +02:00
ghost43
5787f3ab74 Merge pull request #7542 from bitromortac/2109-dust-limit
Implement recent spec changes regarding collab channel close outputs
2021-10-27 16:51:07 +02:00
SomberNight
cb55a2d654 tests: try to reduce flakyness of test_fail_pending_htlcs_on_shutdown
Alice sends and HTLC: Alice->Carol->Dave
we need a lot of messages back and forth to happen:
- Alice adds HTLC to chan_AC, sends sig, Carol revacks, sends sig, Alice revacks;
- only then Carol adds HTLC to chan_CD, sends sig, Dave revacks, sends sig, Carol revacks
on CI, 0.5 seconds is often not enough for this it seems.
2021-10-27 16:46:15 +02:00
bitromortac
e97f350597 add comment for safer forwarding 2021-10-27 16:27:16 +02:00
bitromortac
947693c90d check dust limits
* on channel opening we verify that the peer's dust limit is above 354
  sat, the limit for unknown segwit versions
* we constrain the allowed scriptpubkey types for channel closing
* we check that the remote's output is above the relay dust limit for
  the collaborative close case
2021-10-27 16:27:15 +02:00
bitromortac
f2f8c4533b implement option_shutdown_anysegwit
https://github.com/lightningnetwork/lightning-rfc/pull/672

We check the received shutdown script against higher segwit versions and
accept closing to that script if option_shutdown_anysegwit has been
negotiated.
2021-10-26 14:51:09 +02:00
SomberNight
5c91212fab dns hacks: dns via proxy: special-case "localhost" string
fix https://github.com/spesmilo/electrum/issues/7546
2021-10-25 17:46:51 +02:00
SomberNight
1ff9f9910f ln update_fee: enforce that feerate is over default min relay fee
(this was always already the case when we are the funder, but we were
not checking it when remote is responsible for update_fee)
2021-09-28 19:48:31 +02:00
SomberNight
4af103378a lnpeer: refactor some checks re open_channel/accept_channel 2021-09-28 19:48:27 +02:00
ghost43
437a9e4358 Merge pull request #7505 from bitromortac/2109-activate-watchtower
watchtower: continuously check for added channels
2021-09-28 16:46:19 +02:00
bitromortac
ff61020dd2 watchtower: watch new channels 2021-09-27 10:31:44 +02:00
ThomasV
baff4fa625 save_backup: do not remove deterministic LN key (see #7513) 2021-09-26 12:18:25 +02:00
ThomasV
b431d8e9b8 follow-up eadd1bebb2 2021-09-24 17:36:33 +02:00
bitromortac
8913abdf9a python3.9: sample from list instead of set
electrum/electrum/channel_db.py:357: DeprecationWarning: Sampling from a
set deprecated since Python 3.9 and will be removed in a subsequent version.
2021-09-22 14:50:32 +02:00
ThomasV
eadd1bebb2 Do not convert StoredDict keys to str.
Instead, convert json keys to int when storage is read.
2021-09-20 14:49:59 +02:00
ThomasV
7a0904c0f4 wallet update: move fields that have string keys out of channel log 2021-09-20 14:47:20 +02:00
SomberNight
1188187431 wallet_db upgrade: in OnchainInvoice['outputs'], convert vals None->0
should fix https://github.com/spesmilo/electrum/issues/7500
2021-09-19 17:35:49 +02:00
SomberNight
b7cdf3fe11 wallet_db upgrades: (trivial) make upgrades more standalone
and robust to code changes
2021-09-19 17:32:25 +02:00
SomberNight
0b05edc705 wallet payreqs: trivial clean-up 2021-09-19 17:25:57 +02:00
SomberNight
433c6762c9 Qt Send tab: handle exc when "." is entered into amount_e
To reproduce: enter "." to amount_e in Send tab; then click "Save".

Traceback (most recent call last):
  File "/home/user/wspace/electrum/electrum/gui/qt/main_window.py", line 1638, in do_save_invoice
    self.pending_invoice = self.read_invoice()
  File "/home/user/wspace/electrum/electrum/gui/qt/main_window.py", line 1625, in read_invoice
    outputs = self.read_outputs()
  File "/home/user/wspace/electrum/electrum/gui/qt/main_window.py", line 1501, in read_outputs
    outputs = self.payto_e.get_outputs(self.max_button.isChecked())
  File "/home/user/wspace/electrum/electrum/gui/qt/paytoedit.py", line 235, in get_outputs
    self.outputs = [PartialTxOutput(scriptpubkey=self.payto_scriptpubkey, value=amount)]
  File "/home/user/wspace/electrum/electrum/transaction.py", line 1533, in __init__
    TxOutput.__init__(self, *args, **kwargs)
  File "/home/user/wspace/electrum/electrum/transaction.py", line 113, in __init__
    raise ValueError(f"bad txout value: {value!r}")
ValueError: bad txout value: None
2021-09-19 16:53:58 +02:00
SomberNight
be084dd44b qt wallet info: make labels selectable 2021-09-16 09:13:44 +02:00
SomberNight
4293d6eca0 kivy: settings: better handling of "default" language 2021-09-15 19:52:40 +02:00
SomberNight
7cb11ceda4 kivy: locale: set default language based to OS lang
On Android, the default language is now set to the language of the OS,
instead of English.

related https://github.com/spesmilo/electrum/issues/4618
related https://github.com/spesmilo/electrum/issues/7494
2021-09-15 19:51:10 +02:00
SomberNight
22bb52d5df kivy: locale: also translate strings in core lib 2021-09-15 19:45:06 +02:00
SomberNight
3f69e5ae3e qt cpfp: (trivial) make some strings translatable
gettext was not picking these up
2021-09-15 17:37:22 +02:00
djboi
679bd21bac Added CPFP Feature for Kivy GUI (#7487)
implements https://github.com/spesmilo/electrum/issues/5507
2021-09-15 15:32:24 +00:00
SomberNight
85780eea1a multiple max spends: add unit test
re https://github.com/spesmilo/electrum/pull/7492
2021-09-15 16:42:32 +02:00
SomberNight
acbb363240 follow-up prev: some clean-ups
re https://github.com/spesmilo/electrum/pull/7492
2021-09-15 16:41:41 +02:00
Siddhant Chawla
65c3a892cf Multiple max spends functionality added (#7492)
this implements https://github.com/spesmilo/electrum/issues/7054
2021-09-15 14:35:15 +00:00
JeremyRand
b1c4bb8914 Add Cirrus CI (#7431)
* Cirrus: Add Tox task

* Cirrus: Add Locale task

* Cirrus: Add Flake8 Task

* Cirrus: Add Regtest task

* Regtest: Flush stdout

Allows viewing output sooner.

* Regtest: Read process.stdout in text mode

Improves ability to quickly see output.

* Cirrus: Add Windows task

* Cirrus: Add Android task

* Cirrus: Add macOS task

* Cirrus: Add AppImage task

* Cirrus: Add tarball task

* Cirrus: Add Submodules task

* Android: remove superfluous cp/rm

* Add .dockerignore

Symlink to .gitignore.
2021-09-13 16:20:54 +00:00
Caio Costa
397e43373f Removes inaccurate "brasilian" language
The option "brasilian" is inaccurate since we brazilians do speak Portuguese.
We don't consider "brasilian" as a language, so I believe this change I've made is a more accurate option for this public.
2021-09-09 22:32:51 -03:00
SomberNight
bf6400ae30 kivy: fix when running with --offline 2021-09-09 17:40:21 +02:00
SomberNight
67f14cdfa8 follow-up prev: some clean-up and added clarifications
re https://github.com/spesmilo/electrum/pull/7464
2021-09-09 17:22:37 +02:00
Siddhant Chawla
3a583885d9 Add network setup option when Kivy GUI starts for the First time. (#7464)
Offer a first-start network setup screen when using the kivy GUI,
similar to what is already done in Qt.
2021-09-09 15:18:19 +00:00
SomberNight
07bd2fe97d network.py: reorder bitcoin core error msg whitelist
test policy.cpp strings last as some of them are short and too generic

fixes https://github.com/spesmilo/electrum/issues/7483
2021-09-08 18:18:08 +02:00
SomberNight
9353220e5d qt send tab: try to make it clearer the sender pays the fee
related: https://github.com/spesmilo/electrum/issues/7488
2021-09-08 16:50:26 +02:00
SomberNight
f7820717be qt ConfirmTxDialog: make fields selectable
related: https://github.com/spesmilo/electrum/issues/7488
2021-09-08 16:39:59 +02:00
SomberNight
c84b873339 qt PreviewTxDialog: fix sizing of fee edits
follow-up to cfdadeda67
2021-09-08 16:36:07 +02:00
ghost43
c338cebe55 Merge pull request #7454 from wakiyamap/change_signet_nodes
Change lightning node(signet)
2021-09-07 17:51:23 +02:00
ghost43
f62b23b210 Merge pull request #7485 from nyanpasu64/fix-tab-order
Fix tab order in Qt setup wizard
2021-09-07 16:48:29 +02:00
djboi
604cba8fb6 Added different Sighash_Types (#7453)
Implements signing for sighash types other than `ALL` for segwit inputs.

fixes https://github.com/spesmilo/electrum/issues/7408
2021-09-07 14:41:50 +00:00
nyanpasu64
024a5a84c3 Fix tab order in setup wizard 2021-09-06 23:56:27 -07:00
SomberNight
a39bfba2d9 ecc: allow tests to disable ecdsa R-value grinding
see https://github.com/spesmilo/electrum/pull/7453#issuecomment-912594926
2021-09-03 17:18:13 +02:00
bitromortac
ebc5954d61 fix ln payments: set payto_e ln invoice correctly
payto_e.lightning_invoice has to be set after the payment field is set
to the node pub key, because check_text has the side effect of resetting
the payto_e.lightning_invoice
2021-08-20 09:21:47 +02:00
wakiyamap
de596a6bfa Change lightning node(signet) 2021-08-12 17:13:28 +09:00
Siddhant Chawla
e9f08ef69e Adding BumpFee command to the CLI (#7438)
closes https://github.com/spesmilo/electrum/issues/5791
2021-08-11 11:30:26 +00:00
bitromortac
e9a1bd1f1e kivy: fix on_intent to call set_URI 2021-07-30 09:47:43 +02:00
bitromortac
c65caf6c68 qt+android: add lightning URI support 2021-07-30 08:44:15 +02:00
bitromortac
6716004b47 bolt11: fix amount encoding for large values 2021-07-30 08:44:15 +02:00