davide/pallectrum
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
17,381 Commits 3 Branches 0 Tags
73fee69f5c20c19c820c219719e9ae5d05409e64
Commit Graph

3265 Commits

Author SHA1 Message Date
ghost43
e11d7b37f2 Merge pull request #8865 from SomberNight/202402_server_bookmarks 
network: implement basic "add server as bookmark" functionality
 2024-02-16 12:06:18 +00:00
accumulator
1b75e3883e Merge pull request #8845 from accumulator/feepicker 
qml: consolidate fee slider ui in various places to a single FeePicker control
 2024-02-16 13:01:34 +01:00
Sander van Grieken
016e500993 qml: FeePicker parameterize enable display of tx info and picker, use this for CPFP 
to put picker in Total section
 2024-02-16 12:56:18 +01:00
Sander van Grieken
c0b892720e qml: consolidate fee slider ui in various places to a single FeePicker control 2024-02-16 10:09:56 +01:00
ghost43
5582b753e5 Merge pull request #8881 from accumulator/qobject_test 
add a simple test framework for testing QObjects and their signal/slot mechanism
 2024-02-15 14:46:50 +00:00
SomberNight
fffbc178cd qt wizard: hww dialogs: log some exceptions more aggressively 
sort of related: https://github.com/spesmilo/electrum/issues/8892
 2024-02-14 09:05:21 +00:00
SomberNight
7cf22d4b9f coldcard: wallet info dlg: fix missing "Export for Coldcard" btn 
regression from 711a325085

```
 47.97 | E | plugin | Plugin error. plugin: coldcard, hook: wallet_info_buttons
Traceback (most recent call last):
  File "...\electrum\electrum\plugin.py", line 261, in run_hook
    r = f(*args)
  File "...\electrum\electrum\plugins\hw_wallet\plugin.py", line 344, in wrapper
    return func(self, *args, **kwargs)
  File "...\electrum\electrum\plugins\coldcard\qt.py", line 51, in wallet_info_buttons
    wallet = main_window.wallet
AttributeError: 'WalletInfoDialog' object has no attribute 'wallet'
```
 2024-02-13 13:35:19 +00:00
Sander van Grieken
66af6e6239 send_tab: set tab changes focus for multiline edit 
ref #8889
 2024-02-13 13:00:11 +01:00
Sander van Grieken
b3bce0299f send_tab: fix tab order #8889 2024-02-13 12:49:08 +01:00
Sander van Grieken
3582c79160 stub QVideoSink import as it requires many dependencies but isn't used on android currently 2024-02-12 11:49:43 +01:00
Sander van Grieken
2dd4195ad8 qt: ChoiceWidget fix init selected_key 2024-02-08 11:42:14 +01:00
Sander van Grieken
19d9467b93 qml: add typing declarations to qechanneldetails 2024-02-07 10:53:10 +01:00
accumulator
acc7b44a3e Merge pull request #8873 from accumulator/issue_8355 
qml: tighten self._loading guard to encompass whole loadWallet fn
 2024-02-06 13:55:26 +01:00
Sander van Grieken
39bc672da2 followup prev 2024-02-06 10:37:35 +01:00
Sander van Grieken
cac9c4bbb9 qt: fix various issues on send_tab, fixes #8874 2024-02-06 10:35:42 +01:00
SomberNight
ff8f8d6104 qt: sweep_key_dialog: make UI a bit more intuitive 
user complained:
> when you want to sweep an address. it's very unclear to me as a noob who is getting the money
> might want a little picture with an arrow to show which direction the funds are going
 2024-02-05 23:26:39 +00:00
Sander van Grieken
482ec89b5d minor, code style, imports 2024-02-05 21:25:13 +01:00
Sander van Grieken
4228911609 qml: close TxDetails on TX remove only after the 'removed_transaction' event has been received, so the 
history model doesn't refresh too early (fixes #8782)
 2024-02-05 21:07:33 +01:00
accumulator
620b46780b Merge pull request #8870 from accumulator/wizard_component_race 
qt: wizard: move page.on_ready() to just after construction
 2024-02-05 18:12:24 +01:00
Sander van Grieken
c78a90a242 qt: wizard: move page.on_ready() to just after construction to avoid triggering signal/slots that might 
assume on_ready() has run
 2024-02-05 18:11:43 +01:00
Sander van Grieken
c755a58661 qedaemon: remove redundant, small code style fixes 2024-02-05 18:07:12 +01:00
Sander van Grieken
5aa782a19e qml: extend self._loading guard to encompass _on_backend_wallet_loaded slot as well 2024-02-05 17:59:44 +01:00
Sander van Grieken
b361d02467 qml: tighten self._loading guard to encompass whole loadWallet fn, not just task thread. 
Also make sure QEWallet is never instantiated within the task thread.
 2024-02-05 17:41:56 +01:00
Sander van Grieken
0a2a22b822 qt: use selected_key instead of selected_item[0] for ChoiceWidgets 2024-02-05 14:39:03 +01:00
Sander van Grieken
0a6b2d521b qml: move final wizard submit() to WizardComponent.finish handler 2024-02-05 11:13:58 +01:00
accumulator
019baa5a71 Merge pull request #8862 from SomberNight/202401_qml_wizard_final_accept 
qml wizard: run navmap[view]['accept'] handler a final time on finish
 2024-02-05 10:46:22 +01:00
SomberNight
07dc80dd9a qml wizard: stricter validation for new wallet name 
user on bitcointalk [0] tried to create wallet with name "w/o 2FA".
Before this, one would only get an error after the last page of the wizard.
With this, the "Next" button does not even get enabled if the name does not look ok.
(and as in comment, maybe we should be even stricter re what is allowed)

[0]: https://bitcointalk.org/index.php?topic=5483514.msg63584789#msg63584789
 2024-02-04 08:54:40 +00:00
SomberNight
9c6d7617d3 qt NetworkDialog: sort bookmarked servers to top 2024-02-03 12:33:38 +00:00
SomberNight
e5d28563cc network: implement basic "add server as bookmark" functionality 
implement backend and expose it to qt gui
 2024-02-03 12:33:34 +00:00
SomberNight
ca206de16b qt NetworkDialog: small clean-up 2024-02-03 11:52:33 +00:00
SomberNight
a9a8ed2eb4 follow-up: factor out more hardcoded "sat/byte" and "sat/b" strings 
- rename globals
- also rm hardcoded strings from qml
- use consistent unit names in qml
  (previously mixed sat/vB and sat/byte (latter coming from core lib))
 2024-02-03 05:26:31 +00:00
SomberNight
13a421aabb factor out hardcoded "sat/byte" and "sat/b" strings 
Though note that the qml GUI has some more in qml/js context.
 2024-02-03 04:18:46 +00:00
SomberNight
16eec8daf5 qml QEChannelDetails: show currentFeerate 
related https://github.com/spesmilo/electrum/issues/8863
 2024-02-03 03:43:16 +00:00
SomberNight
d7a9e2d022 qml QEChannelDetails: add some type hints 2024-02-03 03:35:54 +00:00
SomberNight
48a96f6776 qml wizard: run navmap[view]['accept'] handler a final time on finish 
For example, see
061c821128/electrum/plugins/trustedcoin/trustedcoin.py (L624)
Even if navmap[view]['last'] is True, we still want the navmap[view]['accept'] handler to run.

fixes https://github.com/spesmilo/electrum/issues/8861

---

Note that an analogous issue does not exist for the desktop qt gui,
see 061c821128/electrum/gui/qt/wizard/wizard.py (L206)
There, wizard.resolve_next is called regardless of is_last.
 2024-01-31 12:59:47 +00:00
SomberNight
cb55c65677 qml wizard: WCWalletPassword: show warning if pw is too short 2024-01-31 10:28:10 +00:00
SomberNight
e7ebf5d950 qt wizard: handle some cases of hw device being unplugged during flow 
To reproduce, open two wizards in parallel. Use one to enter the flow and start creating a wallet,
then physically unplug the hw device at the correct time, and use the other wizard to trigger a rescan.
The rescan will unpair the hw device, resulting in device_manager.client_by_id to return None when
continuing the flow on the first wizard.

fixes https://github.com/spesmilo/electrum/issues/8858
 2024-01-31 04:02:02 +00:00
SomberNight
67b57da402 qml: WCHaveMasterKey: (fix) re-verify text in onTextChanged 
fixes https://github.com/spesmilo/electrum/issues/8853

This is a bit ugly, but activeFocus is declared as final and cannot be overridden directly...
```
  1.42 | W | gui.qml.qeapp | file:///home/user/wspace/electrum/electrum/gui/qml/components/controls/ElTextArea.qml:23:5: Cannot override FINAL property
```
 2024-01-30 02:11:01 +00:00
SomberNight
522e9485c1 text gui: rm some magic numbers (ascii key codes), and small clean-up 2024-01-23 23:43:08 +00:00
SomberNight
cd3be429e4 qt: PayToEdit: always use monospace font 2024-01-23 00:49:03 +00:00
Sander van Grieken
50a53aaedc qml: handle 2fa wallet can have None for billing_info 2024-01-22 13:30:46 +01:00
SomberNight
43a5d03426 qt: coins tab: also define sort order for coins mined in same block 
follow-up 0f55a1e309
 2024-01-19 14:34:33 +00:00
Sander van Grieken
9518bd0e68 qt: replace timer based delayed call with a less confusing event loop queued call 2024-01-19 14:57:55 +01:00
Sander van Grieken
17147732fb qt: fix macOS workaround introducing race 2024-01-19 14:54:23 +01:00
SomberNight
9fd16cd677 follow-up prev 2024-01-19 13:19:44 +00:00
SomberNight
0f55a1e309 qt: coins tab: properly sort unconfirmed/local utxos to top 2024-01-19 13:12:36 +00:00
Sander van Grieken
1f5004320b qt: re-add processEvents() calls for abstract wizard. 
might work around #8809/#8815
 2024-01-18 17:55:52 +01:00
Sander van Grieken
55a2005a6b qml: update history view after address/key delete. fixes #8782 2024-01-18 00:28:02 +01:00
SomberNight
49c3567d7d wallet: simplify bump_fee: rm txid arg 
closes https://github.com/spesmilo/electrum/issues/8797
 2024-01-17 19:20:29 +00:00
SomberNight
4a82072443 qt: new_channel_dialog: init USE_RECOVERABLE_CHANNELS cb intuitively 
if `not lnworker.can_have_recoverable_channels()`,
- previously: the cb was disabled and checked
- now: the cb is disabled and unchecked
 2024-01-17 14:13:20 +00:00