Commit Graph

7421 Commits

Author SHA1 Message Date
SomberNight
85ffbfc83f prepare release 4.5.4 2024-03-13 12:53:44 +00:00
SomberNight
4a71032318 swaps: expand docstring for reverse_swap 2024-03-13 12:27:10 +00:00
SomberNight
58a1bdfec7 lnworker.check_mpp_status: add docstring
This explains why stopping_soon behaves sanely with hold-invoice-htlcs.
2024-03-12 15:28:31 +00:00
SomberNight
af6a1f3d01 swaps: use longer final_cltv_delta for client-normal-swap
This gives more time for the client to come back online.

see https://github.com/spesmilo/electrum/issues/8940

- re note on submarine_swaps.py#L53:
  lnpeer.Peer.maybe_fulfill_htlc only checks against MIN_FINAL_CLTV_DELTA_ACCEPTED(=144),
  so this increased cltv_delta is not enforced when receiving the htlc on ln.
  It is put in the invoice, so the sender is supposed to honour it ofc.
  It would be nice to enforce it (make the check in maybe_fulfill_htlc dependent on
  what was in the invoice).
2024-03-12 14:20:52 +00:00
st3b1t
9ad6688ce7 trt removed 2024-03-05 23:30:23 +01:00
ThomasV
8b2a596194 Merge pull request #8925 from SomberNight/202403_simplify_chan_dict
walletdb: chan dict: small clean-up (incl db upgrade)
2024-03-05 10:00:45 +01:00
SomberNight
30c9f5b6b1 walletdb: chan dict: small clean-up (incl db upgrade)
- "fail_htlc_reasons" was removed in 9b1c40e396
- "unfulfilled_htlcs": rm 2 dead items from the 4-tuple,
   and convert False value of forwarding_key
2024-03-01 16:28:46 +00:00
ThomasV
f6312366e6 swapserver: raise exception if client uses deprecated API 2024-03-01 17:25:37 +01:00
SomberNight
0faadc0469 lnpeer: fix some type hints
related https://github.com/spesmilo/electrum/pull/8924

note: "forwarding_key" can be stored as False. I think this is ugly and
might be better to do a storage upgrade to change those values to None.
2024-03-01 15:47:08 +00:00
ThomasV
c6802adbae qt wizard: set focus on next_button 2024-03-01 16:42:16 +01:00
ThomasV
fde5f5b9b7 lnpeer: fix #8825
In maybe_fulfill_htlc, return two items: (preimage, (payment_key, callback)).

Rationale: The caller needs a payment_key only if we return a callback.
If we do not, the caller should use the payment_key that was previously
stored in channel.unfulfilled_htlcs

Note that for trampoline onions, payment_key may contain the inner
or outer secret.
2024-03-01 14:53:10 +01:00
accumulator
d120492664 Merge pull request #8921 from levantah/levantah/del_bublina
Remove bublina Signet
2024-03-01 11:56:34 +01:00
Ahmed Levant
2dcffd1ef2 Remove bublina Signet
Fixes #8920
2024-03-01 11:21:49 +01:00
Sander van Grieken
b11d0062e8 wizard: log state when view not defined. ref #8815 2024-03-01 10:56:32 +01:00
Sander van Grieken
d6ea2f1e30 wizard: log state when view not defined. ref #8916 2024-03-01 09:07:04 +01:00
SomberNight
d6ef53dfab qt: fix some strings for localization
closes https://github.com/spesmilo/electrum/issues/8919
2024-02-28 13:40:01 +00:00
SomberNight
51b7fc04ef walletdb: fix convert_version_58 for partial local txs
The transaction dict can also contain PSBTs (in addition to complete raw hex txs).
This is the case if the user has saved a partial (e.g. unsigned) tx as local into the history.

fixes https://github.com/spesmilo/electrum/issues/8913
2024-02-26 18:54:21 +00:00
ThomasV
777c2ffb23 create a trampoline onion when directly paying a trampoline node 2024-02-24 16:01:31 +01:00
SomberNight
85ea2dfc48 trezor: add_slip_19_ownership_proofs_to_tx to not skip complete inputs
closes https://github.com/spesmilo/electrum/issues/8910
2024-02-23 12:50:25 +00:00
Sander van Grieken
d0c37c6e33 qml: refactor help text in CpfpBumpFeeDialog, move most to help text popup 2024-02-23 11:11:12 +01:00
Sander van Grieken
b0227c7e03 qml: add HelpDialog and HelpButton for showing additional info 2024-02-23 10:28:11 +01:00
SomberNight
5e472117df gui: more hardcoded bytes vs vbytes strings
follow-up a9a8ed2eb4
2024-02-22 17:40:35 +00:00
SomberNight
d01582d58c fix tests (follow-up)
follow-up 197979063a
2024-02-22 12:26:25 +00:00
Sander van Grieken
70b9ea2639 prepare release 4.5.3 2024-02-22 12:15:01 +00:00
SomberNight
197979063a lnworker: log gossip_db status in pay_invoice 2024-02-22 12:11:23 +00:00
SomberNight
b4712397cc logging: (trivial) use repr() of seed_type
for more obvious empty string

related: https://github.com/spesmilo/electrum/issues/4326#issuecomment-1903747632
2024-02-22 11:45:18 +00:00
SomberNight
4be90eb15a update block header checkpoints 2024-02-22 11:31:06 +00:00
ThomasV
7ff3a0feff submarine swaps: fail htlc with INCORRECT_OR_UNKNOWN_PAYMENT_DETAILS
If the sender uses trampoline, UNKNOWN_NEXT_PEER causes them to
retry, while INCORRECT_OR_UNKNOWN_PAYMENT_DETAILS breaks the loop.
2024-02-22 10:11:34 +01:00
ghost43
7da3613b12 Merge pull request #8906 from accumulator/old_2fa_passphrase
wizard: skip/hide passphrase option for 'old' and '2fa' seeds (see #4326)
2024-02-21 17:03:43 +00:00
accumulator
d52e36e29e Merge pull request #8846 from SomberNight/202401_gui_text_vendor_pyperclip
dependencies: vendor "pyperclip" pkg, used by text gui
2024-02-21 17:30:19 +01:00
Sander van Grieken
8ce1e6453b wizard: skip/hide passphrase option for 'old' and '2fa' seeds (see #4326) 2024-02-21 17:15:10 +01:00
SomberNight
8ab3dcce5d keystore: API changes for from_seed/from_bip43_rootseed/bip39_to_seed
- force kwargs
- add type hints
2024-02-21 15:08:19 +00:00
SomberNight
96f28607f2 keystore: "old"-type seeds cannot have a passphrase
related: https://github.com/spesmilo/electrum/pull/8906
2024-02-21 14:30:13 +00:00
Sander van Grieken
da1727b2f7 trustedcoin: validate numeric format of OTP user entry (fixes #8905) 2024-02-21 13:33:46 +01:00
ThomasV
9799603779 Merge pull request #8888 from SomberNight/202402_jsonrpc_errors
cli/rpc: nicer error messages and error-passing
2024-02-21 13:20:28 +01:00
ThomasV
e2db5ca2ef Merge pull request #8871 from SomberNight/202402_slip19_trezor
support SLIP-19 ownership proofs, for trezor-based Standard_Wallets
2024-02-21 13:06:28 +01:00
SomberNight
a749fd7789 qt tx_dialog: share btn: add option to add slip-19 ownership proofs 2024-02-21 11:58:52 +00:00
SomberNight
b7ed016f3c qt tx_dialog: share btn: replace nested menus with checkboxes
Incidentally, the checkboxes are using the config, so their state is persisted.
2024-02-21 11:56:18 +00:00
SomberNight
0925f15280 wallet/keystore: add apis for "add_slip_19_ownership_proofs_to_tx"
- implement it specifically for the "singlesig trezor" case
- aimed to be generic enough that support for more complex scripts
  and other keystores could be added later
2024-02-21 11:56:13 +00:00
Sander van Grieken
dc3ff908b8 followup prev 2024-02-21 12:03:37 +01:00
Sander van Grieken
d12ce00417 followup prev 2024-02-21 11:28:42 +01:00
Sander van Grieken
6d2dfc9759 android: limit size of text pasted from clipboard, to avoid TransactionTooLargeException
https://developer.android.com/reference/android/os/TransactionTooLargeException.html
2024-02-21 11:22:00 +01:00
Sander van Grieken
de9c0249c7 qml: icons, styling 2024-02-19 14:38:29 +01:00
accumulator
d968c6245c Merge pull request #8897 from accumulator/move_tests_to_root
tests: move /electrum/tests to /tests
2024-02-19 10:51:42 +01:00
Sander van Grieken
2b95223e2b qml: handle invoice removed from backend from qeinvoicelistmodel status update timer (fixes #8898) 2024-02-19 10:48:24 +01:00
Sander van Grieken
ef87fbd3e5 payment_identifier: return onchain invoice when GUI requests MAX amount (fixes #8900) 2024-02-19 10:35:55 +01:00
Sander van Grieken
73fee69f5c tests: move /electrum/tests to /tests 2024-02-16 15:40:45 +01:00
ghost43
e11d7b37f2 Merge pull request #8865 from SomberNight/202402_server_bookmarks
network: implement basic "add server as bookmark" functionality
2024-02-16 12:06:18 +00:00
accumulator
1b75e3883e Merge pull request #8845 from accumulator/feepicker
qml: consolidate fee slider ui in various places to a single FeePicker control
2024-02-16 13:01:34 +01:00
Sander van Grieken
016e500993 qml: FeePicker parameterize enable display of tx info and picker, use this for CPFP
to put picker in Total section
2024-02-16 12:56:18 +01:00