Sander van Grieken
d0c37c6e33
qml: refactor help text in CpfpBumpFeeDialog, move most to help text popup
2024-02-23 11:11:12 +01:00
Sander van Grieken
b0227c7e03
qml: add HelpDialog and HelpButton for showing additional info
2024-02-23 10:28:11 +01:00
ghost43
7da3613b12
Merge pull request #8906 from accumulator/old_2fa_passphrase
...
wizard: skip/hide passphrase option for 'old' and '2fa' seeds (see #4326 )
2024-02-21 17:03:43 +00:00
Sander van Grieken
8ce1e6453b
wizard: skip/hide passphrase option for 'old' and '2fa' seeds (see #4326 )
2024-02-21 17:15:10 +01:00
SomberNight
8ab3dcce5d
keystore: API changes for from_seed/from_bip43_rootseed/bip39_to_seed
...
- force kwargs
- add type hints
2024-02-21 15:08:19 +00:00
Sander van Grieken
dc3ff908b8
followup prev
2024-02-21 12:03:37 +01:00
Sander van Grieken
d12ce00417
followup prev
2024-02-21 11:28:42 +01:00
Sander van Grieken
6d2dfc9759
android: limit size of text pasted from clipboard, to avoid TransactionTooLargeException
...
https://developer.android.com/reference/android/os/TransactionTooLargeException.html
2024-02-21 11:22:00 +01:00
Sander van Grieken
de9c0249c7
qml: icons, styling
2024-02-19 14:38:29 +01:00
Sander van Grieken
2b95223e2b
qml: handle invoice removed from backend from qeinvoicelistmodel status update timer ( fixes #8898 )
2024-02-19 10:48:24 +01:00
accumulator
1b75e3883e
Merge pull request #8845 from accumulator/feepicker
...
qml: consolidate fee slider ui in various places to a single FeePicker control
2024-02-16 13:01:34 +01:00
Sander van Grieken
016e500993
qml: FeePicker parameterize enable display of tx info and picker, use this for CPFP
...
to put picker in Total section
2024-02-16 12:56:18 +01:00
Sander van Grieken
c0b892720e
qml: consolidate fee slider ui in various places to a single FeePicker control
2024-02-16 10:09:56 +01:00
Sander van Grieken
3582c79160
stub QVideoSink import as it requires many dependencies but isn't used on android currently
2024-02-12 11:49:43 +01:00
Sander van Grieken
19d9467b93
qml: add typing declarations to qechanneldetails
2024-02-07 10:53:10 +01:00
accumulator
acc7b44a3e
Merge pull request #8873 from accumulator/issue_8355
...
qml: tighten self._loading guard to encompass whole loadWallet fn
2024-02-06 13:55:26 +01:00
Sander van Grieken
482ec89b5d
minor, code style, imports
2024-02-05 21:25:13 +01:00
Sander van Grieken
4228911609
qml: close TxDetails on TX remove only after the 'removed_transaction' event has been received, so the
...
history model doesn't refresh too early (fixes #8782 )
2024-02-05 21:07:33 +01:00
Sander van Grieken
c755a58661
qedaemon: remove redundant, small code style fixes
2024-02-05 18:07:12 +01:00
Sander van Grieken
5aa782a19e
qml: extend self._loading guard to encompass _on_backend_wallet_loaded slot as well
2024-02-05 17:59:44 +01:00
Sander van Grieken
b361d02467
qml: tighten self._loading guard to encompass whole loadWallet fn, not just task thread.
...
Also make sure QEWallet is never instantiated within the task thread.
2024-02-05 17:41:56 +01:00
Sander van Grieken
0a6b2d521b
qml: move final wizard submit() to WizardComponent.finish handler
2024-02-05 11:13:58 +01:00
accumulator
019baa5a71
Merge pull request #8862 from SomberNight/202401_qml_wizard_final_accept
...
qml wizard: run navmap[view]['accept'] handler a final time on finish
2024-02-05 10:46:22 +01:00
SomberNight
07dc80dd9a
qml wizard: stricter validation for new wallet name
...
user on bitcointalk [0] tried to create wallet with name "w/o 2FA".
Before this, one would only get an error after the last page of the wizard.
With this, the "Next" button does not even get enabled if the name does not look ok.
(and as in comment, maybe we should be even stricter re what is allowed)
[0]: https://bitcointalk.org/index.php?topic=5483514.msg63584789#msg63584789
2024-02-04 08:54:40 +00:00
SomberNight
a9a8ed2eb4
follow-up: factor out more hardcoded "sat/byte" and "sat/b" strings
...
- rename globals
- also rm hardcoded strings from qml
- use consistent unit names in qml
(previously mixed sat/vB and sat/byte (latter coming from core lib))
2024-02-03 05:26:31 +00:00
SomberNight
16eec8daf5
qml QEChannelDetails: show currentFeerate
...
related https://github.com/spesmilo/electrum/issues/8863
2024-02-03 03:43:16 +00:00
SomberNight
d7a9e2d022
qml QEChannelDetails: add some type hints
2024-02-03 03:35:54 +00:00
SomberNight
48a96f6776
qml wizard: run navmap[view]['accept'] handler a final time on finish
...
For example, see
061c821128/electrum/plugins/trustedcoin/trustedcoin.py (L624)
Even if navmap[view]['last'] is True, we still want the navmap[view]['accept'] handler to run.
fixes https://github.com/spesmilo/electrum/issues/8861
---
Note that an analogous issue does not exist for the desktop qt gui,
see 061c821128/electrum/gui/qt/wizard/wizard.py (L206)
There, wizard.resolve_next is called regardless of is_last.
2024-01-31 12:59:47 +00:00
SomberNight
cb55c65677
qml wizard: WCWalletPassword: show warning if pw is too short
2024-01-31 10:28:10 +00:00
SomberNight
67b57da402
qml: WCHaveMasterKey: (fix) re-verify text in onTextChanged
...
fixes https://github.com/spesmilo/electrum/issues/8853
This is a bit ugly, but activeFocus is declared as final and cannot be overridden directly...
```
1.42 | W | gui.qml.qeapp | file:///home/user/wspace/electrum/electrum/gui/qml/components/controls/ElTextArea.qml:23:5: Cannot override FINAL property
```
2024-01-30 02:11:01 +00:00
Sander van Grieken
50a53aaedc
qml: handle 2fa wallet can have None for billing_info
2024-01-22 13:30:46 +01:00
Sander van Grieken
55a2005a6b
qml: update history view after address/key delete. fixes #8782
2024-01-18 00:28:02 +01:00
SomberNight
49c3567d7d
wallet: simplify bump_fee: rm txid arg
...
closes https://github.com/spesmilo/electrum/issues/8797
2024-01-17 19:20:29 +00:00
Sander van Grieken
e2bb7df54a
qml: invert, more strict check in determine_can_pay for invoice types,
...
also disable paste button while PI is being evaluated
2024-01-17 14:09:57 +01:00
Sander van Grieken
4469e9989d
qml: LNURLp has no bolt11 to query until later. fixes #8822
2024-01-17 13:52:01 +01:00
SomberNight
248e50eed0
transaction: rename tx.is_final to tx.is_rbf_enabled, and invert it
2024-01-17 02:08:15 +00:00
Sander van Grieken
291f0ce235
qml: handle exception more gracefully when attempting to delete last address from imported wallet
2024-01-16 15:56:49 +01:00
Sander van Grieken
10be631039
qml: tx.txid() can be None in qetxfinalizer. fixes ( #8807 )
2024-01-13 01:36:45 +01:00
ThomasV
14ec36dba1
Merge pull request #8741 from accumulator/labels_update
...
add labels_received callback and update labels even when set for item
2024-01-11 16:05:04 +01:00
Sander van Grieken
65210d03ac
qml: log txid when assertion fails in qetxdetails.py
2024-01-09 12:57:26 +01:00
accumulator
35d4cf4d09
Merge pull request #8788 from accumulator/qml_non_historic_fiat
...
qml: don't show fiat amount when timestamp more than a day old and historic rates are disabled
2024-01-04 17:31:16 +01:00
accumulator
a51b3bdbfb
qml: show fiat price when historic rates are enabled and no timestamp available
...
Co-authored-by: ghost43 <somber.night@protonmail.com >
2024-01-04 17:31:00 +01:00
Sander van Grieken
313b79cfaf
qml: add txid not empty assert to removeLocalTx. ref #8775
2024-01-04 13:08:17 +01:00
Sander van Grieken
5077e013f3
qml: don't show fiat amount when timestamp more than a day old and historic rates are disabled
2024-01-04 12:25:40 +01:00
accumulator
88058df409
Merge pull request #8772 from accumulator/qml_tx_inputs
...
qml: add transaction inputs in TxDetails and …
2023-12-29 16:21:22 +01:00
Sander van Grieken
92bff08ba5
qml: don't use predictive text for fields where it makes no sense
2023-12-29 16:18:03 +01:00
Sander van Grieken
e8852918a7
qml: fix newline in TxDetails
2023-12-29 12:13:49 +01:00
Sander van Grieken
7164392b1c
qml: add transaction inputs in TxDetails and ConfirmTxDialog, RbfBumpFeeDialog, RbfCancelDialog, CpfpBumpFeeDialog
...
and allow collapse/expand of input/output lists by clicking on label.
2023-12-29 11:55:36 +01:00
SomberNight
eee61a98cb
gui: cpfp: calc parent fee for cpfp using wallet.get_tx_info
...
I am only making this change as it makes it simpler to do manual testing of CPFP-ing *local* txs.
That is, by changing a few easy-to-find lines of code, I can make the GUI allow CPFP-ing a local tx, but
without this change it errors out with "unknown fee for parent transaction".
If one has an incoming local tx saved in the wallet, adb.get_tx_fee(txid) returns None
(if the tx gets into the mempool, it will use the server-reported value instead).
In contrast, wallet.get_tx_info(tx).fee calls both wallet.get_wallet_delta(tx) and adb.get_tx_fee(txid),
making it more expensive but more complete.
2023-12-29 02:55:11 +00:00
Sander van Grieken
ceb42c2a1b
qml: show frozen lightning balance in BalanceDetails only when non-zero
2023-12-28 12:30:37 +01:00