Sander van Grieken
e3ccee6d63
qt: channel closed dialog is not an error
2025-06-05 12:37:23 +02:00
ThomasV
e8113d684c
Merge pull request #9852 from accumulator/qml_fix_forceclose_exception
...
qml: fix assumption history item is onchain when history item has no timestamp
2025-06-05 09:58:48 +02:00
f321x
5ad1b4b5dd
fix: exceptions with send change to lightning
2025-06-04 17:40:04 +02:00
ThomasV
2024fa4507
Merge pull request #9902 from SomberNight/202506_base64_trailing_garbage
...
base64.b64decode: always set validate=True
2025-06-04 14:59:20 +02:00
f321x
6c7d8e8f86
fix: prevent opening new window if ToU haven't been accepted
...
prevents the creation of new Qt windows if the terms of use have not
been accepted yet. This is to prevent bypassing the terms of use by
starting the wallet a second time which would then skip the ToU.
2025-06-04 09:48:00 +02:00
SomberNight
3e4601c61d
base64.b64decode: always set validate=True
...
Notably verifymessage and decrypt(message) were silently ignoring trailing garbage
or inserted non-base64 characters present in signatures/ciphertext.
(both the CLI commands and in the GUI)
I think it is much cleaner and preferable to treat such signatures/ciphertext as invalid.
In fact I find it surprising that base64.b64decode(validate=False) is the default.
Perhaps we should create a helper function for it that set validate=True and use that.
2025-06-03 18:58:05 +00:00
SomberNight
902ec09791
daemon: re config.CURRENT_WALLET: wallet_key MUST NOT be used as path
2025-06-03 15:08:03 +00:00
ThomasV
6373269b42
Merge pull request #9895 from accumulator/qml_network_settings_update_fix
...
qml: fix updating network settings
2025-06-03 14:43:43 +02:00
Sander van Grieken
7df2a1159b
qml: fix updating network settings
...
Previously the server parameters were each handled differently, e.g. auto-connect was only applied when updating Network.server
and not when Config.autoConnect was updated. Similarly, updating Network.server did not restart the network, leading to >1 connection
when Network.oneServer was set to True before updating Network.server.
Consolidate server parameter updates into a single call, remove the individual setters, and move Config.autoConnect and Config.autoConnectDefined to Network.
2025-06-03 13:22:45 +02:00
ThomasV
69527df9d6
Merge pull request #9894 from f321x/remove_sending_balance_warning
...
qml: rm small available sending balance warning
2025-06-03 12:59:58 +02:00
ThomasV
e26160234c
network_dialog: widget reordering
2025-06-03 12:56:01 +02:00
f321x
88a77f387d
qml: rm small available sending balance warning
2025-06-03 12:30:52 +02:00
ThomasV
8f2c5f60e4
Merge pull request #9888 from accumulator/qml_fixes
...
Qml fixes
2025-06-03 11:11:29 +02:00
Sander van Grieken
cb78b07fe4
qml: reset nostr relays list to default if empty
2025-06-03 10:57:43 +02:00
ThomasV
1dc9ffcdaf
Merge pull request #9892 from accumulator/fix_9884
...
qml: also update userinfo text on channel events. fixes #9884
2025-06-03 10:57:03 +02:00
ThomasV
0ce03a1939
Merge pull request #9889 from f321x/fix_suggest_peer_block
...
fix: prevent lnrater from blocking if no good peers
2025-06-03 10:54:13 +02:00
Sander van Grieken
d87b0f8e81
qml: improve nostr dialog helptext
2025-06-03 10:50:28 +02:00
Sander van Grieken
7ba335a409
qml: also update userinfo text on channel events. fixes #9884
2025-06-03 10:41:55 +02:00
f321x
b4e93e7e38
fix: prevent lnrater from blocking if no good peers
...
the while loop in `suggest_node_channel_open()` of lnrater would not
break if there are no "good" peers available available. As a result the gui
blocks and electrum has to be killed. This can happen for example on
signet.
This removes the tested pk from the list of candidates so each candidate
gets tested only once.
2025-06-03 10:06:39 +02:00
SomberNight
60ef0340bb
messages.py: fix typo
2025-06-02 16:07:08 +00:00
Sander van Grieken
c6fb55d416
qml: lightningpaymentdetails show Paid banner instead of just Status:settled
2025-06-02 17:21:42 +02:00
Sander van Grieken
df2c1d6ae1
qml: no feebump hint if only option is CPFP
2025-06-02 17:14:31 +02:00
Sander van Grieken
938af7b2ee
qml: remove green check-mark on request paid, open lightning payment details (LN) or Tx details (on-chain) instead
2025-06-02 17:11:08 +02:00
f321x
58b0fdf199
followup 9e225d1: rm save_last_wallet call
2025-06-02 15:07:22 +02:00
ThomasV
9e225d1269
Replace config GUI_LAST_WALLET with CURRENT_WALLET
...
- CURRENT_WALLET is set when a single wallet is loaded in memory, and it
remains set after Electrum stops running.
- If several wallets are loaded at the same time, CURRENT_WALLET is unset,
and RPCs must specify the wallet explicitly (using --wallet for the CLI)
- The fallback to 'default_wallet' essentially only applies when
creating a new wallet file
2025-06-02 14:05:53 +02:00
Sander van Grieken
5775fd790e
qml: remove request from list once paid
2025-06-02 13:47:49 +02:00
Sander van Grieken
5fe6ff3a1f
qml: nostr relay dialog, remove help button, move text into dialog.
2025-06-02 13:42:12 +02:00
Sander van Grieken
b5170a3fa6
qml: oneserver, auto-connect combobox
2025-06-02 13:31:05 +02:00
ThomasV
c8ea5b6173
Third-party plugins: expand warning message
...
Remove lightning is experimental warning
2025-06-02 12:58:40 +02:00
Sander van Grieken
30d6228cac
qml: remove nostr relays from NetworkOverview.qml
2025-06-02 11:52:44 +02:00
ThomasV
cea4b99668
qt: on_event_payment_failed: remove onchain fallback dialog
...
We no longer create LN invoices with onchain fallbacks. Even if
other implementation might create such invoices, there is little
point suporting them.
2025-05-31 14:12:28 +02:00
ThomasV
b78935521b
network dialog: replace checkboxes with tri-state connect_mode ComboBox
...
If oneserver is enabled, display 'Fork detection disabled' in the split_label
2025-05-29 20:14:03 +02:00
ThomasV
fb9e300165
Merge pull request #9824 from accumulator/qml_bip21_request_if_label_or_amount
...
invoices: only skip generating BIP21 URI for payment request if both …
2025-05-28 11:05:34 +02:00
ThomasV
b110179409
fix #9870
2025-05-28 10:42:59 +02:00
ThomasV
49d2f87dcf
wizard: make NewWalletWizard inherit from KeystoreWizard
2025-05-28 10:20:15 +02:00
SomberNight
329ba13093
gui: oneserver option: make text more verbose
2025-05-27 17:17:17 +00:00
ThomasV
e1ac476bcf
KeystoreWizard: support seed extension
2025-05-26 10:35:41 +02:00
ThomasV
51ced92f44
Qt: let user enable/disable keystores with seed or hw wallet
2025-05-24 11:18:07 +02:00
ThomasV
553aef519b
Qt wizard: clean up first page a bit
2025-05-24 11:00:18 +02:00
ThomasV
45c35c0b00
allow password encryption in hardware wallets
2025-05-23 18:42:54 +02:00
Sander van Grieken
ed17a6b1da
qml: fix assumption history item is onchain when history item has no timestamp.
2025-05-21 18:34:04 +02:00
ThomasV
8d5d330b07
Merge pull request #9243 from accumulator/qml_oneserver
...
qt,qml: show option for single server in ServerConfig
2025-05-21 12:04:56 +02:00
Sander van Grieken
de30c6139c
text: fix _ string
2025-05-21 11:55:44 +02:00
accumulator
705f927899
qt: show option for single server in network dialog
2025-05-21 10:32:18 +02:00
ThomasV
bae7f2490d
Merge pull request #9846 from accumulator/qt_paytoedit_completer
...
qt: implement completer for PayToEdit
2025-05-21 09:52:57 +02:00
Sander van Grieken
b0c6674319
qt: implement completer for PayToEdit
2025-05-20 15:28:55 +02:00
ThomasV
713a20e309
Merge pull request #9833 from f321x/use_asyncio_dnspython_methods
...
dns: use async dnspython interface
2025-05-20 08:56:47 +02:00
Sander van Grieken
1dfe2ccec0
qml: show option for single server in ServerConfig
2025-05-19 18:07:29 +02:00
ThomasV
8396a22286
Merge pull request #9801 from SomberNight/202505_ban_unicode
...
ci: add linter task "ban unicode" to protect against malicious unicode
2025-05-19 15:02:45 +02:00
Sander van Grieken
000b1bb3b5
swaps: update instructions in manifest, add Max Forward and Max Reverse amounts in qml provider picker
2025-05-19 14:55:34 +02:00
