pallectrum/electrum at d3227d7489fe327bd40e891a517c86bd207227ec - pallectrum - Gitea: Git with a cup of tea

davide/pallectrum

Files

History

SomberNight d3227d7489 transaction: for witness v0 txins, put both UTXO and WIT_UTXO in psbt

Until now we have been only putting PSBT_IN_NON_WITNESS_UTXO (="UTXO", full tx)
in segwit witness v0 txins, as signers wanted the full tx anyway due to
bip-143 sighash issue [0], and as WITNESS_UTXO can be calculated from UTXO.

My reading of bip-174 is that either behaviour is correct, but
achow101 said bip-174 expects PSBT_IN_WITNESS_UTXO for segwit inputs.
Regardless, including both fields does not increase the tx size too much
(UTXO can be very large ofc but we were already including that, WIT_UTXO is small).
This also might increase compatibility with some other software - I've found
some issues where this might have been the culprit [1][2][3].

closes https://github.com/spesmilo/electrum/issues/8039

related:
[0] https://github.com/spesmilo/electrum/pull/6198
[1] https://github.com/cryptoadvance/specter-desktop/issues/868
[2] https://github.com/cryptoadvance/specter-desktop/issues/1046
[3] https://github.com/cryptoadvance/specter-desktop/issues/1544

2022-10-31 17:14:21 +00:00

..

…

flake8: enable more mandatory tests

2022-10-31 16:13:22 +00:00

…

flake8: enable more mandatory tests

2022-10-31 16:13:22 +00:00

…

flake8: enable more mandatory tests

2022-10-31 16:13:22 +00:00

transaction: for witness v0 txins, put both UTXO and WIT_UTXO in psbt

2022-10-31 17:14:21 +00:00

Fix CRLF issues. (#8026 )

2022-10-20 18:43:54 +00:00

__init__.py

…

address_synchronizer.py

AddressSynchronizer: set diagnostic_name for better logs

2022-08-24 11:05:01 +00:00

base_crash_reporter.py

…

base_wizard.py

…

bip32.py

…

bip39_recovery.py

…

bip39_wallet_formats.json

…

bitcoin.py

…

blockchain.py

…

channel_db.py

…

checkpoints_testnet.json

update block header checkpoints

2022-08-17 11:29:04 +00:00

checkpoints.json

update block header checkpoints

2022-08-17 11:29:04 +00:00

coinchooser.py

flake8: enable more mandatory tests

2022-10-31 16:13:22 +00:00

commands.py

follow-up prev: indentations should not use tabs in *.py

2022-10-31 15:26:27 +00:00

constants.py

…

contacts.py

flake8: enable more mandatory tests

2022-10-31 16:13:22 +00:00

crypto.py

keystore.check_password: raise better exc if called on pwless ks

2022-07-12 15:50:45 +02:00

currencies.json

Add yadio.io api to exchange rate

2022-09-26 17:11:08 +02:00

daemon.py

daemon: better error msg if rpchost/rpcport is badly configured

2022-10-29 03:14:12 +00:00

dns_hacks.py

…

dnssec.py

…

ecc_fast.py

…

ecc.py

…

electrum

…

exchange_rate.py

Add yadio.io api to exchange rate

2022-09-26 17:11:08 +02:00

i18n.py

…

interface.py

…

invoices.py

invoices: fix is_paid for zero-amount onchain pay reqs

2022-10-19 16:15:12 +00:00

json_db.py

…

keystore.py

transaction: never put ypub/zpub in psbts, only plain xpubs

2022-10-27 16:03:05 +00:00

lnaddr.py

flake8: enable more mandatory tests

2022-10-31 16:13:22 +00:00

lnchannel.py

lnworker: define use_trampoline() for code clarity

2022-09-19 17:43:13 +02:00

lnhtlc.py

Fix CTNs in should_be_closed_due_to_expiring_htlcs (fixes #7906 ).

2022-08-02 18:00:39 +02:00

lnmsg.py

…

lnonion.py

…

lnpeer.py

cleanup old non-static_remotekey code (follow-up 1f403d1ca1)

2022-09-23 11:25:49 +02:00

lnrater.py

…

lnrouter.py

lnworker: fix stuck payment loop (fixes #7995 )

2022-10-04 10:51:18 +02:00

lnsweep.py

fix #7959

2022-08-31 11:03:04 +02:00

lntransport.py

…

lnurl.py

lnurl: add support for comments (LNURL12)

2022-09-30 14:01:18 +02:00

lnutil.py

Remove old trampoline compatibility bits from invoices

2022-09-29 12:06:49 +02:00

lnverifier.py

…

lnwatcher.py

AddressSynchronizer: set diagnostic_name for better logs

2022-08-24 11:05:01 +00:00

lnworker.py

add invoice status to invoice_status callback (#8020 )

2022-10-21 16:45:12 +00:00

logging.py

android: add setting to enable debug logs

2022-10-07 20:28:52 +00:00

mnemonic.py

…

mpp_split.py

…

network.py

Update network.py

2022-07-22 13:01:21 +08:00

old_mnemonic.py

…

paymentrequest_pb2.py

…

paymentrequest.proto

…

paymentrequest.py

…

pem.py

flake8: enable more mandatory tests

2022-10-31 16:13:22 +00:00

plot.py

…

plugin.py

dependencies: bundle older hidapi in binaries

2022-08-04 21:47:50 +02:00

qrscanner.py

…

ripemd.py

flake8: enable more mandatory tests

2022-10-31 16:13:22 +00:00

rsakey.py

flake8: enable more mandatory tests

2022-10-31 16:13:22 +00:00

segwit_addr.py

…

servers_regtest.json

…

servers_signet.json

…

servers_testnet.json

…

servers.json

remove ca.poiuty.com (#7913 )

2022-08-03 14:03:27 +00:00

simple_config.py

make it easier to troubleshoot config parse errors

2022-10-24 17:51:57 +02:00

slip39.py

…

sql_db.py

…

storage.py

create chmod aware of XDG_RUNTIME_DIR

2022-08-09 19:04:17 +02:00

submarine_swaps.py

…

synchronizer.py

…

trampoline.py

follow-up previous commit

2022-09-29 12:13:22 +02:00

transaction.py

transaction: for witness v0 txins, put both UTXO and WIT_UTXO in psbt

2022-10-31 17:14:21 +00:00

util.py

aiorpcx: fix bug in timeout_after monkeypatch

2022-08-26 15:27:53 +00:00

verifier.py

…

version.py

prepare release 4.3.2

2022-09-26 20:13:45 +02:00

wallet_db.py

Index request by ID instead of receiving address.

2022-09-02 10:58:11 +02:00

wallet.py

transaction: for witness v0 txins, put both UTXO and WIT_UTXO in psbt

2022-10-31 17:14:21 +00:00

wizard.py

flake8: enable more mandatory tests

2022-10-31 16:13:22 +00:00

x509.py

…