Cap participants per round and give the payout its own input limit (B-52)
The payout has to spend one pool UTXO per bet, so reusing MAX_TX_INPUTS (50) for it made any round past ~50 players unpayable: select_utxos raised too_many_inputs, the round stayed "paying_out" retrying every 60s forever, and since no new round may open while one is active, the whole lottery stopped with the pool stuck. The cap was being enforced on the payout side, i.e. discovered once the money was already committed and there was no way back. Two halves: - select_utxos takes the cap as a parameter. Bets and withdrawals keep MAX_TX_INPUTS = 50, which protects a user from a fee that eats into the amount they are moving; the payout uses MAX_PAYOUT_TX_INPUTS = 500, where that argument doesn't apply — 400 inputs at 1 sat/vB cost ~0.00027 PLM out of the winner's 70% share. What actually bounds it is relay policy: 500 inputs is ~34 kvB against the 100 kvB standardness limit, and signing that many measures ~0.4s, once per round, inside a background task. - place_bet refuses the 401st bet with a new round_full error (translated into all 7 languages), so "a round can always be paid out" is an invariant checked before any money moves. MAX_PARTICIPANTS_PER_ROUND sits below the input cap to leave the payout headroom for pool change from earlier rounds, and counts every participant row rather than only confirmed ones, since a failed bet frees a slot. A round already wedged past the old cap now pays out on the next retry tick. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
1 parent
99d7a1ee00
commit
025754c860
10 files changed
+311
-28
No files matched your search
@@ -5,6 +5,7 @@ from embit.transaction import Transaction
|
||||
|
||||
from app.wallet.plm_network import PLM_MAINNET
|
||||
from app.wallet.psbt_builder import (
|
||||
MAX_PAYOUT_TX_INPUTS,
|
||||
MAX_TX_INPUTS,
|
||||
InsufficientFundsError,
|
||||
Utxo,
|
||||
@@ -53,6 +54,33 @@ def test_select_utxos_allows_exactly_the_input_cap():
|
||||
assert total == 100_000 * MAX_TX_INPUTS
|
||||
|
||||
|
||||
def test_select_utxos_honours_a_caller_supplied_cap(): # B-52
|
||||
"""The cap is per-caller: MAX_TX_INPUTS protects a user from a fee eating into
|
||||
their own bet/withdrawal, while the payout needs MAX_PAYOUT_TX_INPUTS to be able
|
||||
to drain a pool holding one UTXO per bet at all."""
|
||||
utxos = [Utxo(f"{i:064x}", 0, 100_000) for i in range(MAX_TX_INPUTS + 10)]
|
||||
target = 100_000 * (MAX_TX_INPUTS + 10)
|
||||
|
||||
with pytest.raises(InsufficientFundsError):
|
||||
select_utxos(utxos, target_sats=target) # default cap: too fragmented
|
||||
|
||||
selected, total = select_utxos(utxos, target_sats=target, max_inputs=MAX_PAYOUT_TX_INPUTS)
|
||||
assert len(selected) == MAX_TX_INPUTS + 10
|
||||
assert total == target
|
||||
|
||||
|
||||
def test_select_utxos_still_caps_at_the_payout_limit(): # B-52
|
||||
utxos = [Utxo(f"{i:064x}", 0, 100_000) for i in range(MAX_PAYOUT_TX_INPUTS + 5)]
|
||||
with pytest.raises(InsufficientFundsError) as excinfo:
|
||||
select_utxos(
|
||||
utxos,
|
||||
target_sats=100_000 * (MAX_PAYOUT_TX_INPUTS + 1),
|
||||
max_inputs=MAX_PAYOUT_TX_INPUTS,
|
||||
)
|
||||
assert excinfo.value.code == "too_many_inputs"
|
||||
assert excinfo.value.params == {"max_inputs": MAX_PAYOUT_TX_INPUTS}
|
||||
|
||||
|
||||
def test_build_signed_transaction_deducts_fee_from_amount_not_change():
|
||||
signer = _key(1)
|
||||
from_script = script.p2wpkh(signer.to_public())
|
||||
|
||||
Reference in new issue
Block a user