Bound credentials, brake password changes, cap bug reports, page the user list, structure every error (B-94, SEC-54, SEC-55, API-09, API-15, API-16, API-19, API-21, API-28, API-33, REG-12, AUD-42)
- login and password-change fields: at most 256 characters
- wrong current password: per-user brake (5 free, 2s doubling to 300s), 429 even for the
right password while locked; password_changed audited in the same transaction
- POST /bug-reports: 10 per IP per hour, consumed only by a stored report
- GET /admin/users: limit/after_id paging, the panel walks the pages
- 401/403/404/405/422/503 all answer {code, message, params}; the 422 omits the input
- static files revalidated on every use (Cache-Control: no-cache)
- error.* keys for the new codes in all seven languages
Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
c1b192f6d1
commit
24e5fc3d8b
23 files changed
+374
-111
No files matched your search
+35
-1
@@ -3,8 +3,10 @@ import logging
|
||||
from contextlib import asynccontextmanager
|
||||
|
||||
from fastapi import FastAPI, Request, status
|
||||
from fastapi.exceptions import RequestValidationError
|
||||
from fastapi.responses import FileResponse, JSONResponse
|
||||
from fastapi.staticfiles import StaticFiles
|
||||
from starlette.exceptions import HTTPException as StarletteHTTPException
|
||||
|
||||
from app.logging_config import setup_logging
|
||||
|
||||
@@ -117,6 +119,28 @@ app.include_router(qr_router)
|
||||
app.include_router(rounds_router)
|
||||
|
||||
|
||||
# B-94 (API-15, API-16): no error answers with a bare-string or list `detail`; the framework's
|
||||
# own 401/404/405 and request-validation failures take the structured shape too.
|
||||
_FRAMEWORK_CODES = {401: "not_authenticated", 404: "not_found", 405: "method_not_allowed"}
|
||||
|
||||
|
||||
@app.exception_handler(StarletteHTTPException)
|
||||
async def structured_http_exception(request: Request, exc: StarletteHTTPException) -> JSONResponse:
|
||||
if isinstance(exc.detail, dict) and "code" in exc.detail:
|
||||
return JSONResponse(status_code=exc.status_code, content={"detail": exc.detail}, headers=exc.headers)
|
||||
code = _FRAMEWORK_CODES.get(exc.status_code, f"http_{exc.status_code}")
|
||||
detail = ApiError(code, str(exc.detail)).as_detail()
|
||||
return JSONResponse(status_code=exc.status_code, content={"detail": detail}, headers=exc.headers)
|
||||
|
||||
|
||||
@app.exception_handler(RequestValidationError)
|
||||
async def structured_validation_error(request: Request, exc: RequestValidationError) -> JSONResponse:
|
||||
"""`input` is left out on purpose: an over-long password must not come back in the response."""
|
||||
errors = [{"loc": list(e["loc"]), "msg": e["msg"], "type": e["type"]} for e in exc.errors()]
|
||||
detail = ApiError("invalid_request", "invalid request", errors=errors).as_detail()
|
||||
return JSONResponse(status_code=status.HTTP_422_UNPROCESSABLE_CONTENT, content={"detail": detail})
|
||||
|
||||
|
||||
@app.exception_handler(Exception)
|
||||
async def log_unhandled_exception(request: Request, exc: Exception) -> JSONResponse:
|
||||
"""Answers with the same structured `detail` shape as every deliberate failure
|
||||
@@ -157,4 +181,14 @@ async def report_bug_page() -> FileResponse:
|
||||
return FileResponse("app/static/report-bug.html", headers=_NO_STORE_HEADERS)
|
||||
|
||||
|
||||
app.mount("/", StaticFiles(directory="app/static", html=True), name="static")
|
||||
class NoCacheStaticFiles(StaticFiles):
|
||||
"""B-94 (API-09): the browser may keep a copy but revalidates it on every use, so after an
|
||||
update it does not run an old app.js against the new API."""
|
||||
|
||||
async def get_response(self, path, scope):
|
||||
response = await super().get_response(path, scope)
|
||||
response.headers["Cache-Control"] = "no-cache"
|
||||
return response
|
||||
|
||||
|
||||
app.mount("/", NoCacheStaticFiles(directory="app/static", html=True), name="static")
|
||||
Reference in new issue
Block a user