Snapshot a round's timing when it opens (B-61)
round_duration_seconds was read live on every scheduler tick and every bet check, with the deadline computed as opened_at + duration. Lowering it from 600 to 60 while a round was 300s in closed that round instantly; raising it moved the closes_at clients were already counting down to. round_cooldown_seconds had the same property for the gap after a close. B-11 fixed this class of problem for the advertised jackpot; the timing fields were left live. Round now carries duration_seconds and cooldown_seconds, set from the config when it opens. round_deadline() is the single place the deadline is computed — the scheduler, place_bet's two checks and /rounds/current's closes_at all go through it — and the cooldown is read off the round that just closed, so the gap a round announced is the gap that's honoured. The config row becomes what the *next* round opens with. The migration backfills from the live config rather than leaving the column defaults: an instance running 300s rounds would otherwise see the round currently in progress jump to 600s the moment this lands, which is precisely the retroactive change being fixed. Verified against a scratch DB with a non-default config. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
1 parent
77e07e87dc
commit
37cc5eeeb5
11 files changed
+169
-37
No files matched your search
@@ -40,24 +40,6 @@ remains the last prerequisite for running unattended.
|
||||
|
||||
## Medium — correctness and robustness
|
||||
|
||||
### B-61 — config edits apply retroactively to the round already in progress
|
||||
|
||||
`app/rounds/scheduler.py:71`, `app/rounds/service.py:51-61`,
|
||||
`app/api/routes/admin.py:106-128`.
|
||||
|
||||
`round_duration_seconds` is read live on every tick and on every bet check, and the
|
||||
deadline is computed as `opened_at + duration`. Lowering it from 600 to 60 while a
|
||||
round is 300 s in closes that round instantly; raising it moves the `closes_at`
|
||||
clients are already counting down to. `round_cooldown_seconds` has the same
|
||||
property for the gap after a close.
|
||||
|
||||
B-11 fixed exactly this class of problem for `bet_amount_sats` (an in-progress
|
||||
round's advertised jackpot must not move when an operator edits the bet amount);
|
||||
the timing fields were left live.
|
||||
|
||||
Fix: snapshot the duration (and cooldown) onto the `Round` row when it opens and
|
||||
read them from there, leaving the config row as the value for the *next* round.
|
||||
|
||||
### B-62 — "withdraw the full amount" reliably produces an unbumpable transaction
|
||||
|
||||
`app/static/app.js:798-807`, `app/wallet/psbt_builder.py:138-141`,
|
||||
|
||||
Reference in new issue
Block a user