Retire in-code comments that outlived what they described (B-69)
- app/tx/reconcile.py called the payout retry "a future payout-retry routine — still an open gap". It shipped as B-26: clearing payout_txid leaves the round in exactly the state _retry_payout_if_due picks up, so an abandoned payout rebuilds itself and the log line next to it is an alert, not the recovery path. Reading it the old way, an operator would go hand-fix a round the scheduler was already retrying. - app/db/base.py sized the SQLite busy timeout against "five concurrent background tasks" and then listed only the non-listener ones; the lifespan starts six. - The third item (app/auth/routes.py citing B-31 where it meant B-33) was already correct in the tree; the test pins it so it stays that way. tests/unit/test_code_comments.py derives the task count from the lifespan's own create_task calls rather than restating it, so the comment fails the next time a task is added or removed instead of quietly going stale again. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
@@ -40,13 +40,6 @@ remains the last prerequisite for running unattended.
|
||||
|
||||
## Low — documentation and consistency drift
|
||||
|
||||
### B-69 — stale in-code comments
|
||||
|
||||
- `app/tx/reconcile.py:206` calls the payout retry "a future payout-retry routine —
|
||||
still an open gap"; it exists (B-26).
|
||||
- `app/db/base.py:9` says "five concurrent background tasks"; there are six.
|
||||
- `app/auth/routes.py:31` cites B-31 where it means B-33 (see B-58).
|
||||
|
||||
### B-70 — the flowchart's WITHDRAW precondition is not implemented as written
|
||||
|
||||
`flowchart/platform-overview.mmd:39` (node E1) states a withdrawal cannot happen
|
||||
|
||||
Reference in New Issue
Block a user