Always keep a change output, so every tx stays fee-bumpable (B-62)
The max-amount checkbox sends amount_sats == the whole confirmed balance, so change came out at 0, the change output was dropped, and the transaction had a single output. bump_fee has nothing to shrink there: it raised RbfError every 30s until the reconciler abandoned the row six hours later. The RBF single-change-output limitation was a documented gap, but the UI made it the *default* withdrawal path. The extra-input fallback would not have helped this case: a transaction moving the entire balance already spends every UTXO the sender has. So the fix is at build time — build_signed_transaction never produces a change output below DUST_LIMIT_SATS, and never folds it into the fee either: - withdrawals pass reduce_amount_to_keep_change=True and move a dust limit less. The fee already comes out of the withdrawn amount by design, so this is the same rule applied a little harder, and Withdrawal.amount_requested_sats vs amount_sent_sats already existed to record the difference. - bets don't: the bet is a fixed price that can't be quietly reduced. A balance exactly equal to the bet is refused with balance_leaves_no_change (translated into all 7 languages, carrying required_extra_sats), which turns "a user's balance must never exactly equal the bet" from a documented assumption into an enforced one — and stops an unbumpable bet from holding a round open until the reconciler gives up on it. bump_fee's no-change guard stays: a single-output tx broadcast before this change can still be pending across the deploy, and it must fail loudly rather than start shrinking a recipient's output. Its test now hand-builds that shape, precisely because the builder no longer will. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This commit is contained in:
1 parent
37cc5eeeb5
commit
8dd913ec59
9 files changed
+197
-51
No files matched your search
@@ -40,23 +40,6 @@ remains the last prerequisite for running unattended.
|
||||
|
||||
## Medium — correctness and robustness
|
||||
|
||||
### B-62 — "withdraw the full amount" reliably produces an unbumpable transaction
|
||||
|
||||
`app/static/app.js:798-807`, `app/wallet/psbt_builder.py:138-141`,
|
||||
`app/tx/broadcast.py:150-152`.
|
||||
|
||||
The max-amount checkbox sends `amount_sats == myBalanceSats == total_in`, so
|
||||
`change == 0`, the change output is dropped, and the tx has a single output. `bump_fee`
|
||||
then finds no change output to absorb the increase and raises `RbfError` every 30 s
|
||||
until the reconciler abandons the row six hours later. The RBF single-change-output
|
||||
limitation is a documented gap, but the UI makes it the *default* withdrawal path
|
||||
rather than a corner case (the same applies to an exact-amount bet).
|
||||
|
||||
Fix directions: leave a change output above `DUST_LIMIT_SATS` when the requested
|
||||
amount would consume the whole input total (i.e. reserve a little), or warn in the
|
||||
UI that a full-balance withdrawal cannot be fee-bumped, or implement the
|
||||
extra-input RBF fallback.
|
||||
|
||||
### B-63 — `tip_height == 0` window right after connecting can seed a draw from a pre-close block
|
||||
|
||||
`app/electrum/listener.py:160-167`, `app/rounds/scheduler.py:153`.
|
||||
|
||||
Reference in new issue
Block a user