Files
plm-lottery/docs/adr/ADR-31-tutto-cio-spende-denaro-scrive-prima.md
T
davideandClaude Sonnet 5.5 2b6ddb019b Never roll back an ambiguous broadcast as if it had been refused (B-76, TX-04, TX-05, TX-20, TX-21, BET-16, BET-17, BET-23, WDR-11, WDR-12, WDR-16, API-13)
place_bet and request_withdrawal released everything on any exception from the
broadcast, including the 15s timeout and a connection dropped after the write. The
tx may have propagated: a bet's sats landed in the pool with no participant, a
withdrawal left while its row said failed and its coins were spendable again.

- client: ElectrumRpcError (subclass of ElectrumError) is raised only for a reply
  carrying a JSON-RPC `error`; timeouts, drops and write errors stay plain
  ElectrumError.
- tx/outcome.py:broadcast_with_verdict sorts a broadcast into accepted / refused /
  uncertain. A refusal is verified first: ElectrumListener.transaction_known asks
  blockchain.transaction.get of the active server and every other one (10s each) —
  any server returning the tx means accepted; the active server plus
  MIN_QUORUM_RESPONSES others all denying it means refused (ALLOW_NO_QUORUM keeps
  the reduced rule); too few answers is uncertain. "already known" wording is only a
  shortcut that skips the check. With no network to ask, a refusal is uncertain.
- place_bet / request_withdrawal / _trigger_payout use it: only a verified refusal
  releases; uncertain leaves the rows building for the reconciler, publishes SSE and
  POST /bets and POST /withdrawals answer 202 with status building; "already known"
  promotes a payout (payout_sent) like any accepted broadcast.
- An accepted transaction is fanned out to every other server
  (ElectrumListener.fan_out_transaction, best effort, off the caller's path). The RBF
  replacement in bump_fee is left for B-77, which rewrites that function.

Tests changed because the spec changed: the existing "refused broadcast" tests raised
a bare RuntimeError (now an uncertain outcome) and are made explicit refusals
(rpc_error) with a network that denies the tx; direct route calls pass a Response;
FakePayoutListener gains the network surface.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
2026-10-14 14:22:20 +02:00

1.7 KiB

ADR-31 — Tutto ciò che spende denaro si scrive prima di inviarlo

  • Stato: Accettata — implementazione da completare (B-77)
  • Area: Denaro in movimento
  • Fonte di verità per: la scelta di progetto descritta qui sotto; i requisiti (PREFISSO-NN) che la attuano stanno nei documenti di dominio, indicati nelle Conseguenze.

Decisione

Tutto ciò che spende denaro si scrive prima di inviarlo (stato building, monete già segnate come spese) e si risolve contro la catena dopo; nessuna sessione del database resta aperta durante una chiamata di rete. Vale anche per le sostituzioni RBF: la nuova versione si salva come candidata prima dell'invio (B-77). Solo un rifiuto esplicito della rete annulla tutto e risponde 502; un invio dall'esito incerto (timeout, connessione caduta dopo la scrittura) lascia la riga building al riconciliatore e risponde 202 (ADR-51).

Codice: app/bets/service.py:place_bet · app/withdrawals/service.py:request_withdrawal · app/rounds/scheduler.py:RoundScheduler._trigger_payout · app/tx/broadcast.py:bump_fee · app/tx/reconcile.py:reconcile_once · Test: tests/unit/test_bets.py::test_bet_is_persisted_before_it_is_broadcast, tests/unit/test_broadcast_outcome.py, tests/unit/test_scheduler.py::test_trigger_payout_persists_before_broadcasting, tests/unit/test_reconcile.py Stato: da implementare (B-77), per le sostituzioni RBF · Oggi: bump_fee invia la sostituzione prima di salvarla.