davideandClaude Sonnet 5
30bde96b6e
RoundConfig gains round_duration_seconds, round_cooldown_seconds, min_amount_sats, fee_rate_sat_vb and rbf_timeout_seconds (plus a hardcoded default for the pre-existing bet_amount_sats) as column defaults on the model itself — get_round_config no longer seeds from Settings at all. Every call site that read these from settings (scheduler, bets, withdrawals, rounds service/route, RBF bumper) now reads the DB-backed RoundConfig instead. app/config.py now holds only true env-driven infra/secrets (database URL, Electrum connection, master key, JWT, admin token) — no business parameter has an env var anymore, matching an explicit decision to drop the "seed from settings" indirection entirely rather than keep a env fallback nobody should rely on. Migration backfills the existing round_config row via server_default (matching the old settings defaults) then drops the default, so future rows go through the ORM/model defaults instead of a stale constant. Tests updated: should_bump's timeout_seconds is now required (no settings fallback); test_scheduler.py seeds a RoundConfig row directly instead of monkeypatching settings; test_withdrawals.py and test_rounds_service.py use local constants mirroring the model defaults instead of reading them off settings. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
60 lines
2.3 KiB
Python
60 lines
2.3 KiB
Python
"""add operational params to round_config
|
|
|
|
Revision ID: 53cc70d16e63
|
|
Revises: 274efdcbfbcc
|
|
Create Date: 2026-07-21 14:44:09.866407
|
|
|
|
"""
|
|
from typing import Sequence, Union
|
|
|
|
from alembic import op
|
|
import sqlalchemy as sa
|
|
|
|
|
|
# revision identifiers, used by Alembic.
|
|
revision: str = '53cc70d16e63'
|
|
down_revision: Union[str, Sequence[str], None] = '274efdcbfbcc'
|
|
branch_labels: Union[str, Sequence[str], None] = None
|
|
depends_on: Union[str, Sequence[str], None] = None
|
|
|
|
|
|
def upgrade() -> None:
|
|
"""Upgrade schema."""
|
|
# server_default backfills the existing singleton row (if any) with the same
|
|
# defaults app/config.py used before these became DB-editable; dropped right
|
|
# after so new rows go through the ORM defaults instead of a stale constant.
|
|
op.add_column(
|
|
'round_config', sa.Column('round_duration_seconds', sa.Integer(), nullable=False, server_default='600')
|
|
)
|
|
op.add_column(
|
|
'round_config', sa.Column('round_cooldown_seconds', sa.Integer(), nullable=False, server_default='30')
|
|
)
|
|
op.add_column(
|
|
'round_config',
|
|
sa.Column('min_amount_sats', sa.BigInteger(), nullable=False, server_default='100000000'),
|
|
)
|
|
op.add_column(
|
|
'round_config', sa.Column('fee_rate_sat_vb', sa.Integer(), nullable=False, server_default='1')
|
|
)
|
|
op.add_column(
|
|
'round_config', sa.Column('rbf_timeout_seconds', sa.Integer(), nullable=False, server_default='900')
|
|
)
|
|
with op.batch_alter_table('round_config') as batch_op:
|
|
batch_op.alter_column('round_duration_seconds', server_default=None)
|
|
batch_op.alter_column('round_cooldown_seconds', server_default=None)
|
|
batch_op.alter_column('min_amount_sats', server_default=None)
|
|
batch_op.alter_column('fee_rate_sat_vb', server_default=None)
|
|
batch_op.alter_column('rbf_timeout_seconds', server_default=None)
|
|
# ### end Alembic commands ###
|
|
|
|
|
|
def downgrade() -> None:
|
|
"""Downgrade schema."""
|
|
# ### commands auto generated by Alembic - please adjust! ###
|
|
op.drop_column('round_config', 'rbf_timeout_seconds')
|
|
op.drop_column('round_config', 'fee_rate_sat_vb')
|
|
op.drop_column('round_config', 'min_amount_sats')
|
|
op.drop_column('round_config', 'round_cooldown_seconds')
|
|
op.drop_column('round_config', 'round_duration_seconds')
|
|
# ### end Alembic commands ###
|