davide/purple-electrumwallet
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

tests: lnpeer: uncomment testcase: test_modern_shutdown_no_overlap

Browse Source 
This test case has always been disabled, but looks like the justification is easy to fix.
This commit is contained in:
SomberNight
2026-03-12 14:54:44 +00:00
parent 169227e148
commit 1c24c61364
1 changed files with 13 additions and 10 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/test_lnpeer.py
+13 -10
View File
@@ -1571,16 +1571,19 @@ class TestPeerDirect(TestPeer):
alice_fee_range={'min_fee_satoshis': 1, 'max_fee_satoshis': 10}, alice_fee_range={'min_fee_satoshis': 1, 'max_fee_satoshis': 10},
bob_fee_range={'min_fee_satoshis': 10, 'max_fee_satoshis': 300}) bob_fee_range={'min_fee_satoshis': 10, 'max_fee_satoshis': 300})
## This test works but it is too slow (LN_P2P_NETWORK_TIMEOUT) @mock.patch('electrum.lnpeer.LN_P2P_NETWORK_TIMEOUT', 0.05)
## because tests do not use a proper LNWorker object async def test_modern_shutdown_no_overlap(self):
#def test_modern_shutdown_no_overlap(self): with self.assertLogs('electrum', level='ERROR') as logs:
# self.assertRaises(Exception, lambda: asyncio.run( with self.assertRaisesRegex(Exception, "closing_signed not received"):
# self._test_shutdown( await self._test_shutdown(
# alice_fee=1, alice_fee=1,
# bob_fee=200, bob_fee=200,
# alice_fee_range={'min_fee_satoshis': 1, 'max_fee_satoshis': 10}, alice_fee_range={'min_fee_satoshis': 1, 'max_fee_satoshis': 10},
# bob_fee_range={'min_fee_satoshis': 50, 'max_fee_satoshis': 300}) bob_fee_range={'min_fee_satoshis': 50, 'max_fee_satoshis': 300})
# )) self.assertTrue(any(("bob->alice" in msg and "There is no overlap between between their and our fee range." in msg) for msg in logs.output))
self.assertTrue(any(("alice->bob" in msg and "closing_signed not received, force closing." in msg) for msg in logs.output))
# note: "Task exception was never retrieved" for "Exception: There is no overlap [...]"
# is because we don't start peer.main_loop and hence peer.taskgroup is never joined.
async def _test_shutdown(self, alice_fee, bob_fee, alice_fee_range=None, bob_fee_range=None): async def _test_shutdown(self, alice_fee, bob_fee, alice_fee_range=None, bob_fee_range=None):
graph = self.prepare_chans_and_peers_in_graph(self.GRAPH_DEFINITIONS['single_chan']) graph = self.prepare_chans_and_peers_in_graph(self.GRAPH_DEFINITIONS['single_chan'])