davide/purple-electrumwallet
1
0
Fork 0
Code Issues 1 Pull Requests Actions Packages Projects Releases Wiki Activity

crash_reporter: detect more altcoin-forks, don't send reports

Browse Source 
A new crash report [0] looks to be from a fork where the altcoin has the same genesis block [1] as Bitcoin.
But ofc "branding" is important, so they updated the URLs to point to their fork -- so we could also test against that.

[0]: https://github.com/spesmilo/electrum/issues/10610
[1]: https://github.com/palladium-coin/pallectrum/blob/0df81c6af8d36f3549739576681d3df9969e32fd/electrum/constants.py#L194
This commit is contained in:
SomberNight
2026-04-27 14:03:29 +00:00
parent 9b26c1812d
commit 3534f62b0b
1 changed files with 9 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
electrum/base_crash_reporter.py
+9 -3
View File
@@ -89,13 +89,19 @@ class BaseCrashReporter(Logger):
def send_report(self, asyncio_loop, proxy: 'ProxySettings', *, timeout=None) -> CrashReportResponse: def send_report(self, asyncio_loop, proxy: 'ProxySettings', *, timeout=None) -> CrashReportResponse:
# FIXME the caller needs to catch generic "Exception", as this method does not have a well-defined API... # FIXME the caller needs to catch generic "Exception", as this method does not have a well-defined API...
if (constants.net.GENESIS[-4:] not in [ bitcoinlike_genesis = constants.net.GENESIS[-4:] in [
"e26f", # mainnet "e26f", # mainnet
"4943", # testnet 3 "4943", # testnet 3
"f043", # testnet 4 "f043", # testnet 4
"1ef6", # signet "1ef6", # signet
] and ".electrum.org" in BaseCrashReporter.report_server): ]
# Gah! Some kind of altcoin wants to send us crash reports. is_forked_codebase = not bitcoinlike_genesis or "/spesmilo/" not in constants.GIT_REPO_URL
if is_forked_codebase and ".electrum.org" in BaseCrashReporter.report_server:
# Some kind of altcoin wants to send us crash reports... ?
# - You, the reader, yes *you*: if you forked the codebase e.g. to support an altcoin,
# please consider that upstream Electrum does NOT want to receive automated crash reports
# from your users. You should set up your own crash report server,
# and change `BaseCrashReporter.report_server` accordingly, or just disable reporting.
raise Exception(_("Missing report URL.")) raise Exception(_("Missing report URL."))
report = self.get_traceback_info(*self.exc_args) report = self.get_traceback_info(*self.exc_args)
report.update(self.get_additional_info()) report.update(self.get_additional_info())