21e637f543
network: validate server peers sent by main server
...
Data returned by the main server for request "server.peers.subscribe"
is of course untrusted input. Previously if it contained e.g. invalid port numbers
or IP addresses, it could kill the whole network taskgroup.
(this might have only affected master and not released versions,
which would only raise exceptions once the client actually tried to connect to an invalid host/port)
2020-05-13 19:28:35 +02:00
11aaa0b66f
Simplify services (watchtower, payserver):
...
- Do not expose services settings in GUI
- Use a single netaddress configuration variable.
2020-05-10 14:52:50 +02:00
9ac41be1e8
network: set .oneserver in __init__
...
fixes #6135
2020-05-01 03:27:31 +02:00
cd199390e2
Use non-standard localhost port for server-string fallback ( #6087 )
...
* Use non-standard localhost port for server-string fallback
Co-authored-by: Luke Childs <lukechilds123@gmail.com >
2020-04-16 19:39:05 +00:00
9e57ae630b
network/gui: unify host/port input fields to single server str
...
This allows optionally specifying the protocol for the main server.
fixes #6095
fixes #5278
2020-04-16 21:19:48 +02:00
b2cfaddff2
network.NetworkParameters: merge host+port+protocol into "server" field
2020-04-16 21:19:45 +02:00
adc3784bc2
network: allow mixed protocols among interfaces
...
Previously all the interfaces used either "t" or "s".
Now the network only tries to use "s" for all interfaces, except for
the main interface, which the user can manually specify to use "t".
(so e.g. if you run with "--server localhost:50002:t", the main server will use "t",
but all the rest will use "s")
2020-04-16 21:19:42 +02:00
76f0ad3271
util: add NetworkRetryManager, a baseclass for LNWorker and Network
2020-04-15 17:24:07 +02:00
86b29603cb
network: (trivial) rename field to indicate private
2020-04-15 17:24:00 +02:00
ac749f3a19
network: introduce NUM_STICKY_SERVERS
2020-04-15 17:23:57 +02:00
34e3e48ba5
network: rm server_queue
...
it's no longer needed; now it was just an extra level of indirection
2020-04-15 17:23:54 +02:00
8baa79be88
network: implement exponential backoff for retries
2020-04-15 17:23:50 +02:00
cf1f2ba4dc
network: replace "server" strings with ServerAddr objects
2020-04-15 17:23:47 +02:00
9224404108
Move callback manager out of Network class
2020-04-14 18:29:51 +02:00
1d667fe932
Hard fail on bad server-string ( #6086 )
...
* If server-string can't be parsed, fall back to localhost.
Co-Authored-By: Luke Childs <lukechilds123@gmail.com >
Co-authored-by: ghost43 <somber.night@protonmail.com >
2020-04-14 12:15:28 +00:00
8be94076b5
network: update tx broadcast error msgs whitelist
...
fixes #6052
2020-03-31 07:08:31 +02:00
a7c02c770d
follow-up prev: network.interface might be None
2020-03-13 18:07:05 +01:00
133d74adfb
fee estimates: use median if auto-connect
2020-03-12 15:39:50 +01:00
0d160cceea
Qt: test if lightinng is running
2020-03-06 11:23:26 +01:00
88650ed8d6
network UntrustedServerReturnedError: add "DO NOT TRUST..." tag
2020-02-28 18:47:12 +01:00
ce81957d25
blockchain: move init_headers_file from network.py to blockchain.py
...
and don't run it every time the network restarts
2020-02-27 20:45:29 +01:00
b21bcf5977
taskgroups: don't log CancelledError
2020-02-27 20:22:49 +01:00
ed234d3444
rename all TaskGroup() fields to "taskgroup"
...
for consistency
2020-02-27 19:13:56 +01:00
36f32651cc
Define network.try_broadcasting() method.
...
Use it when rebroadcasting a force-close tx,
because the channel state is already set.
2020-02-16 12:59:09 +01:00
cded582fe9
Start watchtower if run_watchtower is set, even if lightning is not activated ( fix #5896 ).
...
Fix parameters of sweepstore.add_sweep_tx, rm dead code.
2020-02-02 12:10:10 +01:00
11452722af
network dns hacks: split from network.py into its own file
2020-01-22 18:32:57 +00:00
cb88a3b6e4
dns hacks on windows: resolve A and AAAA records in parallel
2020-01-22 18:32:57 +00:00
0b0139c676
network.get_transaction: move some response validation logic from Synchronizer
2020-01-09 19:23:28 +01:00
37747d7469
split network main_taskgroup: create daemon.taskgroup
...
network.main_taskgroup restarts every time the proxy settings are changed,
many long-running tasks (some introduced with lightning) are not prepared for and do not want this.
2020-01-09 19:23:21 +01:00
6709ec4117
dns hacks on windows: cache dns when using dnspython
...
related #4421
related #5337
2020-01-01 06:23:51 +01:00
308517d473
python 3.8: adapt to breaking changes re asyncio.CancelledError
...
(and TimeoutError)
closes #5798
2019-12-11 23:07:47 +01:00
68dad21fb4
network: make best_effort_reliable smarter and a bit more lenient
...
related: #5815
2019-12-01 23:24:43 +01:00
bafe8a2fff
integrate PSBT support natively. WIP
2019-11-04 22:24:36 +01:00
90ce9f195b
Allow user to enable lightning in the GUI. Make it a per-wallet setting.
2019-10-13 20:34:38 +02:00
8c1adc2f50
fix dns issue on Windows
...
closes #5638
2019-09-18 19:11:40 +02:00
b2920db8b8
config: enforce that SimpleConfig is singleton
...
related: #5629
2019-09-10 18:01:10 +02:00
d1026b5afe
follow-up: SimpleConfig is supposed to be singleton
...
see cefa4762ba#5629
2019-09-10 16:38:10 +02:00
befa8ea771
transaction: kill "name", "csv_delay", "cltv_expiry" fields
2019-09-09 19:38:35 +02:00
e5502a58ba
uncomment breach_remedy in watchtower
2019-09-09 18:49:14 +02:00
9e57a59615
network: handle main_taskgroup dying better. passthrough CancelledError
...
Previously if a task running in the main_taskgroup raised,
main_taskgroup might have never finished as fx.run (another task running
in main_taskgroup) could not be cancelled (it was swallowing the CancelledError).
Need to be careful with catching all Exceptions or BaseExceptions,
as that might result in a coroutine not being cancellable.
Note that from python 3.8 onwards, CancelledError will inherit from BaseException
instead of Exception, so catching all Exceptions is somewhat less horrible
but this will only really matter if we raise the min py version to 3.8...
Really, all "except BaseException" lines are suspect and at least should be
considered for replacement with "except Exception".
-----
regarding fx.run not being cancellable before, and relevant lines, see:
https://github.com/spesmilo/electrum/blob/6197cfbb3b00f21fb01fd8ef95a849eb63fc9253/electrum/network.py#L1171
https://github.com/kyuupichan/aiorpcX/blob/0decdffce20aec217e9b4506ea20a0919994cea0/aiorpcx/curio.py#L242
https://github.com/kyuupichan/aiorpcX/blob/0decdffce20aec217e9b4506ea20a0919994cea0/aiorpcx/curio.py#L199
https://github.com/kyuupichan/aiorpcX/blob/0decdffce20aec217e9b4506ea20a0919994cea0/aiorpcx/curio.py#L208
https://github.com/kyuupichan/aiorpcX/blob/0decdffce20aec217e9b4506ea20a0919994cea0/aiorpcx/curio.py#L218
https://github.com/kyuupichan/aiorpcX/blob/0decdffce20aec217e9b4506ea20a0919994cea0/aiorpcx/curio.py#L221
https://github.com/spesmilo/electrum/blob/6197cfbb3b00f21fb01fd8ef95a849eb63fc9253/electrum/daemon.py#L194
https://github.com/spesmilo/electrum/blob/6197cfbb3b00f21fb01fd8ef95a849eb63fc9253/electrum/daemon.py#L203
https://github.com/spesmilo/electrum/blob/6197cfbb3b00f21fb01fd8ef95a849eb63fc9253/electrum/exchange_rate.py#L507
https://github.com/spesmilo/electrum/blob/6197cfbb3b00f21fb01fd8ef95a849eb63fc9253/electrum/exchange_rate.py#L79
2019-08-30 19:46:25 +02:00
ba431495db
lnworker: fix silent TypeError in _calc_routing_hints_for_invoice
2019-08-20 09:03:12 +02:00
f7c05f2602
Synchronize watchtower asynchronously:
...
- remove remote_commitment_to_be_revoked
- pass old ctns to lnsweep.create_sweeptxs_for_watchtower
- store the ctn of sweeptxs in sweepStore database
- request the highest ctn from sweepstore using get_ctn
- send sweeptxs asynchronously in LNWallet.sync_with_watchtower
2019-08-20 09:03:12 +02:00
4ccfa39fdd
cli: fix add_peer cmd
2019-08-20 09:03:12 +02:00
180f6d34be
separate channel_db module
2019-08-20 09:03:12 +02:00
746dd725c6
follow-up previous
2019-08-20 09:03:11 +02:00
842fff832f
enable lightning through command line option
2019-08-20 09:03:11 +02:00
730be17aba
Use separate lightning nodes for gossip and channel operations.
2019-08-20 09:03:11 +02:00
dd7c4b3bab
sqlite in lnrouter
2019-08-20 09:03:11 +02:00
9206b6225b
tmp fix for circular imports
2019-08-20 09:03:11 +02:00
bc06ded4b9
persist nodes in channel_db on disk
2019-08-20 09:03:10 +02:00
SomberNight