39bc672da2
followup prev
2024-02-06 10:37:35 +01:00
cac9c4bbb9
qt: fix various issues on send_tab, fixes #8874
2024-02-06 10:35:42 +01:00
ff8f8d6104
qt: sweep_key_dialog: make UI a bit more intuitive
...
user complained:
> when you want to sweep an address. it's very unclear to me as a noob who is getting the money
> might want a little picture with an arrow to show which direction the funds are going
2024-02-05 23:26:39 +00:00
482ec89b5d
minor, code style, imports
2024-02-05 21:25:13 +01:00
4228911609
qml: close TxDetails on TX remove only after the 'removed_transaction' event has been received, so the
...
history model doesn't refresh too early (fixes #8782 )
2024-02-05 21:07:33 +01:00
620b46780b
Merge pull request #8870 from accumulator/wizard_component_race
...
qt: wizard: move page.on_ready() to just after construction
2024-02-05 18:12:24 +01:00
c78a90a242
qt: wizard: move page.on_ready() to just after construction to avoid triggering signal/slots that might
...
assume on_ready() has run
2024-02-05 18:11:43 +01:00
0a2a22b822
qt: use selected_key instead of selected_item[0] for ChoiceWidgets
2024-02-05 14:39:03 +01:00
0a6b2d521b
qml: move final wizard submit() to WizardComponent.finish handler
2024-02-05 11:13:58 +01:00
019baa5a71
Merge pull request #8862 from SomberNight/202401_qml_wizard_final_accept
...
qml wizard: run navmap[view]['accept'] handler a final time on finish
2024-02-05 10:46:22 +01:00
07dc80dd9a
qml wizard: stricter validation for new wallet name
...
user on bitcointalk [0] tried to create wallet with name "w/o 2FA".
Before this, one would only get an error after the last page of the wizard.
With this, the "Next" button does not even get enabled if the name does not look ok.
(and as in comment, maybe we should be even stricter re what is allowed)
[0]: https://bitcointalk.org/index.php?topic=5483514.msg63584789#msg63584789
2024-02-04 08:54:40 +00:00
ca206de16b
qt NetworkDialog: small clean-up
2024-02-03 11:52:33 +00:00
a9a8ed2eb4
follow-up: factor out more hardcoded "sat/byte" and "sat/b" strings
...
- rename globals
- also rm hardcoded strings from qml
- use consistent unit names in qml
(previously mixed sat/vB and sat/byte (latter coming from core lib))
2024-02-03 05:26:31 +00:00
13a421aabb
factor out hardcoded "sat/byte" and "sat/b" strings
...
Though note that the qml GUI has some more in qml/js context.
2024-02-03 04:18:46 +00:00
16eec8daf5
qml QEChannelDetails: show currentFeerate
...
related https://github.com/spesmilo/electrum/issues/8863
2024-02-03 03:43:16 +00:00
d7a9e2d022
qml QEChannelDetails: add some type hints
2024-02-03 03:35:54 +00:00
48a96f6776
qml wizard: run navmap[view]['accept'] handler a final time on finish
...
For example, see
https://github.com/spesmilo/electrum/blob/061c8211281d6c0b50166e4075656ce0fb2c89f5/electrum/plugins/trustedcoin/trustedcoin.py#L624
Even if navmap[view]['last'] is True, we still want the navmap[view]['accept'] handler to run.
fixes https://github.com/spesmilo/electrum/issues/8861
---
Note that an analogous issue does not exist for the desktop qt gui,
see https://github.com/spesmilo/electrum/blob/061c8211281d6c0b50166e4075656ce0fb2c89f5/electrum/gui/qt/wizard/wizard.py#L206
There, wizard.resolve_next is called regardless of is_last.
2024-01-31 12:59:47 +00:00
cb55c65677
qml wizard: WCWalletPassword: show warning if pw is too short
2024-01-31 10:28:10 +00:00
e7ebf5d950
qt wizard: handle some cases of hw device being unplugged during flow
...
To reproduce, open two wizards in parallel. Use one to enter the flow and start creating a wallet,
then physically unplug the hw device at the correct time, and use the other wizard to trigger a rescan.
The rescan will unpair the hw device, resulting in device_manager.client_by_id to return None when
continuing the flow on the first wizard.
fixes https://github.com/spesmilo/electrum/issues/8858
2024-01-31 04:02:02 +00:00
67b57da402
qml: WCHaveMasterKey: (fix) re-verify text in onTextChanged
...
fixes https://github.com/spesmilo/electrum/issues/8853
This is a bit ugly, but activeFocus is declared as final and cannot be overridden directly...
```
1.42 | W | gui.qml.qeapp | file:///home/user/wspace/electrum/electrum/gui/qml/components/controls/ElTextArea.qml:23:5: Cannot override FINAL property
```
2024-01-30 02:11:01 +00:00
522e9485c1
text gui: rm some magic numbers (ascii key codes), and small clean-up
2024-01-23 23:43:08 +00:00
cd3be429e4
qt: PayToEdit: always use monospace font
2024-01-23 00:49:03 +00:00
50a53aaedc
qml: handle 2fa wallet can have None for billing_info
2024-01-22 13:30:46 +01:00
43a5d03426
qt: coins tab: also define sort order for coins mined in same block
...
follow-up 0f55a1e309
2024-01-19 14:34:33 +00:00
9518bd0e68
qt: replace timer based delayed call with a less confusing event loop queued call
2024-01-19 14:57:55 +01:00
17147732fb
qt: fix macOS workaround introducing race
2024-01-19 14:54:23 +01:00
9fd16cd677
follow-up prev
2024-01-19 13:19:44 +00:00
0f55a1e309
qt: coins tab: properly sort unconfirmed/local utxos to top
2024-01-19 13:12:36 +00:00
1f5004320b
qt: re-add processEvents() calls for abstract wizard.
...
might work around #8809/#8815
2024-01-18 17:55:52 +01:00
55a2005a6b
qml: update history view after address/key delete. fixes #8782
2024-01-18 00:28:02 +01:00
49c3567d7d
wallet: simplify bump_fee: rm txid arg
...
closes https://github.com/spesmilo/electrum/issues/8797
2024-01-17 19:20:29 +00:00
4a82072443
qt: new_channel_dialog: init USE_RECOVERABLE_CHANNELS cb intuitively
...
if `not lnworker.can_have_recoverable_channels()`,
- previously: the cb was disabled and checked
- now: the cb is disabled and unchecked
2024-01-17 14:13:20 +00:00
e2bb7df54a
qml: invert, more strict check in determine_can_pay for invoice types,
...
also disable paste button while PI is being evaluated
2024-01-17 14:09:57 +01:00
4469e9989d
qml: LNURLp has no bolt11 to query until later. fixes #8822
2024-01-17 13:52:01 +01:00
248e50eed0
transaction: rename tx.is_final to tx.is_rbf_enabled, and invert it
2024-01-17 02:08:15 +00:00
52c4acb483
Merge pull request #8814 from SomberNight/202401_lnpeer_chan_reest
...
lnpeer.reestablish_channel: fix some timing issues for dataloss case
2024-01-16 17:33:27 +00:00
6a28ef5db3
qt: add ElectrumWindow.set_payment_identifier delegate
2024-01-16 17:40:50 +01:00
291f0ce235
qml: handle exception more gracefully when attempting to delete last address from imported wallet
2024-01-16 15:56:49 +01:00
4a4497b5e9
qt: wizard: styling, add icons to success/error messages
2024-01-16 12:44:00 +01:00
82c21bc30d
wizard: take hardware_device from correct location for cosigners. fixes #8808
2024-01-16 11:45:20 +01:00
2b3d7096c6
qt: add typing to ResizableStackedWidget, add index validation to setCurrentIndex,
...
return None for currentWidget() if current_index == -1
2024-01-16 11:13:57 +01:00
d19dd817d3
followup dab768b932
2024-01-16 10:27:40 +01:00
d4f31929af
qt chan details dlg: add onchain feerate, to_self_delay
2024-01-16 04:07:48 +00:00
df58dd1f25
lnchannel.get_close_opts: allow REQUEST_REMOTE_FCLOSE if WE_ARE_TOXIC
...
related https://github.com/spesmilo/electrum/issues/8770
2024-01-15 20:13:38 +00:00
57bd291491
call super().__init__() for WalletFileException descendants,
...
qt: handle unfinished wallets when opened via File>Open (ref #8809 )
2024-01-15 17:06:44 +01:00
d660c57808
qt BalanceToolButton: rm hardcoded min size
...
"18 pixels" is too large when using qdarkstyle on "low" DPI screens, on Windows
(if there is also a high DPI screen connected as another monitor... eh)
2024-01-15 15:08:59 +00:00
66b24411e0
qt BalanceToolButton: better sizing on high DPI screens
...
specifically, on Windows, with display scaling > 100%, the pie btn was too small (not scaled)
2024-01-15 14:41:00 +00:00
10be631039
qml: tx.txid() can be None in qetxfinalizer. fixes ( #8807 )
2024-01-13 01:36:45 +01:00
14ec36dba1
Merge pull request #8741 from accumulator/labels_update
...
add labels_received callback and update labels even when set for item
2024-01-11 16:05:04 +01:00
d89f9846b9
qt/qrreader(zbar): don't call callback if user closes camera window
...
- without this, in send tab paytoedit, try_payment_identifier will get called and it will error
https://github.com/spesmilo/electrum/blob/df1b9a223c77f4597a75df4e040754a58185151f/electrum/gui/qt/paytoedit.py#L153
- also, in all text fields this used to result in clearing the current text (but now it is kept instead)
2024-01-10 20:39:58 +00:00
Sander van Grieken