7f64ecc4bd
wallet.bump_fee: the glorious return of BumpFeeStrategy :D
...
gui/qt/rbf_dialog.py (old) lines 57-64 were implementing logic that should not be part of GUI code.
Case in point, gui/qml/qetxfinalizer.py (old) lines 511-513 duplicated half of that logic but not the other half.
That logic is now moved to wallet.get_bumpfee_strategies_for_tx().
More context: a user on irc got confused when using the qml gui. They were sending "max" and wanted to bump_fee.
The qml gui selected the "preserve_payment" strategy by default, using which there was no solution, and the user
did not notice that the strategy can be altered (via the "method" dropdown). The qt gui had logic to select
"decrease_payment" by default in such a case (which does find a solution to bump) but this logic was not
duplicated in the qml gui.
Instead of duplicating the logic, this commit moves it to shared lib code.
2023-11-20 18:55:43 +00:00
03dd38bfb8
qml: add support for ln address and openalias, fix lnurl finalize step,
...
avoid overloading invoiceParser with new payment identifiers while potentially long-running
resolve/finalize steps are ongoing, show errors inresolve/finalize steps to user.
2023-11-20 17:16:22 +01:00
ff77013a82
qml: check if self._orig_tx is valid. fixes #8407
2023-11-20 17:13:23 +01:00
b098be988e
qml: show channel close tx(id) in ChannelDetails
2023-11-20 12:58:48 +01:00
a57a0d001b
qml: make TextAreas more visible
2023-11-15 18:42:11 +01:00
f8eb2e8cf8
qml: resize menus according to content
2023-11-15 17:35:08 +01:00
4ab973f93d
followup 3793a6b6b6, remove leftovers
2023-11-14 17:22:05 +01:00
3793a6b6b6
qml: use highlight pane for QR codes, refactor ReceiveDialog invoice select UI.
2023-11-14 17:19:27 +01:00
86a45c668c
few small fixes
2023-11-14 14:36:54 +01:00
621a397b70
i18n: translate a few untranslated strings and avoid early translate for pr_tooltips and pr_expiration_values
...
fixes #8689
2023-11-14 12:07:49 +01:00
94b1df4a08
qml: small UI fix, wording.
2023-11-13 11:35:30 +01:00
4a3a61c6b0
Merge pull request #8678 from accumulator/qml_password_strength
...
qml: introduce PasswordStrengthIndicator control, and add to Password…
2023-11-11 09:52:52 +01:00
d1d4e19554
qml: txdetails: add lockDelay property when height is TX_HEIGHT_FUTURE and add mempool depth for height TX_HEIGHT_UNCONF_PARENT
2023-11-10 17:03:56 +01:00
de0dc93a9d
Merge pull request #8675 from accumulator/address_delete
...
qml: implement delete address for imported wallets
2023-11-10 15:23:29 +01:00
4252c30210
Merge pull request #8682 from accumulator/about_version
...
qml: remove APK version, add Qt and PyQt version strings to About page
2023-11-10 15:04:53 +01:00
3967323842
qml: refactor ChannelDetails. Add funding outpoint
2023-11-10 13:02:55 +01:00
2995bc8b37
qml: fix dialog not closing if dialog is shown/hidden more than once
...
most dialogs are destroyed when closed, therefore not hitting this bug,
but e.g. ChannelOpenProgressDialog is reused.
2023-11-10 11:59:22 +01:00
42f323ac8d
qml: remove APK version, add Qt and PyQt version strings to About page
2023-11-10 11:11:51 +01:00
0fb47c87d2
qml: fixes for CloseChannelDialog;
...
- split RequestForceClose and LocalForceClose options, as request force close is only available if connected.
- disable no close policy on dialog, as it locks the user in the dialog if no succesful close is initiated.
what this intended to do is keep the backing object QEChannelDetails alive until a result is obtained, to avoid
exceptions when emitting the result signal. this is now handled more robustly, the user can leave the dialog
without triggering exceptions later.
2023-11-10 10:58:08 +01:00
e011bd235b
qml: implement delete address for imported wallets, and fix address list on address/key add.
2023-11-10 09:30:56 +01:00
98264f64ad
qml: introduce PasswordStrengthIndicator control, and add to PasswordDialog and WCWalletPassword
2023-11-10 09:30:31 +01:00
5ba156fcad
Merge remote-tracking branch 'remotes/accumulator/qt6'
...
For the "qml" gui (used on Android), this upgrades the qt version from 5.15 to 6.4.
PR https://github.com/spesmilo/electrum/pull/8545
2023-11-09 16:18:56 +00:00
047cc6f957
qml: remove attempt to unfocus by clicking dialog background
...
Doesn't really work as it triggers on events above the background it is defined on :(
2023-11-08 15:38:26 +01:00
8798a45d70
qml: fix issue with width of fiat textedit on ReceiveDetailsDialog
2023-11-07 17:05:13 +01:00
f708e7f03e
wizard/wallet: clean up imports, code style warnings.
2023-11-07 11:05:30 +01:00
a6432732f0
qml: addresses/coins filter match case insensitive, don't match 'None' for undefined fields
2023-11-07 10:47:34 +01:00
1544a71542
qml qr scanner: make xml layout look nicer
2023-11-07 10:32:14 +01:00
11d39cd942
qml: fix keyboard exclusion zone
...
turns out that Qt.inputMethod.keyboardRectangle.height is not suitable for calculating the exact keyboard
dimensions in Qt coordinates. Instead, use Qt.inputMethod.keyboardRectangle.y transformed to Qt coordinates
using Screen.devicePixelRatio
Note: Qt.inputMethod.keyboardRectangle stop being updated after exiting FLAG_SECURE state
(e.g. in seed or master key entry pages)
2023-11-07 10:32:00 +01:00
32c1915de4
qml: restore Send/ScanDialog for desktop/dev, keeping qr scan Activity for android only.
...
Also use stable R package, regardless of APP_PACKAGE_DOMAIN used in build.
2023-11-07 10:17:10 +01:00
5c3e14d8de
qml: replace Send/ScanDialog with java bases zxing qr scan activity.
2023-11-07 10:17:10 +01:00
c33ee87544
android: restore SimpleScannerActivity.java that was used in kivy
...
for QR code scanning with camera
https://github.com/spesmilo/electrum/blob/1c10b1ce00aa3621a229bc9fe05d3aeb2ace7da5/electrum/gui/kivy/data/java-classes/org/electrum/qr/SimpleScannerActivity.java
2023-11-07 10:17:10 +01:00
be801f30e8
gui: make common_qt compatible with both Qt5 and Qt6
2023-11-07 10:17:10 +01:00
db532dbd19
qml: android back-gesture conflict hack not working on qt6, replace with simple properties
2023-11-07 10:17:10 +01:00
a77ff9943a
qml: refactor qr scan to qt6
...
As the method of capturing frames is totally different, the animation when
a QR is found has been removed.
2023-11-07 10:17:10 +01:00
65d41ccc49
qml: qualify all signal handler parameters
2023-11-07 10:17:10 +01:00
ae446377f8
qml: work around toolbar layout not right-aligning indicators when indicators toggle visibility
2023-11-07 10:17:10 +01:00
8b567ae447
qml: remove all QML imports version numbers
2023-11-07 10:17:08 +01:00
6270eae5c9
qml: port PyQt5 to PyQt6
2023-11-07 10:16:18 +01:00
d6a6f56ddf
qml: add ice crystal icon and use for (un)freeze buttons.
2023-11-02 13:06:48 +01:00
4671c002c9
qt: fix detected account select ( #8673 )
2023-11-02 12:49:31 +01:00
e8f5aa50ca
Merge pull request #8653 from accumulator/addresses_coins_filter
...
qml: also show coins in Addresses page, and add a few filter options.…
2023-11-02 12:36:24 +01:00
6ce8a583fd
qt: add missing case for on-chain fallback for BIP21 payment identfier containing lightning invoice
2023-11-02 10:24:37 +01:00
c694415b4b
qml: add addresslist filter persistence
2023-11-01 18:23:16 +01:00
e88cf0a683
qml: addresses list formatting, add txid/outpoint and amount to filter
2023-11-01 17:17:16 +01:00
cf91d2e5cc
qml: also show coins in Addresses page, and add a few filter options. Additionally, long press
...
now activates multi-select mode, and add action to (un)freeze selection.
2023-11-01 14:32:38 +01:00
af61b9d86b
qml: also add share option for fallback address in InvoiceDialog
2023-11-01 11:38:47 +01:00
6c51927576
qml: emit error when bip21 contains neither an address nor a lightning invoice ( fixes #8662 )
2023-11-01 02:54:19 +01:00
711a325085
main_window: split out "walet info" dlg into separate file
...
- no semantic changes, only moving code
- the change in qt/util.py is to avoid GC issues
- due to moving code, the group was moving out of scope and getting GC-ed,
as we only keep a reference to the vbox
(idea from https://github.com/Electron-Cash/Electron-Cash/pull/2731/commits/263fb2ba332622a2f7b847377e9611a19854854b )
2023-10-31 17:41:11 +00:00
3060372894
qt wizard: WCHaveMasterKey: use check_multisig_constraints
...
These checks were missing from validation. e.g. duplicate master keys were allowed.
2023-10-31 17:43:15 +01:00
4b2d8f062c
qt wizard: fix WCHaveMasterKey for first multisig cosigner
...
fixes https://github.com/spesmilo/electrum/issues/8665
2023-10-31 17:43:15 +01:00
SomberNight