956bd3baaf
lnpeer: make per-peer TaskGroup a field (as for interfaces), and use it
...
lnpeer (and interface) response-handling-code should not run in the
network main_taskgroup as the remote could force an exception
to be raised and that would kill the whole network instead of just the peer
2019-08-30 19:51:17 +02:00
9e57a59615
network: handle main_taskgroup dying better. passthrough CancelledError
...
Previously if a task running in the main_taskgroup raised,
main_taskgroup might have never finished as fx.run (another task running
in main_taskgroup) could not be cancelled (it was swallowing the CancelledError).
Need to be careful with catching all Exceptions or BaseExceptions,
as that might result in a coroutine not being cancellable.
Note that from python 3.8 onwards, CancelledError will inherit from BaseException
instead of Exception, so catching all Exceptions is somewhat less horrible
but this will only really matter if we raise the min py version to 3.8...
Really, all "except BaseException" lines are suspect and at least should be
considered for replacement with "except Exception".
-----
regarding fx.run not being cancellable before, and relevant lines, see:
https://github.com/spesmilo/electrum/blob/6197cfbb3b00f21fb01fd8ef95a849eb63fc9253/electrum/network.py#L1171
https://github.com/kyuupichan/aiorpcX/blob/0decdffce20aec217e9b4506ea20a0919994cea0/aiorpcx/curio.py#L242
https://github.com/kyuupichan/aiorpcX/blob/0decdffce20aec217e9b4506ea20a0919994cea0/aiorpcx/curio.py#L199
https://github.com/kyuupichan/aiorpcX/blob/0decdffce20aec217e9b4506ea20a0919994cea0/aiorpcx/curio.py#L208
https://github.com/kyuupichan/aiorpcX/blob/0decdffce20aec217e9b4506ea20a0919994cea0/aiorpcx/curio.py#L218
https://github.com/kyuupichan/aiorpcX/blob/0decdffce20aec217e9b4506ea20a0919994cea0/aiorpcx/curio.py#L221
https://github.com/spesmilo/electrum/blob/6197cfbb3b00f21fb01fd8ef95a849eb63fc9253/electrum/daemon.py#L194
https://github.com/spesmilo/electrum/blob/6197cfbb3b00f21fb01fd8ef95a849eb63fc9253/electrum/daemon.py#L203
https://github.com/spesmilo/electrum/blob/6197cfbb3b00f21fb01fd8ef95a849eb63fc9253/electrum/exchange_rate.py#L507
https://github.com/spesmilo/electrum/blob/6197cfbb3b00f21fb01fd8ef95a849eb63fc9253/electrum/exchange_rate.py#L79
2019-08-30 19:46:25 +02:00
6197cfbb3b
Revert "Remove early return in create_sweeptxs_for_our_ctx."
...
This reverts commit d0cfb3ae12
2019-08-30 17:40:46 +02:00
3e8080b669
test_breach_with_spent_htlc: do not overwrite default_wallet, load toxic_wallet instead
2019-08-30 17:40:09 +02:00
10e186c1d3
revert ed086934e5
...
(this does not work well with travis)
2019-08-30 15:58:38 +02:00
6f333bd86d
make regtests more robust
2019-08-30 15:18:04 +02:00
5ec1db4d51
Ignore exceptions raised in lnworker.on_network_update.
...
Exception raised there may cancel the network's main taskgroup.
2019-08-30 12:37:34 +02:00
d0cfb3ae12
Remove early return in create_sweeptxs_for_our_ctx.
...
- This was added because we did not store the complete htlc history.
- It makes the result dependent on the current channel state
- That creates a race condition in sweep_info, because the result is cached.
- As a result, test_breach_with_spent_htlc was randomly failing.
2019-08-30 09:11:54 +02:00
5f817770af
android build: make sure to use correct pycryptodomex
...
note: buildozer casts all actual paths to lowercase but not the list of excluded paths...
see https://github.com/kivy/buildozer/blob/182d13f1027d4c16e04e1096c94ed3e488226330/buildozer/__init__.py#L775
2019-08-29 18:07:37 +02:00
01f582cc14
Remove electrumx.ml because of phishing ( #5596 )
2019-08-29 12:37:33 +00:00
f403735191
lnpeer: reestablish_channel - don't replay unacked msgs they alrdy have
...
e.g. Alice sends upd1, upd2, upd3, commitment_signed, upd4, upd5.
Bob receives all of these; and sends a revoke_and_ack but there is
a disconnect before Alice receives the revoke_and_ack.
During reestablish, if Bob claims to have received the commitment_signed,
Alice must not replay the msgs before that; but she should replay upd4 and upd5.
2019-08-29 12:37:25 +02:00
523de5782b
Fix travis error
2019-08-29 04:32:32 +09:00
2ee881f40a
qt channels list: fields should not be editable
2019-08-28 16:54:51 +02:00
db8e6cabb4
bip70 payreq: catch TimeoutError to avoid hanging "please wait" dialog
...
related #5337
2019-08-27 18:03:01 +02:00
3076eb75ea
make parsing lightning qr codes more robust
2019-08-27 17:12:43 +02:00
31a18f83f1
(trivial) fix variable name
2019-08-27 13:35:03 +02:00
7866caf2a7
minor fix: ensure request amount is not None
2019-08-26 16:59:38 +02:00
cf02e32f20
Merge pull request #5537 from xaya/test-verify-header
...
Unit tests for Blockchain.verify_header
2019-08-26 15:42:15 +02:00
58177c5bf3
Travis: run regtests in separate job
2019-08-26 13:52:55 +02:00
fcfbc937bc
buildozer: use log_level=1
2019-08-26 11:35:17 +02:00
d766ded8d4
Merge pull request #5584 from JeremyRand/lnaddr-bech32
...
lnaddr: Pull in Bech32 and Base58 prefixes from constants
2019-08-25 18:58:47 +02:00
8be94a9919
lnaddr: Pull in Bech32 and Base58 prefixes from constants
...
Fixes https://github.com/spesmilo/electrum/issues/5581
2019-08-25 13:15:13 +00:00
2b52ee26e6
store qt-console-history in wallet file ( fix #5563 )
2019-08-25 11:39:11 +02:00
95383a5820
Merge pull request #5582 from JeremyRand/test-lnchannel-outputs
...
Use NamedTuple notation for TxOutput in test_lnchannel
2019-08-25 10:17:54 +02:00
032810dace
test_lnrouter: Pull in chain_hash from constants
2019-08-25 07:19:36 +00:00
334d3f2818
Use NamedTuple notation for TxOutput in test_lnchannel
...
This makes the code more resilient in case additional members are added
to TxOutput later.
2019-08-25 06:51:31 +00:00
ab5a02ba50
kivy: remove hidden state in RefLabel, use it for seed and private keys
2019-08-23 15:46:58 +02:00
e9c32bad19
kivy: remove context menus, cleanup unused files
2019-08-23 12:15:42 +02:00
587f8aa487
Kivy GUI improvements:
...
- create unique instances of channels_dialog and addresses_dialog
- display and refresh balances in channels_dialog
- improve formatting of tx history
- repurpose left button in receive_tab
2019-08-22 19:04:32 +02:00
8010123c08
Display and refresh the status of incoming payment requests:
...
- All requests have an expiration date
- Paid requests are automatically removed from the list
- Unpaid, unconfirmed and expired requests are displayed
- Fix a bug in get_payment_status, conf was off by one
2019-08-22 06:00:45 +02:00
336cf81a6d
kivy: add expiration button to receive screen
2019-08-20 18:20:54 +02:00
27a9d02b8c
kivy: update receive screen after adding request
2019-08-20 16:07:40 +02:00
65cf0ebce8
lnpeer, minor fixes:
...
- pass orphaned_ids to lnworker.add_new_ids
- fix enumeration of get_unacked_local_updates()
2019-08-20 13:27:09 +02:00
dd22cb6dff
kivy: minor fixes
2019-08-20 09:03:12 +02:00
246cda2928
fix Flake8 tests
2019-08-20 09:03:12 +02:00
9cfeadea70
Turn daemon subcommands into RPCs
2019-08-20 09:03:12 +02:00
54257cbcca
Rewrite JsonRPC requests using asyncio.
...
- commands are async
- the asyncio loop is started and stopped from the main script
- the daemon's main loop runs in the main thread
- use jsonrpcserver and jsonrpcclient instead of jsonrpclib
2019-08-20 09:03:12 +02:00
fa5302bcfb
(trivial) fix type annotation
2019-08-20 09:03:12 +02:00
bce74717a6
lnpeer: in onion errors, handle channel updates both with and w/o type
2019-08-20 09:03:12 +02:00
beeb81e179
lnpeer: use correct failure codes in _maybe_forward_htlc
2019-08-20 09:03:12 +02:00
e54f0fbafa
do not raise BaseException
2019-08-20 09:03:12 +02:00
d955285808
lnrouter/channeldb: small import clean-up
2019-08-20 09:03:12 +02:00
47ee02569a
lnpeer: send own outgoing channel updates to remote peer
2019-08-20 09:03:12 +02:00
f0588846d5
channeldb: also store "message_flags" field for channel updates
...
this is a breaking change for the db format.
As in comment in diff,
"It would make more sense to store the raw gossip messages in the db."
2019-08-20 09:03:12 +02:00
d229bb4e4d
lnpeer: restore "temp save orphan channel updates" functionality
...
needed to handle race where remote might send chan_upd too soon
(before we save the short channel id for the channel after it reaches funding locked)
2019-08-20 09:03:12 +02:00
ba431495db
lnworker: fix silent TypeError in _calc_routing_hints_for_invoice
2019-08-20 09:03:12 +02:00
02681c6664
tests: some regtest tests need to mine more blocks to expire CLTVs
...
as lnutil.MIN_FINAL_CLTV_EXPIRY_FOR_INVOICE was recently bumped
2019-08-20 09:03:12 +02:00
a9295e495c
tests: regtest.sh now uses consistent indentation
2019-08-20 09:03:12 +02:00
6b1810f8dc
commands.py: fix type of "timeout" arg
...
was str by default
2019-08-20 09:03:12 +02:00
159fe04daf
lnpeer: on_channel_open should not fail on server error
2019-08-20 09:03:12 +02:00
SomberNight