SomberNight
fe5cb09e05
When creating a "zero-amount" payment request, currently we save a PaymentInfo with a "None" amount. I think there were a few releases in 2023 that saved PaymentInfos with a `0` amount instead. This was changed in #8659 [0], but as said there [1], a DB upgrade was not done. Now an assert added in [2] is failing due to this inconsistency, for affected old wallets. - I think to trigger that, one needs a wallet that has a payment request (with a `0` amount) created around that time, which is still unpaid. This patch tries to restore consistency by enforcing None amounts. fixes https://github.com/spesmilo/electrum/issues/10501 [0]: https://github.com/spesmilo/electrum/pull/8659 [1]: https://github.com/spesmilo/electrum/pull/8659#issuecomment-1777101285 [2]: https://github.com/spesmilo/electrum/commit/286fc4b86e4d23cb9af15b9061b3d709e7592bcb
55 lines
2.1 KiB
Python
55 lines
2.1 KiB
Python
import logging
|
|
import os
|
|
|
|
from . import ElectrumTestCase
|
|
|
|
from electrum.lnutil import RECEIVED, MIN_FINAL_CLTV_DELTA_ACCEPTED
|
|
from electrum.logging import console_stderr_handler
|
|
from electrum.invoices import LN_EXPIRY_NEVER, PR_UNPAID
|
|
|
|
|
|
class TestLNWallet(ElectrumTestCase):
|
|
TESTNET = True
|
|
|
|
@classmethod
|
|
def setUpClass(cls):
|
|
super().setUpClass()
|
|
console_stderr_handler.setLevel(logging.DEBUG)
|
|
|
|
async def asyncSetUp(self):
|
|
self.lnwallet_anchors = self.create_mock_lnwallet(name='mock_lnwallet_anchors', has_anchors=True)
|
|
await super().asyncSetUp()
|
|
|
|
def test_create_payment_info(self):
|
|
wallet = self.lnwallet_anchors
|
|
tests = (
|
|
(100_000, 200, 100),
|
|
(None, 200, 100),
|
|
(None, None, LN_EXPIRY_NEVER),
|
|
(100_000, None, 0),
|
|
)
|
|
for amount_msat, min_final_cltv_delta, exp_delay in tests:
|
|
payment_hash = wallet.create_payment_info(
|
|
amount_msat=amount_msat,
|
|
min_final_cltv_delta=min_final_cltv_delta,
|
|
exp_delay=exp_delay,
|
|
)
|
|
self.assertIsNotNone(wallet.get_preimage(payment_hash))
|
|
pi = wallet.get_payment_info(payment_hash, direction=RECEIVED)
|
|
self.assertEqual(pi.amount_msat, amount_msat)
|
|
self.assertEqual(pi.min_final_cltv_delta, min_final_cltv_delta or MIN_FINAL_CLTV_DELTA_ACCEPTED)
|
|
self.assertEqual(pi.expiry_delay, exp_delay or LN_EXPIRY_NEVER)
|
|
self.assertEqual(pi.db_key, f"{payment_hash.hex()}:{int(pi.direction)}")
|
|
self.assertEqual(pi.status, PR_UNPAID)
|
|
self.assertIsNone(wallet.get_payment_info(os.urandom(32), direction=RECEIVED))
|
|
|
|
def test_create_payment_info__amount_must_not_be_zero(self):
|
|
wallet = self.lnwallet_anchors
|
|
amount_msat, min_final_cltv_delta, exp_delay = (0, 200, 100)
|
|
with self.assertRaises(ValueError):
|
|
wallet.create_payment_info(
|
|
amount_msat=amount_msat,
|
|
min_final_cltv_delta=min_final_cltv_delta,
|
|
exp_delay=exp_delay,
|
|
)
|