davide/palladum-lightning
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

psbt: unused code path could leak

Browse Source 
If `wally_psbt_extract` fails the function returns early leaking psbt, if it was `taken()`.

Throw it on tmpctx so its not leaked in this case.

Changelog-None
This commit is contained in:
Dusty Daemon
2025-05-13 13:49:37 -04:00
committed by Rusty Russell
parent 9d773910c9
commit 5ef0ed3126
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
bitcoin/tx.c
View File

@@ -553,7 +553,7 @@ struct bitcoin_tx *bitcoin_tx_with_psbt(const tal_t *ctx, struct wally_psbt *psb
size_t locktime;
if (!taken(psbt))
psbt = clone_psbt(NULL, psbt);
psbt = clone_psbt(tmpctx, psbt);
wally_psbt_get_locktime(psbt, &locktime);
struct bitcoin_tx *tx = bitcoin_tx(ctx, chainparams,