davide/palladum-lightning
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

lightningd: hell, let's start with 64k fds.

Browse Source 
They're cheap.  The 2x channels heuristic is nice, but does assume
they restart every so often.  If someone hits 64k connections I would
like to know anyway!

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell
2024-05-09 13:00:16 +09:30
parent 80f1063dee
commit 9c9b6dd5f8
1 changed files with 20 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

31
lightningd/lightningd.c
View File

@@ -1090,6 +1090,8 @@ bool lightningd_deprecated_in_ok(struct lightningd *ld,
static void setup_fd_limit(struct lightningd *ld, size_t num_channels)
{
struct rlimit nofile;
/* This is more than you could have on a single IP anyway. */
size_t desired_fds = 65536;
if (getrlimit(RLIMIT_NOFILE, &nofile) != 0) {
log_broken(ld->log,
@@ -1099,20 +1101,27 @@ static void setup_fd_limit(struct lightningd *ld, size_t num_channels)
}
/* Aim for twice as many fds as current channels, for growth. */
if (nofile.rlim_cur < num_channels * ld->fd_limit_multiplier) {
if (num_channels * ld->fd_limit_multiplier > nofile.rlim_max) {
log_unusual(ld->log,
"WARNING: we have %zu channels but file descriptors limited to %zu!",
num_channels, (size_t)nofile.rlim_max);
if (num_channels * ld->fd_limit_multiplier > desired_fds)
desired_fds = num_channels * ld->fd_limit_multiplier;
if (nofile.rlim_cur < desired_fds) {
if (desired_fds > nofile.rlim_max) {
/* Sure, we would *like* 65536, but we're happy with 2x channels. */
if (num_channels * ld->fd_limit_multiplier > nofile.rlim_max) {
log_unusual(ld->log,
"WARNING: we have %zu channels but file descriptors limited to %zu!",
num_channels, (size_t)nofile.rlim_max);
}
nofile.rlim_cur = nofile.rlim_max;
} else {
log_debug(ld->log,
"Increasing file descriptor limit to %zu (%zu channels, max is %zu)",
num_channels * ld->fd_limit_multiplier,
num_channels,
(size_t)nofile.rlim_max);
nofile.rlim_cur = num_channels * ld->fd_limit_multiplier;
nofile.rlim_cur = desired_fds;
}
log_debug(ld->log,
"Increasing file descriptor limit to %zu (%zu channels, max is %zu)",
(size_t)nofile.rlim_cur,
num_channels,
(size_t)nofile.rlim_max);
if (setrlimit(RLIMIT_NOFILE, &nofile) != 0) {
log_broken(ld->log,
"Could not increase file limit to %zu: %s",