davide/palladum-lightning
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

renepay: add test for description interface

Browse Source 
Change-log: renepay: add test for description interface

Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
This commit is contained in:
Lagrang3
2024-11-05 15:05:50 +01:00
committed by Vincenzo Palazzo
parent 2d9277a9a1
commit ba905f7e20
2 changed files with 46 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
plugins/renepay/json.c
View File

@@ -226,8 +226,11 @@ void json_add_payment(struct json_stream *s, const struct payment *payment)
json_add_sha256(s, "payment_hash", &pinfo->payment_hash);
json_add_node_id(s, "destination", &pinfo->destination);
/* FIXME: we have not declared "description" in renepay's response
* schema
if (pinfo->description)
json_add_string(s, "description", pinfo->description);
*/
json_add_timeabs(s, "created_at", pinfo->start_time);
json_add_u64(s, "groupid", payment->groupid);

43
tests/test_renepay.py
View File

@@ -796,3 +796,46 @@ def test_hardmpp2(node_factory, bitcoind):
l1.wait_for_htlcs()
receipt = only_one(l3.rpc.listinvoices("inv")["invoices"])
assert receipt["amount_received_msat"] == Millisatoshi("800000sat")
def test_description(node_factory):
"""Test the processing of the payment description interface."""
l1, l2 = node_factory.line_graph(2)
# do not provide description in the command line, all payments should be
# fine
inv_with_desc = l2.rpc.invoice(
"100sat", "desctest1", "paying for pizza", deschashonly=False
)["bolt11"]
inv_with_hash = l2.rpc.invoice(
"100sat", "desctest2", "paying for coffee", deschashonly=True
)["bolt11"]
details = l1.rpc.call("renepay", {"invstring": inv_with_desc})
assert details["status"] == "complete"
details = l1.rpc.call("renepay", {"invstring": inv_with_hash})
assert details["status"] == "complete"
# pass a description in the command line, should check if the hash matches
inv_with_desc = l2.rpc.invoice(
"100sat", "desctest3", "paying for pizza", deschashonly=False
)["bolt11"]
inv_with_hash = l2.rpc.invoice(
"100sat", "desctest4", "paying for coffee", deschashonly=True
)["bolt11"]
details = l1.rpc.call(
"renepay", {"invstring": inv_with_desc, "description": "paying for pizza"}
)
assert details["status"] == "complete"
# if the description does not match the hash in the invoice, we fail
with pytest.raises(RpcError, match=r"h: does not match description"):
l1.rpc.call(
"renepay", {"invstring": inv_with_hash, "description": "paying for cookies"}
)
details = l1.rpc.call(
"renepay", {"invstring": inv_with_hash, "description": "paying for coffee"}
)
assert details["status"] == "complete"