davide/palladum-lightning
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

tools: delete gossip_store of needed for downgrade even if db hasn't changed.

Browse Source 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This commit is contained in:
Rusty Russell
2026-02-12 09:13:10 +10:30
parent 5e1bbb08c7
commit d4c62f8c4c
2 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
tests/test_downgrade.py
View File

@@ -80,7 +80,7 @@ def test_downgrade(node_factory, executor):
l1.daemon.executable = current_executable
# Another downgrade is a noop.
assert subprocess.check_output(cmd_line).decode("utf8").startswith("Already compatible with ")
assert "Already compatible with " in subprocess.check_output(cmd_line).decode("utf8")
# Should be able to upgrade without any trouble
l1.daemon.opts['database-upgrade'] = True

11
tools/lightning-downgrade.c
View File

@@ -239,6 +239,12 @@ int main(int argc, char *argv[])
migrations = get_db_migrations(&num_migrations);
prev_version = version_db(PREV_VERSION);
/* Do this even if the db hasn't changed. */
if (!version_db(PREV_VERSION)->gossip_store_compatible) {
printf("Deleting incompatible gossip_store\n");
unlink(path_join(tmpctx, net_dir, "gossip_store"));
}
/* Open db, check it's the expected version */
db = db_open(tmpctx, wallet_dsn, false, false, db_error, NULL);
if (!db)
@@ -290,11 +296,6 @@ int main(int argc, char *argv[])
printf("Downgrade to %s succeeded. Committing.\n", PREV_VERSION);
db_commit_transaction(db);
tal_free(db);
if (!version_db(PREV_VERSION)->gossip_store_compatible) {
printf("Deleting incompatible gossip_store\n");
unlink(path_join(tmpctx, net_dir, "gossip_store"));
}
}
/*** We don't actually perform migrations, so these are stubs which abort. ***/