davide/palladum-lightning
1
0
Fork 0
Code Issues Pull Requests Actions 5 Packages Projects Releases Wiki Activity

xpay: refuse request to pay 0msat.

Browse Source 
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Changelog-Fixed: JSON-RPC: `xpay` will refuse to make a 0msat payment (0msat invoice, partial payment, or manually-set on amountless invoice).
Fixes: https://github.com/ElementsProject/lightning/issues/8016
This commit is contained in:
Rusty Russell
2025-01-23 09:38:29 +10:30
parent 01bce4e7b7
commit fd7ac4e05b
1 changed files with 13 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
plugins/xpay/xpay.c
View File

@@ -1506,6 +1506,13 @@ static struct command_result *json_xpay_core(struct command *cmd,
if (msat)
return command_fail(cmd, JSONRPC2_INVALID_PARAMS,
"Cannot override amount for bolt12 invoices");
/* FIXME: This is actually spec legal, since invoice_amount is
* the *minumum* it will accept. We could change this to
* 1msat if required. */
if (amount_msat_is_zero(payment->full_amount))
return command_fail(cmd, JSONRPC2_INVALID_PARAMS,
"Invalid bolt12 invoice with zero amount");
payment->route_hints = NULL;
payment->payment_secret = NULL;
payment->payment_metadata = NULL;
@@ -1572,6 +1579,9 @@ static struct command_result *json_xpay_core(struct command *cmd,
else
payment->full_amount = *msat;
if (amount_msat_is_zero(payment->full_amount))
return command_fail(cmd, JSONRPC2_INVALID_PARAMS,
"Cannot pay bolt11 invoice with zero amount");
invexpiry = b11->timestamp + b11->expiry;
}
@@ -1587,6 +1597,9 @@ static struct command_result *json_xpay_core(struct command *cmd,
return command_fail(cmd, JSONRPC2_INVALID_PARAMS,
"partial_msat must be less or equal to total amount %s",
fmt_amount_msat(tmpctx, payment->full_amount));
if (amount_msat_is_zero(payment->amount))
return command_fail(cmd, JSONRPC2_INVALID_PARAMS,
"partial_msat must be non-zero");
} else {
payment->amount = payment->full_amount;
}