Matt Morehouse f382ec0452 connectd: pass correct buflen to memmem ...

After the first iteration of the loop, we call memmem with a buflen that
points past the end of buf.

In practice we probably never read the uninitialized memory since we
guarantee the buffer ends with "\r\n", and since most/all libc
implementations probably read the haystack sequentially. But maybe
there's some libc with a crazy optimization out there. It's good to use
an accurate buflen just in case.

Discovered this while running some unit tests with MSan.

2023-04-27 07:41:06 +09:30

9.6 KiB

Raw Blame History

View Raw